From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88D3EB64D9 for ; Fri, 7 Jul 2023 01:48:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA9998D0002; Thu, 6 Jul 2023 21:48:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5A1E8D0001; Thu, 6 Jul 2023 21:48:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A49768D0002; Thu, 6 Jul 2023 21:48:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 93E828D0001 for ; Thu, 6 Jul 2023 21:48:33 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 53D231C9008 for ; Fri, 7 Jul 2023 01:48:33 +0000 (UTC) X-FDA: 80983131306.05.EEBC03E Received: from out-27.mta0.migadu.com (out-27.mta0.migadu.com [91.218.175.27]) by imf18.hostedemail.com (Postfix) with ESMTP id 05F651C0009 for ; Fri, 7 Jul 2023 01:48:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NAnGKJVh; spf=pass (imf18.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.27 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688694510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pp8ftPIqIMWudMuh7pf3FOr9N5RY8pAcKRI4zNvC1xk=; b=MGI36Ikuwp5j4xmSjo7lAEs/3l1NUUXGSK31uzrdTgD3hXN7PB/dn2hxRsvlOYBz0QI+a7 jA1SEgDrpzmwwpRGUSzEfjsiRBNww5Je/yylK6aAb3dNL/GhZPjPRgy5TWzeZbgvAiWkGM uB5P+rKc63uqE0HRuYTnoZtQappuTNo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NAnGKJVh; spf=pass (imf18.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.27 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688694510; a=rsa-sha256; cv=none; b=gigFEUCYF6Nf9VB0xowDSX7LAJO/uiMYkU4dznsn0dwu1FwEhYcwbJkYoqx3aBgY9oam0W QNNuR25rAXgaanf+5Favo1HG6bnFiFw8xUzKxt+Dxf+dCnxr6RelNpwsd9sP7eVkVMek08 uAwsD9HmqNPqVhnd69gc9O5hQWnHiEg= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688694503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pp8ftPIqIMWudMuh7pf3FOr9N5RY8pAcKRI4zNvC1xk=; b=NAnGKJVhSLp4yv2kkSMp6ADs5X+O14sYJ3GsIbaqOhhGuEqWS8qfljYCRlUZlp9ICcdIYz 5FxxKOSECYnAUDSrDCflNCisXuLUqXM51woWVHg9ky1pusXt5nfstpC1xnpzNla/MRsAEM pVfOzYEieXPnM9NljXB2CjqfStTa/c0= MIME-Version: 1.0 Subject: Re: [PATCH] mm/memcg: remove definition of MEM_CGROUP_ID_MAX when !CONFIG_MEMCG X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230706112820.2393447-1-linmiaohe@huawei.com> Date: Fri, 7 Jul 2023 09:47:46 +0800 Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , cgroups@vger.kernel.org, LKML , Linux Memory Management List Content-Transfer-Encoding: 7bit Message-Id: <892B507C-CFE8-4792-BA5F-3C698290A8EE@linux.dev> References: <20230706112820.2393447-1-linmiaohe@huawei.com> To: Miaohe Lin X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 05F651C0009 X-Rspam-User: X-Stat-Signature: oisuuor3umwb6jtsbenn3dpcxsc8kyqn X-Rspamd-Server: rspam01 X-HE-Tag: 1688694509-758455 X-HE-Meta: U2FsdGVkX1+sYtxc1CiLXUwr0ldWhkizIAoVkaEa630OF9SSQDSGb4qlWOBu4nFPWtQ8XBoqKhQ0Hm7Fw8Y2+w0lsmXlrGNZAONmk0t+z2unXyhb6CzQVApecUO+jbwl7651IaURj+0kChJQtv7j8j9E2HKnKHHRGaxNWUoH7fAhdMgrOi0NR9t9SX06SwiRMudNpoyb/8DPOxhVytTl/DRl/FRWAqNHNBYyjK8XSvpv+wHEv2L8iMFjFF8SwPrBiKxuaJ5lvyeQXvHEqnxJ/kX6poYZWawHuhMVz6h6UEXZBEtidY+1qv+YQHyBc70vhUegmSQisi3V1wXtnNHIwlgIJEVpY2/tOCAE9m9YF2V+2y+xqRgEjpni15ssoL8lbI9DYmuV0HHc+9fvxpsoF3Q4yyO6Y0t2zzq+JjC+eRntUTWK9OKkG6sd4hgpabGYz4tZJcQqPfHsqoSMHLEsXj17Ve4qHGpuaRrKH22YsqA8ZIXg6V8aldbcNo22a7bIYfz9Vpi+HegghM6avajR2C+5c5SmesGRX/I7EcR3nn8wapEfPn117xijuDSnlCIcUKq04AXlj7qnaier2azvq6ysY2yuw22t9x2om6TW/9Nlo6CxCCd3p4bOOWoijrJDxxZo9i01TZ3knNZkbtIZ6pMPr/fTtdWSBb5DqlThHZXqdxp7jHrNqxSa/31s2JA9PPvBwBocwUUrONNgk9DR1LYv2cykb/V5TwqR+InPLn6ZCEWAbM/O0UpoqUC6AFnPG5NOmGIP8zwuTs/pSIm1s14jQiyKVvCvJ2bJ1iVTYfnUsSIRvUPTikQnPnvEiVlRWYysOgAfJAqqJ9iOSfqK2mAtyEETt+QfE2PuUnH/9C6JTmzMoiZu/7bKBrkm7AHkfYUHNrkViSQQVnZOmzp0ycqBNTMqIT91k7llW9O1IfLKtGpETRyYswJWyi189mKXE9LOU12kDYScKiVcoKO zGOM64pm cihv+s6vYup8aEYxiuE+ywPCQ6QOylH5b0677vmdMbdBp2KcKh+aMOi5Sa8Z78P7NywzaSlBUrglJtoSiIuop+Zo7wdu00dZNvGP4PmEdR7ZMN4DP/0sOAxTzRUivlDAiyj+YNAokdhkzr3hVzWdaBur7wJHUlhNexIlkSh8bywKUf2WsYQQGou4rEPDQDjQcoiwiiTNBlo39k4lXG0UJ+GxZ/+Y7PcXKRRQB1AaKRgwJX29fp2k4iLq6CbTLg1HqUmEh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 6, 2023, at 19:28, Miaohe Lin wrote: > > MEM_CGROUP_ID_MAX is only used when CONFIG_MEMCG is configured. Remove > unneeded !CONFIG_MEMCG variant. > > Signed-off-by: Miaohe Lin MEM_CGROUP_ID_MAX is also only used in mem_cgroup_alloc(), maybe you also could move it from memcontrol.h to memcontrol.c. And define it as: #define MEM_CGROUP_ID_MAX ((1U << MEM_CGROUP_ID_SHIFT) - 1) I am not suggesting defining it as USHRT_MAX, because if someone changes MEM_CGROUP_ID_SHIFT in the future, then MEM_CGROUP_ID_MAX will not updated accordingly. For this patch, LGTM. Reviewed-by: Muchun Song Thanks.