linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yuehaibing <yuehaibing@huawei.com>
To: <sfr@canb.auug.org.au>, <khlebnikov@yandex-team.ru>,
	<akpm@linux-foundation.org>, <mhocko@suse.com>,
	<hannes@cmpxchg.org>, <vbabka@suse.cz>, <jannh@google.com>,
	<gregkh@linuxfoundation.org>, <janne.huttunen@nokia.com>,
	<arunks@codeaurora.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH -next] mm/vmstat: Fix build error without CONFIG_VM_EVENT_COUNTERS
Date: Tue, 22 Oct 2019 20:57:35 +0800	[thread overview]
Message-ID: <8929a502-96d3-fef6-8c5c-885da60d60b2@huawei.com> (raw)
In-Reply-To: <20191022125124.32812-1-yuehaibing@huawei.com>

Pls ignore this, seems has fixed.

https://lore.kernel.org/linux-mm/cd1c42ae-281f-c8a8-70ac-1d01d417b2e1@infradead.org/T/#u

On 2019/10/22 20:51, YueHaibing wrote:
> If CONFIG_VM_EVENT_COUNTERS is n but CONFIG_MEMCG is y,
> vmstat_text is not equal stat_items_size:
> 
> mm/vmstat.c: In function vmstat_start:
> ./include/linux/compiler.h:350:38: error: call to __compiletime_assert_1659 declared
>  with attribute error: BUILD_BUG_ON failed: stat_items_size != ARRAY_SIZE(vmstat_text) * sizeof(unsigned long)
>   _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 2fdf561910a9 ("mm/memcontrol: use vmstat names for printing statistics")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  mm/vmstat.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index b2fd344..a19ed6e 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -1655,8 +1655,6 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos)
>  	stat_items_size += sizeof(struct vm_event_state);
>  #endif
>  
> -	BUILD_BUG_ON(stat_items_size !=
> -		     ARRAY_SIZE(vmstat_text) * sizeof(unsigned long));
>  	v = kmalloc(stat_items_size, GFP_KERNEL);
>  	m->private = v;
>  	if (!v)
> 



      reply	other threads:[~2019-10-22 12:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22 12:51 YueHaibing
2019-10-22 12:57 ` Yuehaibing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8929a502-96d3-fef6-8c5c-885da60d60b2@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=arunks@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=janne.huttunen@nokia.com \
    --cc=jannh@google.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=sfr@canb.auug.org.au \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox