From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29840ECAAA1 for ; Fri, 16 Sep 2022 01:37:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42B858D0002; Thu, 15 Sep 2022 21:37:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B3A98D0001; Thu, 15 Sep 2022 21:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22D158D0002; Thu, 15 Sep 2022 21:37:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0E6628D0001 for ; Thu, 15 Sep 2022 21:37:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D157781AD0 for ; Fri, 16 Sep 2022 01:37:41 +0000 (UTC) X-FDA: 79916236722.30.0C6C71A Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by imf12.hostedemail.com (Postfix) with ESMTP id 2C4D7400C7 for ; Fri, 16 Sep 2022 01:37:39 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VPupV65_1663292254; Received: from 30.240.97.224(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VPupV65_1663292254) by smtp.aliyun-inc.com; Fri, 16 Sep 2022 09:37:35 +0800 Message-ID: <891e03e1-1071-d1a4-a40c-fe537105b402@linux.alibaba.com> Date: Fri, 16 Sep 2022 09:37:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH V1 2/2] mm/damon/core: remove duplicate check about THP To: Andrew Morton , kernel test robot Cc: sj@kernel.org, llvm@lists.linux.dev, kbuild-all@lists.01.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220915142237.92529-2-xhao@linux.alibaba.com> <202209160528.6z2rUbjZ-lkp@intel.com> <20220915152618.a050c7b55bf786c9e2c823ea@linux-foundation.org> From: haoxin In-Reply-To: <20220915152618.a050c7b55bf786c9e2c823ea@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663292261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AX8O4TdQ0xpkavpd1YTeqGLs/bytlMo/MbLp4aKFKZc=; b=5/tmh3bw9awjjp2yDCMKP2Yzmn+ZH6MVfYyMoxy7BHDqnz7JhDxLodwgElnvrochY/yYYA JFPDMxKx7rb/eUvqMq9dC0qh5XvreULoTcd27ddpytgJ+tLquqtIdiEluDxQkBhF+qHDyi TvHzwkxvp40F4ftExWewYBGvZuP6NH4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.45 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663292261; a=rsa-sha256; cv=none; b=thDuMgFvXEWutb43zCSHlS5En98y4liMUAGQ7S6HnFUn9cOqhvMOthVm9UXEUXoyvuBARg 5oGNNqO6FMc1+QmzxCTMWsTjdBfp0Mtew4ERqtwW+m7Go44YZkXIHHDiI1Mx672Q+ZKk1L jXinGi3yamaWzk+xh3NYJLnyJ7figzQ= X-Stat-Signature: mywsyaa59npugn5h9kkw5o697dkzmpmm X-Rspamd-Queue-Id: 2C4D7400C7 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.45 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam06 X-HE-Tag: 1663292259-399102 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/9/16 上午6:26, Andrew Morton 写道: > On Fri, 16 Sep 2022 05:54:56 +0800 kernel test robot wrote: > >> Hi Xin, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on akpm-mm/mm-everything] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Xin-Hao/mm-damon-sysfs-avoid-call-damon_target_has_pid-repeatedly/20220915-230635 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything >> config: hexagon-randconfig-r002-20220915 (https://download.01.org/0day-ci/archive/20220916/202209160528.6z2rUbjZ-lkp@intel.com/config) >> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://github.com/intel-lab-lkp/linux/commit/7902790b04d0eb74686b55218e8ead191ba5c003 >> git remote add linux-review https://github.com/intel-lab-lkp/linux >> git fetch --no-tags linux-review Xin-Hao/mm-damon-sysfs-avoid-call-damon_target_has_pid-repeatedly/20220915-230635 >> git checkout 7902790b04d0eb74686b55218e8ead191ba5c003 >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash mm/damon/ >> >> If you fix the issue, kindly add following tag where applicable >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >>>> mm/damon/vaddr.c:451:7: error: call to undeclared function 'pmd_young'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] >> if (pmd_young(*pmd) || !page_is_idle(page) || >> ^ >> mm/damon/vaddr.c:451:7: note: did you mean 'pte_young'? >> arch/hexagon/include/asm/pgtable.h:273:19: note: 'pte_young' declared here >> static inline int pte_young(pte_t pte) >> ^ > Thanks. I guess the arch needn't implement pmd_young() if it doesn't > implement THP. > > I dropped the patch. Oh, my bad,  thanks.