From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA70EECE58F for ; Tue, 15 Oct 2019 14:04:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 881ED21A49 for ; Tue, 15 Oct 2019 14:04:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="iexJ4OXO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 881ED21A49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yandex-team.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36F658E0008; Tue, 15 Oct 2019 10:04:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31FEB8E0001; Tue, 15 Oct 2019 10:04:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 235ED8E0008; Tue, 15 Oct 2019 10:04:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 00B6A8E0001 for ; Tue, 15 Oct 2019 10:04:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 62776180257CD for ; Tue, 15 Oct 2019 14:04:49 +0000 (UTC) X-FDA: 76046189898.10.dust47_29f89e14ed723 X-HE-Tag: dust47_29f89e14ed723 X-Filterd-Recvd-Size: 3178 Received: from forwardcorp1p.mail.yandex.net (forwardcorp1p.mail.yandex.net [77.88.29.217]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Oct 2019 14:04:48 +0000 (UTC) Received: from mxbackcorp1o.mail.yandex.net (mxbackcorp1o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::301]) by forwardcorp1p.mail.yandex.net (Yandex) with ESMTP id 93D7C2E150F; Tue, 15 Oct 2019 17:04:45 +0300 (MSK) Received: from myt5-6212ef07a9ec.qloud-c.yandex.net (myt5-6212ef07a9ec.qloud-c.yandex.net [2a02:6b8:c12:3b2d:0:640:6212:ef07]) by mxbackcorp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id TQ8yEn6Bxb-4iOilYj0; Tue, 15 Oct 2019 17:04:45 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1571148285; bh=gapCxVyFjCKK96iTj5+/HTSHg4pVE+p4wO6AeL1O5js=; h=In-Reply-To:Message-ID:From:Date:References:To:Subject:Cc; b=iexJ4OXOHRyfvZOijhnDLG/OTy9p46fATNnCRuDS3uURs4zONzQOCug4kegm8PrUp r7YEtJsOfu0s8iXkRLCF4KwchV8t6Db1ylKADx0+jrNc/0CO6Pt0LvfyXyw82hKy5R vhqiRKrwvDQqEd2HUE6UbUXWLI2/HLIwQLMBxmbQ= Authentication-Results: mxbackcorp1o.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Received: from unknown (unknown [2a02:6b8:b080:7005::1:13]) by myt5-6212ef07a9ec.qloud-c.yandex.net (nwsmtp/Yandex) with ESMTPSA id KzKUEhJ4eP-4iGWHmeE; Tue, 15 Oct 2019 17:04:44 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) Subject: Re: [PATCH] mm/memcontrol: update lruvec counters in mem_cgroup_move_account To: Johannes Weiner Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Michal Hocko , Vladimir Davydov References: <157112699975.7360.1062614888388489788.stgit@buzz> <20191015135348.GA139269@cmpxchg.org> From: Konstantin Khlebnikov Message-ID: <89171a94-8b6f-e949-0078-10fa8fd26dfc@yandex-team.ru> Date: Tue, 15 Oct 2019 17:04:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191015135348.GA139269@cmpxchg.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15/10/2019 16.53, Johannes Weiner wrote: > On Tue, Oct 15, 2019 at 11:09:59AM +0300, Konstantin Khlebnikov wrote: >> Mapped, dirty and writeback pages are also counted in per-lruvec stats. >> These counters needs update when page is moved between cgroups. >> >> Fixes: 00f3ca2c2d66 ("mm: memcontrol: per-lruvec stats infrastructure") >> Signed-off-by: Konstantin Khlebnikov > > Acked-by: Johannes Weiner > > Please mention in the changelog that currently is nobody *consuming* > the lruvec versions of these counters and that there is no > user-visible effect. Thanks > Maybe just kill all these per-lruvec counters? I see only one user which have no alternative data source: WORKINGSET_ACTIVATE. This will save some memory: 32 * sizeof(long) * nr_nodes * nr_cpus bytes