Re: [akpm-mm:mm-new 398/411] mm/huge_memory.c:3069 __split_huge_pmd_locked() error: uninitialized symbol 'write'.

[Balbir Singh <balbirs@nvidia.com>]

On 9/10/25 21:52, Dan Carpenter wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> head:   3a0afa6640282ff559b6f4ff432cffc3ecc2bc77
> commit: 825d533acfd9573bd1b99f08a80c42fa41fbf07d [398/411] mm/huge_memory: implement device-private THP splitting
> config: i386-randconfig-141-20250910 (https://download.01.org/0day-ci/archive/20250910/202509101756.jkC29gja-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202509101756.jkC29gja-lkp@intel.com/
> 
> smatch warnings:
> mm/huge_memory.c:3069 __split_huge_pmd_locked() error: uninitialized symbol 'write'.
> mm/huge_memory.c:3078 __split_huge_pmd_locked() error: uninitialized symbol 'young'.
> 
> vim +/write +3069 mm/huge_memory.c
> 

If the entry is not present, it is a migration or device private entry, so write is
set, I understand that smatch is complaining about it falling through the paths.

If freeze is true for a device private migration entry, young needs to be initialized
to false.

Andrew I can send out a patch to fix it or I can wait to gather more feedback
and do a v6?

Balbir