From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78511CDE025 for ; Thu, 26 Sep 2024 16:46:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D07E66B0098; Thu, 26 Sep 2024 12:46:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C922D6B009A; Thu, 26 Sep 2024 12:46:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABCD36B009B; Thu, 26 Sep 2024 12:46:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8927D6B0098 for ; Thu, 26 Sep 2024 12:46:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4488080A17 for ; Thu, 26 Sep 2024 16:46:34 +0000 (UTC) X-FDA: 82607467908.16.091DB7A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id CB83814000F for ; Thu, 26 Sep 2024 16:46:31 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Yv0rJhBv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LgK8GjnV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Yv0rJhBv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LgK8GjnV; dmarc=none; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727369155; a=rsa-sha256; cv=none; b=zWY8uiwiRdbxRgsMav6Ipl5ZXCHoBPWmP48tqgos/WMJHw0gfoIlZJK3oB3iozhp71wIWX rdR0QpdpVJnj/0RiDoLbsODvmxpwoNUHSIFCX2ewzTtR6t5TPb2OYQu1BNKSarm11Rwaln P0cc4rIhr66BqGuKKlknzMNld0kjcnk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Yv0rJhBv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LgK8GjnV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Yv0rJhBv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LgK8GjnV; dmarc=none; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727369155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eeWxuVw+9XMQEFB4aKvVmtomRTVLBWsCumwBObdT84E=; b=zozGyJxi5mLDssqK6ezOr6407xso+XdyIyzr5pv3FbAzVpDOdxUSXG/qFZkEx+wN8PJs3d FNyT0Tu1CpJ6nbvenWnYDLzPXnHaPvYEJsxInuqBKQuXdOnIY5G7tSwnKOauUpuDR2ivPc EYBtnOvqgrHZgbii3ylUwg0osyBaz8o= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1DB4C1F8A6; Thu, 26 Sep 2024 16:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727369190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eeWxuVw+9XMQEFB4aKvVmtomRTVLBWsCumwBObdT84E=; b=Yv0rJhBv8em5ooCSe4hJagjaRpwRlWUGJJHHhFBZQLDxtk5zOXjSSzXLkRVz4S6a1y5sBu flXYf4c71dddnzINYl9aWhMeqPXYrx5dVSYnE+8hOyOIuQY+mqB1nWmKTSetAO7yGnP+xv l2m2Q03s8McMnWGHi/c9byQbCQLIcBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727369190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eeWxuVw+9XMQEFB4aKvVmtomRTVLBWsCumwBObdT84E=; b=LgK8GjnVRD7MovW4xQCnnewBSIH8VSkKagJgCKC77NBmFRdaAGr5QU90UNIu0VmDk4cX4f rZzoVHUMyyGnyMBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727369190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eeWxuVw+9XMQEFB4aKvVmtomRTVLBWsCumwBObdT84E=; b=Yv0rJhBv8em5ooCSe4hJagjaRpwRlWUGJJHHhFBZQLDxtk5zOXjSSzXLkRVz4S6a1y5sBu flXYf4c71dddnzINYl9aWhMeqPXYrx5dVSYnE+8hOyOIuQY+mqB1nWmKTSetAO7yGnP+xv l2m2Q03s8McMnWGHi/c9byQbCQLIcBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727369190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eeWxuVw+9XMQEFB4aKvVmtomRTVLBWsCumwBObdT84E=; b=LgK8GjnVRD7MovW4xQCnnewBSIH8VSkKagJgCKC77NBmFRdaAGr5QU90UNIu0VmDk4cX4f rZzoVHUMyyGnyMBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F2D6713318; Thu, 26 Sep 2024 16:46:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AjTrOuWP9WZVIQAAD6G6ig (envelope-from ); Thu, 26 Sep 2024 16:46:29 +0000 Message-ID: <88ed491f-4ae4-4cfc-9be2-dda3de56813c@suse.cz> Date: Thu, 26 Sep 2024 18:46:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] slab updates for 6.11 Content-Language: en-US To: Uladzislau Rezki Cc: Linus Torvalds , David Rientjes , Christoph Lameter , Andrew Morton , "linux-mm@kvack.org" , LKML , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christian Brauner , RCU , Shakeel Butt References: <8d6c5d10-5750-4472-858c-eadc105453be@suse.cz> <0295538a-4b79-42bf-b0e1-5a905749de1e@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: CB83814000F X-Rspamd-Server: rspam01 X-Stat-Signature: d6mpwna5pu5coaonh4hpqdksf17rxisi X-HE-Tag: 1727369191-271184 X-HE-Meta: U2FsdGVkX18A9Wddxbvj50VMq/HW8dRERZGn/i9qBquxbwEm7udKbiBL5VVhDQDKHzG8XdX5pCJYM2uvyKfGDEbSCjSflCwbbc6WoLWOPedKIKAyKl+EHHKfL8NPVgsr+FX4ekFZuobBIuhbP77KOSSSUiX24duQHLE5ypA3ydlJFn5ffTx9lUl/w4o05ulmIHvM2mMwM88JZx7SNx2X7PbMwXp6S5Waj6S2a/oOkUGCIzV8FNk11F2So/POiBWTjKq9AuC2nSBOA6p4jUcImRseOZo/pZqLyOBuIyUhHMnailwZz444V9bLvo4cEXFEdyV5v+nPZOhOyTbUiQyrNWdqZXPovYi8MK9wYWA8Ep99+v30XKZhF73Gb6UXiTbvJ7l1COqz28QpXVwIc2oNSl/XH0Wd7G8/mSGQjRPCrasxipSFQL/64b9Wpep9E3nYp7vfjxOMcSFxS9Y+RCo1yPiS+BFyNpWPIr/RgVd2TcjXk314FqisY46fDqj1m/py6AbbVpDQSKm3SR+EYkFkOrVgwy6ArrDZDxOpur2r/TU0fGqr0LSNmyqAU1Es8wVsSfFxownJQXBbsr5vVvAEbMbDszzHooGMUIpF5vqgMm2eTlh5Xa7q4R2GTZnAmot3WqgmoEBa1UBIuWPhRAwGmtv9UprvnKbhF1/L7oXk+7cIWtRu1Q1SIe1ENInB9KI+cFU+z4H7+NZxJFXwNMTWKvVAVNlluaQjxQsLjhQ4jTreTqnGgQPHGvIftDM6WebHTcYhqw4sqjolLwMzd4tmave+6u7yQkN1xhGXs2us8GCbKggF1izN17yccQbKNthBI04FS8lXe4yEaHpSg7iVxL2YL52Z5wN07HINpdvq77nthT8bu+JBVYOsgwFhk/8zDa5VZAo47FQlqvZrts8v+cFzNyN1LGFhJhAXhd6/3MF0j9mIbim2s0HGQbYY7Limv0RDuDFHZZoR/QlbCsq +/lJb1hr EXyQhLNBDF3HuZhw86L3NTa8DgwW7gsm7bBlvAcWipMz7gYmXWBCm+K1R4shO2WU+KRwMEmz04RY+O7o6PIFFp6EHZs/qogaCffiM09AtJgIQar7Rr3kUBV3a0qR8TKXowtfQh/ighH4J6PCPWzJdeAJnPVfDmpmf+28iD1+JEM8II8Llz1Wtmy64wjebM8rBy3zz0DLF9gs8HuJcp4tFP8I9PLdsY7lrwF8yS1sySZTxaUNhrstG5CFO47TZlHK5cr1WA92fmRVDHPpP7D+ECVrsD89jx91UO2GYZ2FePfSbaqtkh38MgOEWnX/qR/5FFbP59cs3p6keCpHYay1grE8pqocUuj5M/vTFPbvqJiqOR3+W/OqIwWmeBwAFAdreNbwqUjFejJp4abQErzAzNjgIdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/26/24 18:40, Uladzislau Rezki wrote: > On Thu, Sep 26, 2024 at 06:35:27PM +0200, Vlastimil Babka wrote: >> On 9/18/24 16:40, Uladzislau Rezki wrote: >> >> >> > Thank you for valuable feedback! Indeed it is hard to follow, even >> > though it works correctly. >> > I will add the comment and also break the loop on first queuing as you >> > suggested! >> > >> > It does not make sense to loop further because following iterations >> > are never successful >> > thus never overwrite "queued" variable(it never reaches the >> > queue_rcu_work() call). >> > >> > >> > bool queued = false; >> > ... >> > for (i = 0; i < KFREE_N_BATCHES; i++) { >> > if (need_offload_krc(krcp)) { >> > queued = queue_rcu_work(system_wq, &krwp->rcu_work); >> > ... >> > return queued; >> > >> > >> > if we queued, "if(need_offload_krc())" condition is never true anymore. >> > >> > Below refactoring makes it clear. I will send the patch to address it. >> >> Looks good, AFAICT. Can you send the full patch then? Thanks. >> > I will do so. We can send it from RCU-side for rcX, this merge window or > you can do it. > > What is the best for you? Guess I could do via slab tree since the original commit went there too. Thanks > -- > Uladzislau Rezki