From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E85C282D1 for ; Thu, 6 Mar 2025 09:34:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9341280004; Thu, 6 Mar 2025 04:34:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E41E7280001; Thu, 6 Mar 2025 04:34:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBC82280004; Thu, 6 Mar 2025 04:34:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AABA3280001 for ; Thu, 6 Mar 2025 04:34:26 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E7A8216132A for ; Thu, 6 Mar 2025 09:34:27 +0000 (UTC) X-FDA: 83190615774.27.D6EB725 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 5DD2E140010 for ; Thu, 6 Mar 2025 09:34:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UhJm7f5e; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741253665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZqCkyjz1OlMe+qw/kRDJYRT1lbnf8jOcemKypLfKPiM=; b=h7lUUYyKz1S+pJJ8F5TAAOrbbcJJ4+SMCovTuK5kylh5zVcJB+rrIbeIM7awJcd0R21Dbe 73n/ctQ40szvHPOKOAhkGF6GAA3NxndyvjYouu2ywe3ipK3AM5IQSegHIQ8edxNA2nKXxk d7VfClHkajdKVs6Fe9+w2jDPt9WU/94= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UhJm7f5e; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741253665; a=rsa-sha256; cv=none; b=QCq4jBOtA/UmiFHCqrAg6oZX7eVGZnTJ2+xS0k8ZQz6b/e4V9uS39lzH22C7byHc81FFzu litQpRBcqthiiH0UNmUSlKPNblqG85R2VzqxMq1jNab89JV6T25wvlZLFmL8W6mWB3XAGc 80P0sK/W1KT7XwsXnAXwelzvOmamT14= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741253664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZqCkyjz1OlMe+qw/kRDJYRT1lbnf8jOcemKypLfKPiM=; b=UhJm7f5etwQwKavv5uyicG4D0HIzICNnuZ3DDGjSRnw30m4iMWCjCisADxUcznT0PG8IJ8 t2yzp13tJRyiPpO7/Tm1rK6bOi7vyijFM+bG3ZhFDMkAJ5mlavFLtrATogVWq8NrB16DI6 KkjsmCJwyjhrZ3AGQINgR3kGYZg7AEQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-G46ubXjLPcOtSwri3-AEdw-1; Thu, 06 Mar 2025 04:34:23 -0500 X-MC-Unique: G46ubXjLPcOtSwri3-AEdw-1 X-Mimecast-MFC-AGG-ID: G46ubXjLPcOtSwri3-AEdw_1741253662 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39123912ff0so196456f8f.2 for ; Thu, 06 Mar 2025 01:34:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741253662; x=1741858462; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZqCkyjz1OlMe+qw/kRDJYRT1lbnf8jOcemKypLfKPiM=; b=ExXzLApE++r49+IQpWaaOwkh38KRTiWyHMrJ7EIXNnUlTifUdwBPut55GMR3mjmySJ oo1D88ZWO1MRg5gdlPFlvZFCA8ZD+97Tz9oIqsIlAigTqSPNROm05dh1Zg5BSqzACrIb akIEfO4ZBsKIgRIvqe8GH6GAUFnJZ9Xb6VlPMulAZy2WnzHc+f/rSVFVgc2LeFXd5bPF y/msIfWOIM+kPq1+yK2ayULqjCjZ450wMIgKpGO3HbS882zFXeO3CrWkcYEpZK18qIIN HbNAXLcqAWiAmZmY/kVNVtM4fwAOg9PhOLAL8MOiqSQEUglqK1oFLQ7REbULYZiy13fe 6bOA== X-Forwarded-Encrypted: i=1; AJvYcCVAoG1Fx87RzyEQjhKfmieUYbumt5ml+bmx9R4WKdNhTQ96ZwOZ4cz+2dPX38dF9yt+xCuWbVXcEg==@kvack.org X-Gm-Message-State: AOJu0YwHnBB1R42uq3nzESYna2qEKXjEC5/awe0HfR791cPAzaoeZQGQ 6KIZWAvBtqqA00TaD6Nu+dAuXz6fOecVMD7FQH/GCgzF7oPVCpNrqdMTFnL/F3+j8fDtlK+hMbj 7D2PL1mBR+ifi8h/63Omv9v+vCEIq+PW6K+ZzXTUT+xt+igWi X-Gm-Gg: ASbGncsmAj/aI5sbP/OGjyzwIj9CWbaM7C4B5jqPbKEs6HFPgHCubE+9Y3ZtSzQ044n dYAHI+LeuoycIkfHrgrwLTDe4qzs0zuU1WFPr9SSj8GaE+qUokD4kNeWwtuxXTcR9MWnyc8LgPN YpIKNMSNwxhrTLwlskb+68lY+isbtA/UGxruGxJW9/YElF00veuUES6futYE1UiCcFNku+42SMC FkhE/TmASdu14Rwurl7RgGuNrzjt3oqlyyzssT3/IAYRLwR7RGIv4KDdu5x/GfU4e3lF8DgCE8M RS3t9exUecb1pVP7OOF/EO7GhxfRVjrv8Ncm0cuHA08COf6amNteiwVRcI1Tx+6y1sZTX15E33P VvYFhgfT6sBjNoxV86exMRYSAwuo8EicDULWraIsc4LU= X-Received: by 2002:a5d:59ac:0:b0:391:ba6:c066 with SMTP id ffacd0b85a97d-3911f7a9568mr6605742f8f.35.1741253662373; Thu, 06 Mar 2025 01:34:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEdssV16m28QlGvjts6KPm6IS/YZ9DRQCSJFu22wgj2GXjDRoqtu57e6vr6hvQlvK6nb8u+Q== X-Received: by 2002:a5d:59ac:0:b0:391:ba6:c066 with SMTP id ffacd0b85a97d-3911f7a9568mr6605709f8f.35.1741253661996; Thu, 06 Mar 2025 01:34:21 -0800 (PST) Received: from ?IPV6:2003:cb:c74d:4400:2f98:9b35:6822:ce54? (p200300cbc74d44002f989b356822ce54.dip0.t-ipconnect.de. [2003:cb:c74d:4400:2f98:9b35:6822:ce54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bdd8dbb4csm14143855e9.23.2025.03.06.01.34.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 01:34:21 -0800 (PST) Message-ID: <88d8d030-c37d-433f-82f7-aed4f3a0fe4a@redhat.com> Date: Thu, 6 Mar 2025 10:34:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/10] selftests/mm: Report errno when things fail in gup_longterm To: Brendan Jackman , Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-1-958e3b6f0203@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250228-mm-selftests-v3-1-958e3b6f0203@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wumpMUe2b6hM4LVoa8lXNWbKdy9DslUHFOFHT1zM20Y_1741253662 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 5z5nobkzwoex8mmwq7g814t4aywkkoey X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5DD2E140010 X-Rspam-User: X-HE-Tag: 1741253665-751973 X-HE-Meta: U2FsdGVkX1/7nGdFjdDgoNEko7WHzngKt1eF8UVw9XZ/WsSTYgnA5v+UylEoIf30oEalC1NuXz/IcBBnnSagbLExTowQOsC5tH9apFUDrdM+o00FYLAI7nt9nXmjjib4kY2L17bRXoX2VBTFSHR5g896TB9cptfaj3ARkFn/wLaGsCD3DnRicgK0EcnZDlW8N6Zq0y8gfA/4dRoLgvx8lr6IWRzJhYDeLfQizigvjHY/1T4X6ZorrNBqdKf6t2O9xVIf5l6XGf13YktdfgnMxBVLJvwU84DrxSBoEVrvkaLl+h9DjmMrt5MScf+6U4I9KazUEedzkBYiQSD6NMPf5N/htYphtOrNFu8gJaR0Y9Z3mX9tQs1RunbqA9TSVIKVByammWViaf0eNQeqgv1XTNrrnydTFMgzHuxCOgBTHBGEQsQhC97p74pNc1hem+jEPE/JkSh+r3UguTLYJQ2Wjt1UVFdaHb8LU4peRQxiDI8U4G4j2U9KesE95VhTmlGrmHvubkSB8gDaPET03ISzN/5kv81LszlXF2P+GCsXBc7uobE+KGDP6OrFgp57Aalwoh2upalrZh8uBeYVOJoArYR4WwXMh1qBJ9eix8aPvEJGPsezGzkK3ZuXL6oQ5pKev+3lxEXAE2LV8ZD3oldV3u0ahvkvtt7hv1cbcI4+Nla8woMhP93VlpP9gdeAi+h6PQsHTULEMk6G8jYMcnj3x5K9dhICVpt0hvgxwjKo4N4exWsItTYnkDY7EOMWUqBCY6TA+iNP+6Wn4oH2EZsvCvmIKUk05k/Xh0mJ4Srmd7WkGMP833zPjFYWu676xQq8tZtzY0i/cPHnwKrn81ycO5bqFvGC911MW4shABL1C93PzQR1sRFmCN/kV1mK4oYY9jpZCbOUPzB0WI4EI8WlHfPZU85dK62sEfi6ES6EkiDo4KSuuDrAHtuEk6enktv7K5mbww/zpiIPAeAMPqb 3wEK87UX P4Zl3He8RR5QVhznEiMzjBtht11iynCUDKAQ0zCLuc73ic9IHduvEnUork15tbn6h0ydvLIwyrg472Y1a5WjisUmjxk9B8/rBZqTshSiTehr0OMlhhmawzumvpUq5W9mOTCy9TDcY6JlfSVwygsjPOqkHxpCJhwDKY2kVEg8Y+g6UC7AAwwbA+CXF+NHTfWH04a1k+w+YAzSv858OSoFGhNAmVnQuc6MrX2yVS/iv75x9KB44G7MTKqk2yK7Bx2virUPq1QrtwQ6Xya8bsdgPJDDES+mhZfxssNj77HN+8MDqmqhj523dwSo5Wa34lD7lFQVNgKimwXUiRrr1fZEm+HSQp2ynCbhfj27fs4feI8YlCAW8PUgVcwycv6FA4G5KEfOYeYtnjG6biUl8mRsyg4RPk1eFyTGvXm964MQ5tCjSSj6QETtVhgEvSizjwViiEovr X-Bogosity: Ham, tests=bogofilter, spamicity=0.100112, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > /* > * TODO: if the kernel ever supports long-term R/W pinning on > @@ -202,7 +204,8 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) > /* Skip on errors, as we might just lack kernel support. */ > ret = io_uring_queue_init(1, &ring, 0); > if (ret < 0) { > - ksft_test_result_skip("io_uring_queue_init() failed\n"); > + ksft_test_result_skip("io_uring_queue_init() failed (%s)\n", > + strerror(errno)); This function is documented to return -errno. I'm not sure if errno is guaranteed to be left unmodified (not clearly documented in the man page). So you might just want to use strerror(-ret) here. Same applies to the other io_uring functions. -- Cheers, David / dhildenb