From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D059CC001B0 for ; Tue, 15 Aug 2023 16:41:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFE7594001F; Tue, 15 Aug 2023 12:41:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAEB98D0001; Tue, 15 Aug 2023 12:41:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4FAA94001F; Tue, 15 Aug 2023 12:41:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B77E48D0001 for ; Tue, 15 Aug 2023 12:41:03 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 81C69B253F for ; Tue, 15 Aug 2023 16:41:03 +0000 (UTC) X-FDA: 81126903606.24.4DB8382 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 36D35100023 for ; Tue, 15 Aug 2023 16:41:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I+lr7IsD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692117661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TPjGUIOwNAgmU1eVNVpchmSMQTA9SU2ipzoUuHgNVM4=; b=LTn1WuuuPWmXyoy1MsWUQYXpFX8ou1otbLIbvBGT4eVPvyJwUt7wbapAjAKnrCwYlhqGRr 7Qf5BSGerU2VtPIKnOE9znEhaalRUchczpjVEL79NK41w2nhaJyfH44zMbrCQ+kkbM7mFe eUsLicryNZHkxY6Pe9KQLUjY9FOmC1s= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I+lr7IsD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692117661; a=rsa-sha256; cv=none; b=uAQ2KLq9m9HF+14/0Q5LgggIxmgF8od4A+K81Ob1wtlz7wiD51+f7DuGY7SGcy5Uf/Tdzr dAPjk/+IM0N/lZMnw5bYrTB8TFBCo/pGiwHeTbFlfYTF/aAIygpEcuAEbGBjtSvhtE4oDA d17XafctKosMUyEcBjySM8orgp9/Ju4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692117660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TPjGUIOwNAgmU1eVNVpchmSMQTA9SU2ipzoUuHgNVM4=; b=I+lr7IsD+6sB2MMMbYB57Ro50fTwaI9sXbEZ0yWmYFXPHo8w35pd8fipochSEBZ98XEehr p3nE1N9+j5K6miTR/VMqAuwiEmZpOclEhCw4AazNabExY9Ln80e6Uz1EMYDhdLwI+JxiBg Hh7wTwK1o8dh3M7FzLxIygG9jFPw2iQ= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-HkwrLPRRMHavL6fC0S54EA-1; Tue, 15 Aug 2023 12:40:59 -0400 X-MC-Unique: HkwrLPRRMHavL6fC0S54EA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fe4aaa6dacso5480829e87.2 for ; Tue, 15 Aug 2023 09:40:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692117657; x=1692722457; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TPjGUIOwNAgmU1eVNVpchmSMQTA9SU2ipzoUuHgNVM4=; b=Kxp36vUJ3pohkOQHN2CUOA7vvyKd1IysJTLhsBeuSdZdZyy2dUT0RQUuzpvHnh7Ipf veb+d330qckphukyL9dID0LMsLHVv0RR+Iqod47tXquYpyaFEUCTHVZMHdReU3mzfNW2 bn9lcJb1b8ZQ3KAXJ4lw2cosuEcvWEf3cylGn66WRpMEeao5gTs3PQtXdHWxfBBz/9uQ ouvRcd132febgoq6EDcJJoE5CN5m7qbIU83kkbgdvbmYVqP714btlm3GWaT7Byxtkaee vVGe0O78VQcuq55jeKDn9wgm7Le6J1ZLg1t1jjSDBV3NEusQBK8IJh4zFYHv1Svr0tTH jfZQ== X-Gm-Message-State: AOJu0YwH6Ux6BVxrS5WNhG0s8ceSpRZx+hYOFtCHovcX2MpSxhlpMGz3 Ah/BnvoZfIDsEij0KFK/Z8FpZw93xJJxrMu9pTdOvbbgTkhKxpfCNTek3WOoc5x/aXr7E9iTSig 7XtmGGTIZRGU= X-Received: by 2002:a05:6512:2210:b0:4fb:7666:3bbf with SMTP id h16-20020a056512221000b004fb76663bbfmr10746868lfu.26.1692117657536; Tue, 15 Aug 2023 09:40:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRCeuXlTNoB/q8src6Mv9NrqQMBZJ6GPbyli6kjcay7y78IutQUBxlHuzs+g9davK92xRDFw== X-Received: by 2002:a05:6512:2210:b0:4fb:7666:3bbf with SMTP id h16-20020a056512221000b004fb76663bbfmr10746855lfu.26.1692117657134; Tue, 15 Aug 2023 09:40:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:3100:c642:ba83:8c37:b0e? (p200300cbc7013100c642ba838c370b0e.dip0.t-ipconnect.de. [2003:cb:c701:3100:c642:ba83:8c37:b0e]) by smtp.gmail.com with ESMTPSA id x1-20020a05600c21c100b003fe1e3937aesm18243115wmj.20.2023.08.15.09.40.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 09:40:56 -0700 (PDT) Message-ID: <88bdc3d2-56e4-4c09-77fe-74fb4c116893@redhat.com> Date: Tue, 15 Aug 2023 18:40:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Matthew Wilcox Cc: Andrew Morton , Jens Axboe , io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-8-willy@infradead.org> <7c1bb01d-620c-ca97-c4a2-2bb7c126c687@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 7/9] mm: Add deferred_list page flag In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 36D35100023 X-Stat-Signature: 1fhwtqef6j98wx34cw1156onarwdkduh X-HE-Tag: 1692117661-910457 X-HE-Meta: U2FsdGVkX1+y3lWIvh/nLk+F5jDMVZyHv2Ux4tzrbarumTUME3hvitXK8AWVkT/0W4PWjrd+Y9hFqoMEbHY9PSkHELE5Eckg53UWrJ7N6mQ2cVSjGfoej6eMGE5KUgcLI7BPwYao+l4LJP0WkiQHG3CORSSPIqm5I0tlVpfpYlTwpzq7vUhaGTjstKSxLiSdQ45Wz/N5cLBIFkzqqP5Ak5Xf/nBz4hcxo1a6j20nFo28Myb0/yMHKxzYD2uK58Gt10gZ7FN0NltyKMxzYx6xHjyF9PeXRScXOucSjS9bv9MJlFuSuUUG35XWZSCSkbt1le7KNtsPRwotbmBdXkL6Y8c2rt0hOodyuSN1V0d/gK0qxmPiVwLkX8/1OqVyInOJUj8T5fbYetCV6H/urz7fFOXqNKkWmyM1L9oxSXp6dPRyU+/3wUiMmq393yiqfn0r1IRMwGISwy/L1Mf0rfxW1AcTck+IDf1GJ3AqO9YXaEjfRge+Okr4upTffaFC15rt5v/zQf61x2G2lB/WGJDLR2a0VkIJHwPKjtfVku0VUuBWfhNORezniwb0pewJPp47r8ZxKGNr9eYHw8V/0BHeoVUc7jRg+F4jpdzwvy8SvSRw8pCSW2xOvRZedu4SytbpIc9auh+ohBPz/8iQjmKyMzx/p90PWDbbNz3p0m8K/IGzohF+x1FSasMESSZbBkz3rqb9U8o9eyPpsouWOyYxGbdyfUnHPNdQJLXohB49U+P3WvV6BApQD0bAvTnkjZcn7IZv4SwxQW80CLaNm43WoAp939CVw26EogZabyXLv42vYmcsFUlKwkZCX2qTE70pHZzR8ZanhBeeFPyh3nT4V5F8LJAmz6L+urMIi9D2g2k7f2JyVLoV17K90g5+pegv52qCHfuL+erSgZ77VlQUSfz3vsHKbQM1B5FSmLXtlCt2DloomtQfZmaLAb6/l8C9gmZ4svyPe7WwAUP6vHT XSxhi6by VbidJ13+45hclqS8UQSSH2rd/VXquld3GTvEjPZbnVmbYGeU5DoDLFPQyVamtOzrjuItPE80Na49jIFbdzCRZPNkdUtGcPQ0+AergWCXPfUczt+bfzelMA+NgzvY2HSYMamB5k7sRko/5r0z3LFkyXeyfOlt23UdXZ4w3HDIYsQLZE73yj+lJr0dF+hOoPD/G7dadAJwKKneJ/JKu5V+ZFVvK8in+EkkKhDPz5l7e45irNaH90HVefBX0K2LUqcY2w2q0LZQTiDkvXHbCM0C4tmGNIDqyeFRHzbyXs9Sqn684gyIXBYuIjZb00vauSaMvoKoQnvY3hNEr7cIbR7lw0Ec4hkyWe/Kp/YD2DQ3G/RPmPva6/Q/S1oLK56Gw1rg4sMu7yOD9yeAkB5OM2FSg9tszOIkTZuUZq4F3o2359yDnL3bGJWnA8n0ouSFrcqfnrYu9H+Tw6Vy+dgV+nwbA5WB1rP+eFWKLACz2qwZpTEDkUSU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.08.23 17:32, Matthew Wilcox wrote: > On Tue, Aug 15, 2023 at 09:54:36AM +0200, David Hildenbrand wrote: >> On 15.08.23 05:26, Matthew Wilcox (Oracle) wrote: >>> Stored in the first tail page's flags, this flag replaces the destructor. >>> That removes the last of the destructors, so remove all references to >>> folio_dtor and compound_dtor. >>> >>> Signed-off-by: Matthew Wilcox (Oracle) >>> --- >> >> [...] >> >>> + /* Has a deferred list (may be empty). First tail page. */ >>> + PG_deferred_list = PG_reclaim, >>> + >> >> If PG_deferred_list implies thp (and replaces the thp dtor), should we >> rather name this PG_thp or something along those lines? > > We're trying to use 'thp' to mean 'a folio which is pmd mappable', > so I'd rather not call it that. There is no conclusion on that. And I am not sure if inventing new terminology will help anybody (both, users and developers). Just call the old thing "PMD-sized THP". After all, the deferred split queue is just an implementation detail, and it happens to live in tailpage 2, no? Once we would end up initializing something else in prep_transhuge_page(), it would turn out pretty confusing if that is called folio_remove_deferred() ... In the end, I don't care as long as it doesn't add confusion; this did. We most probably won't reach a conclusion here and that shouldn't block this patch set. So at least prep_transhuge_page() should not be renamed to folio_remove_deferred() imho ... -- Cheers, David / dhildenb