Re: [PATCH v2 04/11] mm: Make page_mapped_in_vma conditional on CONFIG_MEMORY_FAILURE

[Jane Chu <jane.chu@oracle.com>]

On 4/8/2024 12:42 PM, Matthew Wilcox (Oracle) wrote:

> This function is only currently used by the memory-failure code, so
> we can omit it if we're not compiling in the memory-failure code.
>
> Suggested-by: Miaohe Lin <linmiaohe@huawei.com>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   mm/page_vma_mapped.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c
> index 48bfc17934cd..6e06267fc220 100644
> --- a/mm/page_vma_mapped.c
> +++ b/mm/page_vma_mapped.c
> @@ -314,6 +314,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
>   	return false;
>   }
>   
> +#ifdef CONFIG_MEMORY_FAILURE
>   /**
>    * page_mapped_in_vma - check whether a page is really mapped in a VMA
>    * @page: the page to test
> @@ -344,3 +345,4 @@ int page_mapped_in_vma(struct page *page, struct vm_area_struct *vma)
>   out:
>   	return pvmw.address;
>   }
> +#endif

Should below be put in the CONFIG_MEMORY_FAILURE bracket as well ?

include/linux/rmap.h: int page_mapped_in_vma(struct page *page, struct 
vm_area_struct *vma);

with that,

Reviewed-by: Jane Chu <jane.chu@oracle.com>

thanks,

-jane