From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 155EDE7719A for ; Fri, 10 Jan 2025 02:30:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F2A26B0095; Thu, 9 Jan 2025 21:30:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A11A6B009B; Thu, 9 Jan 2025 21:30:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5699D6B009C; Thu, 9 Jan 2025 21:30:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F1AB66B0095 for ; Thu, 9 Jan 2025 21:30:03 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AD23A1402AC for ; Fri, 10 Jan 2025 02:30:03 +0000 (UTC) X-FDA: 82989962286.04.9860328 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf15.hostedemail.com (Postfix) with ESMTP id 99863A0005 for ; Fri, 10 Jan 2025 02:30:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736476202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DeejJ2eIEqhfY9gxLFhmeWFy71cU35dtB5nS6i2AdnE=; b=50dHiJs5vuL2NqIM7L6+p+nkZHFvHz7pBmp5B1EBYq3LIFTXvHZCOGXCijVmpRcjRoxX0+ cqN9dod+1BTKrNLqGy2Ty9LPE+V/apXYSvhzqBekIFkUmGH+9cacHNOnLyMw4oTI2q+x93 rRFyVbkaqsRZvaPp/HK+W/uV7zZA590= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736476202; a=rsa-sha256; cv=none; b=NtGAU9uMcSeVpKeqDn4tZPLKyjVwE5/WEuYmRXqdqhEMSTHF7501k/FzaWF7YLgHB05qZK X951wySZbXsiSIKspOaz9VsoR7pCVnyf6bZ4/ofu0N2I1JBPMCGQYc2ycCiDFX5Mf2EkIQ W8vH0APa5lcz7VtK3B1ldGXOIrV+UvQ= Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4YTlsc22mSz11SGK; Fri, 10 Jan 2025 10:27:00 +0800 (CST) Received: from kwepemg200013.china.huawei.com (unknown [7.202.181.64]) by mail.maildlp.com (Postfix) with ESMTPS id D5946140380; Fri, 10 Jan 2025 10:29:56 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by kwepemg200013.china.huawei.com (7.202.181.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 10 Jan 2025 10:29:55 +0800 Subject: Re: [PATCH] mm: khugepaged: fix call hpage_collapse_scan_file() for anonymous vma To: Matthew Wilcox References: <20250109070059.369257-1-liushixin2@huawei.com> CC: Andrew Morton , Chengming Zhou , Kefeng Wang , Nanyong Sun , Muchun Song , Qi Zheng , Johannes Weiner , Yang Shi , , From: Liu Shixin Message-ID: <88b0740c-d038-0f4e-2a4b-792cb5b6cd8c@huawei.com> Date: Fri, 10 Jan 2025 10:29:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemg200013.china.huawei.com (7.202.181.64) X-Rspamd-Queue-Id: 99863A0005 X-Rspamd-Server: rspam12 X-Stat-Signature: epnuppfibemhmsginr1s5xjturxc4mq7 X-Rspam-User: X-HE-Tag: 1736476200-493442 X-HE-Meta: U2FsdGVkX1/W0uJEmYbbU/fLT2tuT3MXxtGIWClLPpo0OjhaHVLZeRTtFm8CBIKbaw8hc7F7es1udZler2D7PcA7oPv4UnZxGQA1Q+dvR4tYFCpSyKxelEf+l6fqdze8I231Pw7cVVyG/XSMOV6cynJgyjchNwTZCxdyyA2yuQqqyN4uOhnKZcgzrXdaPuy8nup2l+J4IodfZyxi9v1eF8Tnv96FFC2kufRLFGzeOOD7ufGti5j4hBTmEu4CQ42rUC0Ey9PSSXqARcWMsOj0OkAiLdFmQTWqS32GIkmtWWU/JvxUfRr16Nq2ynxtTIE9q5yxyaDwVlwostqBWPSgdXcSLeVzEtiKA+/ncKBdQ8vwPKen8Qt3gcurZ5li95J4D9Llhnm+Ap14xYhvWnlo7JgNPV2dPyNXxI4y/RrcZ3/uxbhY9ixPOjfUrdz1re0cQbYbTH9Z5BMORmAWjX5f00mlcYrksTLZ7K4tIjOwIyxnM5KnvK2JtWeAP7LB/NPOVjlwZnDWseJ+W5mDMJRQhgI7Am3U/KOuUXdVtuCB39Y9a4DlCN4QrcGKOwNIOakk5X37CNsYaDVZW3cq6uoKaMbWrpOJK8Gp+Mu7rNJTD7paLplSDYXeXEwd1w9HaHMW9f3mt8/SQCl/UeY+o2gQOnonrBnm1Z2KjkNUBHsZgbxUWAbaY3SAR5Nsm7Rr1OWL8gbuUK8EOAtok37PYk1VpCprpS6PYxqTGO7kfirhfrPYBQq8gPjWarGq0qYN3cDk6SH+/QngTFa5ikccxl1KCgYwBvH6pHn0rgrDJyE3L3SfElbuiOAODktCCWGmU2E3HFvuDu30hqKZmuxrUcjDMY+avx7ny/YDohVTeRoADVaWMY6YahR1mAO8tJ9tJa1kJsT9+3hhtwzBoZb7bnGU+Ovw+AT6GUGD4ocuJvnb0yrify4apZKFNvuvdjCXnk+tBPhBzL5cFUu0CeoeXWP nSRq3i3G 1ZfTc8OXbJ4glttpZX/Lz6HHtlydnVe73W+4w9Enb0Ehn0y1Q6Ntx3kbPtjMYSdG/3ftZGe6r9vXTaQX6VJlUFvOlVKsrIN5jVzDbcAm1iMDz2s98YioOJwy14a7dqA465AEh20n6lc77J9Zd4Pld/iy1E7/j53c7aFwRFDh3EvWAL5CCqYzVbvW6tQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/9 21:40, Matthew Wilcox wrote: > On Thu, Jan 09, 2025 at 03:00:59PM +0800, Liu Shixin wrote: >> Add vma_is_anonymous() check to make such vma be processed by >> hpage_collapse_scan_pmd(). > Wouldn't it be better to replace the vm_file check with > vma_is_anonymous()? ie: > >> - if (IS_ENABLED(CONFIG_SHMEM) && vma->vm_file) { >> + if (IS_ENABLED(CONFIG_SHMEM) && vma->vm_file && >> + !vma_is_anonymous(vma)) { > + if (IS_ENABLED(CONFIG_SHMEM) && > + !vma_is_anonymous(vma)) { > > > . > Thanks, replace is better. Yang Shi suggest me to set vm_file to NULL when mmap /dev/zero as private. It seems only /dev/zero is special which has vm_file but no vm_ops. This way may solve more hidden similar problems, so I prefer it now.