From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Matthew Wilcox <willy@infradead.org>, <gourry.memverge@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-mm@kvack.org>, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 4/5] fs/proc/page: use a folio in stable_page_flags()
Date: Fri, 3 Nov 2023 21:07:46 +0800 [thread overview]
Message-ID: <88a40128-e55a-4dde-b664-99ff3ead175b@huawei.com> (raw)
In-Reply-To: <ZUTnf/hnbPqI9HSB@casper.infradead.org>
On 2023/11/3 20:28, Matthew Wilcox wrote:
> On Fri, Nov 03, 2023 at 03:29:05PM +0800, Kefeng Wang wrote:
>> Replace ten compound_head() calls with one page_folio().
>
> This is going to conflict with Gregory Price's work:
>
> https://lore.kernel.org/linux-mm/ZUCD1dsbrFjdZgVv@memverge.com/
>
> Perhaps the two of you can collaborate on a patch series?
Will check this patch.
>
>> u |= kpf_copy_bit(k, KPF_SLAB, PG_slab);
>> - if (PageTail(page) && PageSlab(page))
>> + if (PageTail(page) && folio_test_slab(folio))
>> u |= 1 << KPF_SLAB;
>
> This doesn't make sense ...
>
Yes, after commit dcb351cd095a ("page-flags: define behavior SL*B-
related flags on compound pages"), the slab could not be a tail,
I will drop this line.
next prev parent reply other threads:[~2023-11-03 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 7:29 [PATCH 0/5] mm: remove page idle and young wrapper Kefeng Wang
2023-11-03 7:29 ` [PATCH 1/5] mm: huge_memory: use more folio api in __split_huge_page_tail() Kefeng Wang
2023-11-03 7:29 ` [PATCH 2/5] mm: task_mmu: use a folio in smaps_account() Kefeng Wang
2023-11-03 7:29 ` [PATCH 3/5] mm: task_mmu: use a folio in clear_refs_pte_range() Kefeng Wang
2023-11-03 7:29 ` [PATCH 4/5] fs/proc/page: use a folio in stable_page_flags() Kefeng Wang
2023-11-03 12:28 ` Matthew Wilcox
2023-11-03 13:07 ` Kefeng Wang [this message]
2023-11-03 7:29 ` [PATCH 5/5] page_idle: kill page idle and young wrapper Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88a40128-e55a-4dde-b664-99ff3ead175b@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gourry.memverge@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox