From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD3DC27C79 for ; Thu, 20 Jun 2024 13:37:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C85A06B0315; Thu, 20 Jun 2024 09:37:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C37676B0319; Thu, 20 Jun 2024 09:37:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A88916B0317; Thu, 20 Jun 2024 09:37:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 82E246B0310 for ; Thu, 20 Jun 2024 09:37:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CE77A140784 for ; Thu, 20 Jun 2024 13:37:35 +0000 (UTC) X-FDA: 82251369270.01.C4C6CCF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 67F72A0016 for ; Thu, 20 Jun 2024 13:37:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Z+bhet7d; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2UowojBi; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="KHi2K/Hw"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="okghvk9/"; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718890641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7/dZYJ+1Lge/9/4wcAamGput2L/7q8of+jfZhVhNGtg=; b=aOawCiuK5tMoKexdzOivb291bTB33xqkAW0w0pySKY3KH4LHVOzu7OKSEWEqloGqiXufFb TSM1oFoC4J7M77zU75pJeQJ6JK5cDO6bNiWHV+cB3hNYTJlYUW872/4NQtMSCrGqar/ale /6y3TNkOcJcxrCncswaz4jiYE6x9hz4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Z+bhet7d; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2UowojBi; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="KHi2K/Hw"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="okghvk9/"; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718890641; a=rsa-sha256; cv=none; b=W5ZwlPyszhhfOFvcJpcAFRHR6gRAPeQRUHop4CXNZQvIIK3QG/yDkccEVCfqYdQmZQH75Q r+3hDRqmI3hyaRxNHH7MTAtXP/SNtg/LEGHppBiNAWTiwSzyXT1tsymz3uSkhDV49RsKDD 3N1bv3i3kqSue9Byhxmm5dUTWQdE7lE= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ECF3A1F897; Thu, 20 Jun 2024 13:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718890652; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7/dZYJ+1Lge/9/4wcAamGput2L/7q8of+jfZhVhNGtg=; b=Z+bhet7dUGuoODASGrQK/8WhkevEbsnFCRswwXCXobZ6IEuS7VvPyt/DciJ0DKV87dIv64 Zb4zg3Etczm8oVw2SON094Nj222dTCs05OYUJPik675B0c56VfPOdIsIUYjAAHVFcFgcjH 42eo7mDnAOMt0FtWIgAxu0nQNlmKOKM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718890652; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7/dZYJ+1Lge/9/4wcAamGput2L/7q8of+jfZhVhNGtg=; b=2UowojBi/mbBZeEztYI8adC02OhhomPtfRcYQc3Y2mM9R0NJBja9fxeAJKk3C+KHR1c6bb eTQAWdpxmB1er5Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718890651; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7/dZYJ+1Lge/9/4wcAamGput2L/7q8of+jfZhVhNGtg=; b=KHi2K/HwLyhVVU1/IPVlf/1eU6A9kxUfZgva0eDBd/HdIFnuTl7eh1QzytxPtSAFrW7DMS pgelng+YXBTvLWm3rOswuPMKWdFc/mX5VM8AbvcCIFZrL5cPEFKaKpCpsJh7E3l+m9/SG0 B7AEQCxE1jWQi+SzxjxKAUxQ/sbTzgU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718890651; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7/dZYJ+1Lge/9/4wcAamGput2L/7q8of+jfZhVhNGtg=; b=okghvk9/FZ63kXxp4tbXYKrLGMOhKhnHf6VJ69MVKS8II0Z2Kd4eMNgbGAkQHy12RBHiIG hxGja0dv+gHHEJDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6065C13AC1; Thu, 20 Jun 2024 13:37:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8qqJFpswdGbFTQAAD6G6ig (envelope-from ); Thu, 20 Jun 2024 13:37:31 +0000 Message-ID: <88954479-01a3-4bbe-8558-1a71b11503f8@suse.cz> Date: Thu, 20 Jun 2024 15:37:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/6] mm/slab: Plumb kmem_buckets into __do_kmalloc_node() Content-Language: en-US From: Vlastimil Babka To: Kees Cook Cc: "GONG, Ruiqi" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org References: <20240619192131.do.115-kees@kernel.org> <20240619193357.1333772-2-kees@kernel.org> <7f122473-3d36-401d-8df4-02d981949f00@suse.cz> Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <7f122473-3d36-401d-8df4-02d981949f00@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 67F72A0016 X-Stat-Signature: qd8gfdmuia3sxaw8utogqw4ho738ox3r X-Rspam-User: X-HE-Tag: 1718890653-701075 X-HE-Meta: U2FsdGVkX1/UwJeolh3eJ0Mn6gWqnATkSMjHizjvKIqXCsBBSnrs6Q0PDQ1DbH83gnHjiZz5PX6NHB8IJhkoHHmfGdZnOCVanrttHUuLKkKwKkv2A2qKofAdk3grRG6gb6khaWl7Mw4gaLdOBlhYKIxYxCXoXhRaVpFBYiAfa1z5lVe2hopwOjb4N7QmH7X+02Xlvm7MPudgfaSdK1zTaaY5H+hA+TJa2A7K18OAmbt7fScsx1itLv+JJR+dS2rLFjgRpLa8BbWI9y0rP1unqHV5e26YXz1cCBF9Bbo9RySYt0VropsfG4Oz7k+JFhVwvq4SJD63LDLdvHdtr+JdSrrzKWLBfNTU5zF5zFYXnTEaqNhsQlzqGEqiFLYIEDQxXul3+3+/7yCGEtZrbegf+RtYInF+UjJD1+Koiw5uoTplGdfcUB/xP3Vwr5usTw53ZG4DSeATKi6cK/pwerLfPfLs7A710tTHmJtAObZtOnynLF/2TJXsf9Qp39RLAEGM8RlDVAyt1E/5GxE5oc4mgW/jnbH6xFJe89rhVgA7Gz0B9Hsm5UIc6ihfPqFMXawgIfiJP4LoSnN2fAvwPRmPd+wie35+rahNgpiQkJ9ydI3qLfHTsu7dpqF7WHHTDL5l6yuQveCyXHP6vk1BZBJOWzK5tK8hD/n7OxCGkFSL37vZwPo5up9ejmh6cO3mzBzQ4KjyvY8M4o7++AULDybxoLv3rKLf4/ZxIJHJqXn7AjZ+q+X2zznd8OgDx3Bmss9Y1B2Arn2AYze3NhUEL+NOmBKHDhWjLvxWfcJWrsi+CvEw/EdIBS8H8VMLt9SpOsnRzVHeBpGp/dpgWRAOgYXx7Of566+bYLLsd23bnwABW/96q6abaL318SkqXho5t1R6s0fB93x/rrsiA9mRuYj0ZV4sPqNoFuqlos/QRa21rOvhf4eKjSqsAMt0gvIRi9NktwRkmqWifDar6zSrei7 Iinn62MZ D5MqnhBfRGztPA1HuEe8TPTrJAjsMf3s26EXSHY2WsbdnjJMS64w/sdPxmTbeAjaYTm7RoS3A2ZFOKLQO3yxfK4r8FkS+OSVafgnztDmj07bRSor2vWhEiN+4cIlWfF458gkD9uAkdZLSix4hqgofbIi7lDamOW3ODvSFpF1fF6qkS/LF4upDIh5jChxuiqx0hr0z3MFa6MMci1GOt2+EycW0inn3Yd9nax7kGXfCoqmQoznjerbRcDg6uKTDde2zrKQdaY/CuC7yhUTi0ylixNLgpues0O1YJHMqBNeWvenjrHk+kdshU3sxWqXqBsbcKrYvgMqdZBDECr7MTloq0ORnqexI1y19fUo2yVnv/w+f9+nS7nAOeV48Dd++FVoRE12x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/24 3:08 PM, Vlastimil Babka wrote: > On 6/19/24 9:33 PM, Kees Cook wrote: > I was wondering why I don't see the buckets in slabinfo and turns out it was > SLAB_MERGE_DEFAULT. It would probably make sense for SLAB_MERGE_DEFAULT to > depends on !SLAB_BUCKETS now as the merging defeats the purpose, wdyt? Hm I might have been just blind, can see them there now. Anyway it probably doesn't make much sense to have SLAB_BUCKETS and/or RANDOM_KMALLOC_CACHES together with SLAB_MERGE_DEFAULT?