From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A73C02180 for ; Mon, 13 Jan 2025 18:53:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19AED6B00A0; Mon, 13 Jan 2025 13:53:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14B766B00A1; Mon, 13 Jan 2025 13:53:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 013316B00A3; Mon, 13 Jan 2025 13:53:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D65AA6B00A0 for ; Mon, 13 Jan 2025 13:53:37 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 900CAA0224 for ; Mon, 13 Jan 2025 18:53:37 +0000 (UTC) X-FDA: 83003327274.17.C8576C9 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf12.hostedemail.com (Postfix) with ESMTP id 8F4AF4000B for ; Mon, 13 Jan 2025 18:53:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UgnOGL22; spf=pass (imf12.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736794415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VHwy506ywMnWLFewHx9NlRl+DZeju55iSaEizXgDMzc=; b=WJonD3gRqTSzjL1+thMk8cY7+V52az12nxFKG3EzWCbEtnOZX4yBzcvJL9prpBc72f/PBi AZrjJcQ2PkkbNn7vU/CgqTY5iWc5hUbqx7F5/DuDGA6dZQ7OiHYyxynrENihmdiCUPFeiq 7pPKnz+ZlZb3q+Mkn3ToPfIvN8UxBRI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736794415; a=rsa-sha256; cv=none; b=uWpCFSPeURMF9IYdsc7I+ta98aecBAV8RnxDADdJ6Jk3MTZknjB3HwwoLOED5fb6+325IX TSuKGUP6PXmfnMq7oJn19va9RB7vOe4QJWXUBSoFbzkZUI6/ewBZTJWRHYVWyNNoq/w6Qs GGSdGkCvPmwJfkwr8CH9cLBTcIPrdG0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UgnOGL22; spf=pass (imf12.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d9f06f8cf2so950723a12.3 for ; Mon, 13 Jan 2025 10:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736794414; x=1737399214; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VHwy506ywMnWLFewHx9NlRl+DZeju55iSaEizXgDMzc=; b=UgnOGL22gmZiEUAV+gLbHckRdgho0tYQgUHh8lpPb1o02+/BKopLvVMpxaGHz497Sb 5NU/4JIHVpVEMK3h8e1UOn6AZm+7CTB21t7+4yvuiQpOFDVEvTdyNARfkgxz5BDdq759 2IIC1D71rakKZmGXZQZ/M3a8oy6Lh5OCh+g47Bq5a862YsfjaOLwr+YFxSQ9uSmrcCv6 DQVWn8r9Z7cZzqUCJJyB0wtc+Qona5uBZ1COstEuDKxeL7BniCvoUJ9Zuy2P+PGnokoV hVOcIO6z74/x+FP22rZTu2SEKQ8b15+Z4F/3TZZV8tiBfN907VZk+mP0HS8KAFOpqp8p IK7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736794414; x=1737399214; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VHwy506ywMnWLFewHx9NlRl+DZeju55iSaEizXgDMzc=; b=oQ+asUz4iv5Krr8x6RwxSAAIZj6Z6xaWmu97tgNfD4O1obp8NNSIOi/sbuteFL4XOV a895FvOaCjherB1VgCglZ7QPozDV74R2HMprZ/8EZ188H73fUH+VWp11g8zD+XiPJ43P VKOoeC+34+K0vTmeYWod/YmZLU5r8zeuUfz6etZ4VsP0AgekdZ07w6QR5x0XWUMEOLDE DFCldxGRSfP3bwM9isn97WOG7+qiGpxYr6qPxAphIf7qRE5nnaEJLvWOgn3B1bHAqfwH uhRHM8oNpgZXFk8BGOnMxVdDYjoLuyXlnsff/RcMJIKrZog2Rek1RXl0Bqb4/SoHcA4L fBvQ== X-Forwarded-Encrypted: i=1; AJvYcCVj9qwhheHjLxc7Q8cEvMqSu1FhQ4Z92auQjGMvkizSaJkr+aBZJsN4u2eTBHzz4nSVzlh5u2ZUDA==@kvack.org X-Gm-Message-State: AOJu0Yyx88i7uu6P85xjNJIhXFVZ69xwOw+5RmZpensYPCCJCDKfGDkz b3xT4mqHg7Cq+t37aoDvBl6DDQrYIKpEnF2uOrNSWOXM6ewWSf+C X-Gm-Gg: ASbGnct6r8Ar813TquNUaufPLc6Fydc341250ANZbojLSuK0FNAmBf+X0Ekr1O71+oL Ryrf9xicfGGe6Jqg8tDVioHH0RA8rdKcUziuo8SjfXrdprV0H+akfULDACx+G2jC+0hK4n/kSnL RNsnvGWoDBZFkEXmzp/X2nLwO7EwL9Mf7pdzWiRtOP5xeGfE9DhOte4meF04xLMGRKyhmu3VPkV 2k3j3mEXL+0IlOae18DjNsCfciFwuaDRJqMpD7BEIJJ/nisLgchQZOp5ocl8rUl4K3GS84jMa/R tZ5fgpzzrhPKSqvHJT/8b2QAsH5Z X-Google-Smtp-Source: AGHT+IFmLTSmhZiZC2D7ryiDKtNfefi43ec+L4XFmdgc83SneV6j0ppP8sm+x0Clrb9Won8aQh0UkA== X-Received: by 2002:a05:6402:5244:b0:5d0:8197:7ab3 with SMTP id 4fb4d7f45d1cf-5d972dfb878mr20621516a12.3.1736794413796; Mon, 13 Jan 2025 10:53:33 -0800 (PST) Received: from ?IPV6:2a03:83e0:1126:4:829:739b:3caa:6500? ([2620:10d:c092:500::6:97ef]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d9904a4d49sm5026269a12.78.2025.01.13.10.53.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 10:53:33 -0800 (PST) Message-ID: <8892b42c-3363-4fdf-ad3c-4bbd2a0a801b@gmail.com> Date: Mon, 13 Jan 2025 18:53:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/damon: increment pa_stat damon address range by folio size To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org References: <20250113184311.6572-1-sj@kernel.org> Content-Language: en-US From: Usama Arif In-Reply-To: <20250113184311.6572-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8F4AF4000B X-Stat-Signature: mj5rhu69kronpq9b7p7fbfhn944ghpdj X-Rspam-User: X-HE-Tag: 1736794415-332035 X-HE-Meta: U2FsdGVkX19WO2yCEZAJsFSWS53FLVf21hYA84+B1POxMzqdXJnsM4xQBZQYNB7d2KrRqEQeaOm4H32CE9x+lPy26rTWQTEsEo+7E1MN43wMxE2IHEvxOKkE+YsTbf2BhoZUWH/8twpri5Qe6xeYqkociIJKecgTaBlJq07F9qRRIiOQ8B3owbL0ovaddeUBM4eGDMnrWxN0ukESz8z8oQYsAlN/MpyTzt0wl7Dd9vCzZqEQK8WiDoMH9qecAKl2jcTmUWopqlD72G7Ygrr9cQ0fYM0B0QBhETIFM5CO40Q812SRRDWuOQ7gn1s3g2FMr6fJaWnrfpK3mcVEPB/AziuhbLiQguB/ZwX4o95JwtZXRIEtVx56NX/q2yAMHp7DOEll9izAEdzU3YZgkC4Q/LLmzadajSPglf1T8dY5Wkh/EFPMX84M+t4uUGe2dx7DeMi2ntodFDu9Pn93/Ndi1ylDCQOt9icHDSE9qea4tg7Y54r8B+hJbzcmUU7/5n8Ti7PdR/56dM9s3URqDjoplY++EoEqkf2tFdhm4KieQjPmNqUtZNLvBNgiQaWuMiKNB//kgKN8BNLh4IvTeAxjd2mhHiPOsKE6Dc+eoclWyYkDqE+erOin/jCQxDGBf4DBqyhWf6SbRgE4DlBq0xshbgAuunyL5P3MA0Ud4C5wG8p0hN9CE7xXQUKFm4xFW/Hb6p60/uC4H+ENeAEepDA9CNrvY8L3n0VoEeF8IfFoECBxc21uHKi89QtibUtNFQUVXQj4pou4IeZGzVD/5iVcbdqLEv8T8lAo5/FYBaosD2uMoI8G9TwVAe6nen3+BCsopK9ND6TnFZim82YFJbLcKWHqth03fRo15imnmzNwtFqO166WnvuG+VaGSBNd2cZ3GIfyImyBEOF7FX+WVg8GMLYBhAsCCLN6KNX4iVvp73owJ2YMsLo8fDj2Aa/+6LJzUy5K+pc78ly7r8ft4f4 xdBIJ3fF O7FnAHvbG9k780uQMM33Mn6T8gaLD+3K265xALnFjOYPg1q0RtUU/Hj/AGi1eLLOy3LDI1tNuPQElWeFrw5ZFWKWD8ABAJm9L4MZBjWSXazPA2OU7HBi1hhrsqMVvNTWtBRPj349taFtlzD4qvb+9uxGS/GlZE2YNGqcCI/g7mjhIG4vFw3pNv/Uk1Ldw03auPdgjWa4um18DWD6ZaCNEtJ1XisfO3/mCvXk4JoyUtTfS9oNJblffgEIL6o/Mtvs6oOpU+2G3Xi1BU+dzGgIY/i/8jiDPC3j4SMN1Pn7hZn6N+ai2ttOR2tFvSK11IthjNMXro7Lu6FohIow1MqSziHvgzmHVVbtYcLzliwoNYxgXBP8sjSNpE/MrkPClT1zZmmIGMPzyG14RKD0sCiJouxfgPYrntXYlVXGU8IrJw078ppVGZAbFIZnCwU6u/xmxsQTi3QtuHRe7plS5i+jgpnqj2Tq0C9+lUOceGJ755clGfgSW/HBnERlJ2reInAGF9ach X-Bogosity: Ham, tests=bogofilter, spamicity=0.032850, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13/01/2025 18:43, SeongJae Park wrote: > Hi Usama, > > > Let's use "mm/damon/paddr: " prefix for the patch title, to be more consistent > with others. > > On Mon, 13 Jan 2025 18:03:40 +0000 Usama Arif wrote: > >> This is to take into account for folios with size > 1 page. >> Iterating at PAGE_SIZE increment would increment sz_filter_passed >> multiple times for the same folio by folio_size, providing incorrect >> stats. > > damon_get_folio() returns NULL if the page is a tail page. Hence I think it > will not increment sz_filter_passed multiple times? ahh I didn't look at the definition of damon_get_folio! just assumed it will get the folio irrespective of if its a tail page or not. Will change the commit message. Just curious if returning NULL is what is expected by the user? I see damon_get_folio used in a bunch a places. If the user limits damos action/ damon monitoring to a specific address range, and that covers some of the tail pages, but not the head page, I guess the damos action wont be applied. > >> Hence go through the folio only once. > > I tink this is still nice to do, for more efficiency. Can you post v2 of this > patch after updating the commit message and addressing below comments? > >> >> Fixes: 6347f3385dd0 ("mm/damon/paddr: report filter-passed bytes back for DAMOS_STAT action") >> Signed-off-by: Usama Arif >> --- >> mm/damon/paddr.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c >> index 6b4397de4199..cc789a97c6f5 100644 >> --- a/mm/damon/paddr.c >> +++ b/mm/damon/paddr.c >> @@ -504,7 +504,8 @@ static unsigned long damon_pa_stat(struct damon_region *r, struct damos *s, >> if (!damon_pa_scheme_has_filter(s)) >> return 0; >> >> - for (addr = r->ar.start; addr < r->ar.end; addr += PAGE_SIZE) { >> + addr = r->ar.start; >> + while (addr < r->ar.end) { >> struct folio *folio = damon_get_folio(PHYS_PFN(addr)); >> >> if (!folio) > > In this case, the code does "continue". 'addr' is not advanced, so it will > result in an infinite loop. Let's do 'addr += PAGE_SIZE' here, to avoid that. Thanks! Will fix this in v2. > >> @@ -515,6 +516,7 @@ static unsigned long damon_pa_stat(struct damon_region *r, struct damos *s, >> else >> *sz_filter_passed += folio_size(folio); >> put_folio: >> + addr += folio_size(folio); >> folio_put(folio); >> } >> return 0; >> -- >> 2.43.5 > > > Thanks, > SJ