From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9192E6FE49 for ; Sun, 8 Sep 2024 18:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13D956B00D9; Sun, 8 Sep 2024 14:48:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ED2D6B00DA; Sun, 8 Sep 2024 14:48:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECFA46B00DB; Sun, 8 Sep 2024 14:48:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CCC5C6B00D9 for ; Sun, 8 Sep 2024 14:48:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 395A61618D7 for ; Sun, 8 Sep 2024 18:48:47 +0000 (UTC) X-FDA: 82542457494.12.7E9D483 Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) by imf03.hostedemail.com (Postfix) with ESMTP id 14C572000E for ; Sun, 8 Sep 2024 18:48:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=pIelrbMj; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="W Th6/Dm"; spf=pass (imf03.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.146 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725821274; a=rsa-sha256; cv=none; b=cuhqeEuoiNSu3bqCw4SMFrr2eMJ/sG+zmbLctubx+EzT3LbZ2/4lALA9UpCyU8N8WEKUmE MjJ4FRoRXc363/BvMvT4i/JVH3GE8ikVr4nK9Zk5wLQ47QfY949dkWP5NJpNRoKgL21ANF tJlwA7C9TguTU0Jr+yhlds7pTTUML0E= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=pIelrbMj; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="W Th6/Dm"; spf=pass (imf03.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.146 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725821274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JkD38rG6xdhn5i8WXaenEJLcpRWMj44PoaCjb/hfV80=; b=8OwOCzk7X2gvfh14NrvEnj1NMTG0IqItiUKm0p9qzys2E8KqVZaRZHZ3ho7HC777g9bn6R iqkr9a12K24piCsvg3y84hYW2sf5+KVCIkSvUAvaQCnCGyLBdGbSM8s68Pl173DijL70lM 1VSa79IghHctCMe16aXZmBOVcmgK6us= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 49AAF13801AA; Sun, 8 Sep 2024 14:48:44 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Sun, 08 Sep 2024 14:48:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725821324; x=1725907724; bh=JkD38rG6xdhn5i8WXaenEJLcpRWMj44PoaCjb/hfV80=; b= pIelrbMjzXjQ8Ew5W3xoLJu9A3jIsP2Oag3u1DOyAtDF1mZypFx7NT/+QlyxQN3V YxqnFHci0MgsFyLMmF9Krglm61h60GF4srEKy+HQgGMTOMYKbjdaG5CuTdNEcSxL hy2/vEXVaV5RSxycEYsCNWT/VFG8+f+Qg0qFwO2VX+ezBBvm78Llo6HeV8fDpEP1 C/ct0ps3Hy/20VFpEl8Me1SwQG2aFrbtIHUHJ9xrqeVKE2dK5T0tckVEaewxkUgt QlhqSa9sC7BDCU0KJBd5zAIOvq2RtF3/0DTcrN3V2CDASmJxKmhCZ8I354vE4+Xm DvtDeCt84FIHjpb2oDQw9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725821324; x= 1725907724; bh=JkD38rG6xdhn5i8WXaenEJLcpRWMj44PoaCjb/hfV80=; b=W Th6/Dmaz4u1MUSFoaoOfiwdXeUB08JQfEM0hLCPrVZ/a3zeAAyTOmGjosgRs/Uo4 5Udzf9x48lGNmOrN8eRZlAl5CQGdtUzKfulrF82PkTtxfZcF1/wszW1TKuMYcBHP lQnrcnuXUJpZv9i9C9TP3ur0m3MLWwBea3WhfFRnExn9v6I9eee0IGF2Oyo7ZdNm zx5etOmTYb57giFL33yt6PPifMZtjKH7dvANLZAqNZtAbTy5jYcRCNZnPBjAV5eJ OU94CAQdThroc/6wk2PgCkLbAgbTAboSEHY05pn4gqVLW2WfQhzY+f+LJLzYzHL9 dcfZsEKvM7YMGyITv3/RQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeihedgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthhqredtredt jeenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpedvhfdvkeeuudevfffftefgvdevfedvleehvddv geejvdefhedtgeegveehfeeljeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedv tddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepsghpsegrlhhivghnkedruggvpd hrtghpthhtohepvhhinhgtvghniihordhfrhgrshgtihhnohesrghrmhdrtghomhdprhgt phhtthhopegthhhrihhsthhophhhvgdrlhgvrhhohiestghsghhrohhuphdrvghupdhrtg hpthhtohepmhgrthhhihgvuhdruggvshhnohihvghrshesvghffhhitghiohhsrdgtohhm pdhrtghpthhtohepmhhpvgesvghllhgvrhhmrghnrdhiugdrrghupdhrtghpthhtohepnh hpihhgghhinhesghhmrghilhdrtghomhdprhgtphhtthhopehrohhsthgvughtsehgohho ughmihhsrdhorhhgpdhrtghpthhtoheplhhuthhosehkvghrnhgvlhdrohhrghdprhgtph htthhopehmhhhirhgrmhgrtheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id C28F8222006F; Sun, 8 Sep 2024 14:48:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Sun, 08 Sep 2024 20:48:06 +0000 From: "Arnd Bergmann" To: "Christophe Leroy" , "Vincenzo Frascino" , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: "Andy Lutomirski" , "Thomas Gleixner" , "Jason A . Donenfeld" , "Michael Ellerman" , "Nicholas Piggin" , "Naveen N Rao" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Theodore Ts'o" , "Andrew Morton" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" Message-Id: <8868ef2c-6bfb-4ab7-ac5e-640e05658ee1@app.fastmail.com> In-Reply-To: References: <20240903151437.1002990-1-vincenzo.frascino@arm.com> <20240903151437.1002990-4-vincenzo.frascino@arm.com> <11527a80-7453-4624-b406-e88c5692b015@app.fastmail.com> Subject: Re: [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 1q9oxuyj6o7y8bwyoceik997n3u8ifrx X-Rspamd-Queue-Id: 14C572000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725821324-461967 X-HE-Meta: U2FsdGVkX19uS8RGuvTavwhj6qwu08PVLSqOjV6/+NvV1R99el8rclCu2tgLwB9s/ABx0dHFoHRETH69RTXMg52Fn9vNrT7XCVYFxs7TsTirSU8WVLOdtFPhmXh8Hk8e4NsIrYuNPXPZsyzh53eG8fO8LC0OUVCqTPmSOCJkHX+KTD2JwMH3guP+bw4+eimGmvwHhQ5UYMNzpOFG3mG7QZLgFNTSweyKe8ePJpKRQgpjmSM9ASU8QzssKF4e5k3jvuDTf+amjoA69yYrkP3duw3gqXy0zGJ1zPfMX6fR3NYkGfzC3DvhUqmiB+qBPsXvcsdetXf4p4CN6rR1+/zqPO84yakfAdP9Hp9ZLuYZpPuYgjkj/1Xhst9prbAG3WtAAYWjDFalb65/iJ1/0fdT7S+Ry8+/Bw7kLFwAUMdaMXMtISKvl47EjkSiYB6s9UrhRFx0Du12HfdnQdu3gTPv7pohUCkt9QuaUoG4+Hx6eRNi+oY+dsWkDwrNS8I6NNAqJogDuryLILhxZvjN4LQvd459ukQAYmbSRNUpb0i1nDc0AVZvpCzITFoLIYsSG2tNJpyIrynzgmQDUKkG4lHX6g4rd4dvOb/xXE/HwqDRuWGeWccJ+EwpRX6fpUsQD1XgpWYr07KhqFcc9GfsPywzdNBdazVetvyZELVosozkm/tIMLR+4soGrzOnZ3nJnYBP8vVWMMRLPyA8GaGw5a4eQmkHPJJwLlmIRW5h2B9vtZGRfp16p4PZjcSvbl/g0GNQ7iKjGhmLhh+rTGemg7KarvNR0e+11iUZsJ9kQTymA1mrGqwFS4B9RG5+QzVLtDW16R98RgseP789iJ7iV+rmSO0W7FQq6G4fXdxLw16FHs1RbVQZk9dSWnex9XpqvHyVWR/0B+csHHXfA33I/+tVPY7uwSsb6rcktl9X8rPAzPOG8jwBnLJMF1E4DU0In2weV44puXOmE1wgNM9zAm3 7r+FmQwC RRKFbJtUdcRKV2YDk7e46toBtjninpBO5CMhm5sgeCgnZpPaLrKjtlpv2US/pnawDlNDOCSOzYUhMxfWXqJHTxEvIvt4fshOrN11MEvYbB8vRReaxznCZMb+EVWizxI/PiNr/QqSrikDmlAz48PBOjO0FyKBPd872eAo80heYcYBqhL1BXqr1c8RFS4HX8B1bSY+n8wCdjzZUaHm8JkkvJK+Pqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 6, 2024, at 18:40, Christophe Leroy wrote: > Le 06/09/2024 =C3=A0 21:19, Arnd Bergmann a =C3=A9crit=C2=A0: >> On Fri, Sep 6, 2024, at 11:20, Vincenzo Frascino wrote: >>> Looking at the definition of PAGE_SIZE and PAGE_MASK for each archit= ecture they >>> all depend on CONFIG_PAGE_SHIFT but they are slightly different, e.g= .: >>> >>> x86: >>> #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) >>> >>> powerpc: >>> #define PAGE_SIZE (ASM_CONST(1) << PAGE_SHIFT) >>> >>> hence I left to the architecture the responsibility of redefining th= e constants >>> for the VSDO. >>=20 >> ASM_CONST() is a powerpc-specific macro that is defined the >> same way as _AC(). We could probably just replace all ASM_CONST() >> as a cleanup, but for this purpose, just remove the custom PAGE_SIZE >> and PAGE_SHIFT macros. This can be a single patch fro all >> architectures. >>=20 > > I'm not worried about _AC versus ASM_CONST, but I am by the 1UL versus= 1. > > > This can be a problem on 32 bits platforms with 64 bits phys_addr_t But that would already be a bug if anything used this, however none of them do. The only instance of an open-coded #define PAGE_SIZE (1 << PAGE_SHIFT) is from openrisc, but that is only used inside of __ASSEMBLY__, for the same effect as _AC(). Arnd