From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D96CCC02183 for ; Wed, 15 Jan 2025 16:52:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F4CB6B007B; Wed, 15 Jan 2025 11:52:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37D366B0082; Wed, 15 Jan 2025 11:52:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A907280001; Wed, 15 Jan 2025 11:52:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EA3956B007B for ; Wed, 15 Jan 2025 11:52:49 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 805F3121529 for ; Wed, 15 Jan 2025 16:52:49 +0000 (UTC) X-FDA: 83010280458.27.CC239BB Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf29.hostedemail.com (Postfix) with ESMTP id 42765120008 for ; Wed, 15 Jan 2025 16:52:47 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EnsNrTE2; spf=pass (imf29.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736959967; a=rsa-sha256; cv=none; b=TuXWPB2wjh63cGyCx7eBTyfP6OuYg+00ZrzDybtPHv0ODGCtVQUWSCyp642wISZGl1E0oG gm9zjn6/J+slnbnc7cuTAjeukxxNT6O70NDSBmeKCxsbnYBqCyeuMDK3W+uCfwxABIeD/y jvYi1CZy/ZuPpvRHPXwdtfPcbOC6pJQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EnsNrTE2; spf=pass (imf29.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736959967; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OWa1legH6BGRarIfhhVIacdJPMo2926WEjTBZMjiIcs=; b=FRs/5XrEC01/rjNrM5FpKsj+SZnJwNLr8Z25Fzt4nc3DyTzWERoTqVQS6dPYWGJW4x/x8V bP0lz+4JKY/AwLjMLBg5DiS7V9OJrEKhAXxGR2Btvr3GMr5jz/Uewj3PZezwvcVMWsXwvE DyjpKRCbMQzUCSh7D7dlRMVb7RCHqI4= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21661be2c2dso125824105ad.1 for ; Wed, 15 Jan 2025 08:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736959966; x=1737564766; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=OWa1legH6BGRarIfhhVIacdJPMo2926WEjTBZMjiIcs=; b=EnsNrTE2YNhF2jkbM8BLqbkfr7BEJ8Pb6bmkxeFn8ZqT0y8Wdh12a/tVt2JbAuW/KI GhjtitDZT64L9Edo/TY0k0YsO9YgIXRw3kIOpXjoCQlqnsTAueqVMFk5bbfoZHtKSKLy YcZfkER4tpSNTqV4MfLGzu/eROTTVdGYO+2lpDmEoiAA062tfaSJeJ0ZGiVpaU6k6ZKL yTRTGt2sFT0xKf/0ilshCSXmM/jB3zFUWhwRVlEWdornjpX6oo9W2C5t+wsnJ6kXFREL IFH92S6wvWVhSX1w2EZGCd4IR9e9LOdpMh41lA/VPb3WMm/S1+vGtySTLak1BdVqCr+y 1yGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736959966; x=1737564766; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OWa1legH6BGRarIfhhVIacdJPMo2926WEjTBZMjiIcs=; b=bcblMg68SlyDfFz78XZdSzyW5gYM1MpgjlDnZvj/vQI5Rjy0alDvZLiakKmq1ZG0Gh uG7YNPPrYz7i+L/ZWObCL/OMHv/69yUnYcmmQzWyXdIRQbuMm8SmzwnkKjJYeDkPyqZg 94tMG76xdTUvWvcEaJ3LMII2az1b7+gaFaptlshH+qQz58ITahWYa29th94FasLoYVTC oK2kCEmIL15hOrGN2OP36811vQKYDNUsKsbIyfzVirYbGz+pwpXXs/VCRDa8W/NbmqjX dS+wzkr5tyb0smqrIsGPcHL9mD6HywIm7NSGfoAxkAQllGJi7FOPc2BLNMWVlWTwr6Jp Dfgg== X-Forwarded-Encrypted: i=1; AJvYcCW3NQ0IsW6bosKWCowwAn2EmeFgsA3ivvlg76zAGBDo3iHBqt3TlwgJsZEfANRNEYqJTsa9PGLs3A==@kvack.org X-Gm-Message-State: AOJu0YwUUEL+lX/Wo4uvCk8ydocAG+4sC+5otSy1M3BgeSTh4qMGAuTX l3X1rWWuYG7GjOEw423Q5qBPVncEPgIC2tLeLHaeCZVLnhhSNvcu X-Gm-Gg: ASbGncvd85f2WQRaaNzm9wE/21pNOlBBQ2qZaPOwScBF5JdWQb372AHFoK3HzikpjbR lZoudBsmfgI5uDyxsyIyKxP6P+2zqPyJJcPkd4UHkUrhJe6XBSd9MjdYMUwIEGd66/CtgxTBRU8 f/++bLiQhOdHPKAEE28QNxcWkzYX07ZjXkxFNlFXfKlYs4YP1Cd45m2lv/oZGWLhDUuP/7vRraG Kpd90R9hG4uwbBuASSu0BKQs3phpJi0yKTqTeaLARef482CYg3hUDlQby/zVTclp/4i0uNJTwVz bPzkQFIneVIPwnApw9Zs4bZVfF4eyg== X-Google-Smtp-Source: AGHT+IG+9x/+4ny/Ei1cGAgDsLOt92iTMeyjIvt7gKL8KQQeFD52KLjoPDVmClNZM6wxsUCLoLE4zw== X-Received: by 2002:a17:903:24e:b0:216:794f:6d7d with SMTP id d9443c01a7336-21a83ffc1fcmr479062195ad.48.1736959965986; Wed, 15 Jan 2025 08:52:45 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f219302sm84817715ad.149.2025.01.15.08.52.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2025 08:52:45 -0800 (PST) Message-ID: <885e0ae3-1d2e-43c7-a32b-f29871fc6b4b@roeck-us.net> Date: Wed, 15 Jan 2025 08:52:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page-writeback: Consolidate wb_thresh bumping logic into __wb_calc_thresh To: Jan Kara Cc: Jim Zhao , akpm@linux-foundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241121100539.605818-1-jimzhao.ai@gmail.com> <64a44636-16ec-4a10-aeb6-e327b7f989c2@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 42765120008 X-Stat-Signature: ehbnux75n64rapawd757jipwencbpjin X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736959967-327235 X-HE-Meta: U2FsdGVkX1811DNlDDxeekgeA3ujiDM76wVmBZ+TN+D7Mp708qAtxjnVQWP5bvaxHD0RsvWQtFitu8o9N1J2KuKv06PSlBKLBQHA/8VGhOIgXHv4MBPV+zg4zTbauGNy8i42/bXupFl/T963ag/RmHHaHxJ2eNVFk0Au/N0C6o8NTCsPD1PmhGYggSHv1wxxAcIrvbfv1Rh6OWv75mXKSSz+jkLvaap9lxSHFKw0V5NYY6Jexs9HDjwDIYM/wQIkbvtcOzlid26C6n+JmaVZrFpyvdE1PGiyuck/hZUTO4fSa+zzniFgK5l/E3PFtAs56SIr4L6IDwUrBH+VCbPJqGB/Q+ElxxWuyMIDpwBbkbwSDWZRwr/g28ugqiL3uiotZwZv45Foyt1amNJVhswN497dX7W5qmL6Ywo/6XU3ur9UOXNik9ltE4MDVvR37plbX4OIjycziVZycSpg94vhdtGnfo191OlPgQOqhCoK1/gX2Dm+8WdDTATuJweBSc9La7IAalPWJ1Ypw5oHvp9cZ2zo2sz5S1UOM5EwZlMfzeOZCQQnNofrjpf3VTSjVUBeuf/OZ2GrulmxSCrvzKd0Z/napzrFCNqHXGbXTf+ep6VqWrhtd5YTjjwaCfD2KA6BBswSvTxVoGJJAo2SiR9KmYxgkY5Wh/TxEngUFSTnciQ2y7bpoJW7h1y1S3nPGUaFb4m12nak22R7QjpzVYh9GPTD4u2L58uMFcKjZ/7A6RzoQSLT+uUFCi4HEn4ZU4PWfUTxcZl3bl/Hg9zeZDI1BS52TaXim+zi3CG+Ar/6boOgAiRgJoh1DTIvJb5AE4s7XSooaHIJUtA9f0cvprZDAKa3UFGksvydc7fbfPftSUj4C1r0tC31VPbvGV0Rg4NR0x1X07L4AEjI8o8462zTmJYlb5GjbiehruPInCLG4fwMMuTnVeMnuOYKQHheuTxCdBzCaU2SBm5mQz0YURJ qoSksZcR 4kfuLuohgpSPLlSdJfadbb3tkthRPt1gjxx9TjuCmskPZENXc7UOdtNBE/RQiq0LA/MTUGBQMW+p/3fbEHYJrYhmo5betxr+2gdtqNjpMrfp19NjGpujxdhXH1UD4qFfcqDfeogSNf24ElY3dn8J4OW/WtXHZ1SpkvFjixnhWuyoXtAT4NL6yACXtjd2O/GqSfa0E83QLQI2bBx7NiFiWwrWclTulZpLGKptIiZmU7lXlOIA8DZMyccA6Fd/9lk96S96bVLE9YDUktIz1YtAbErJW2qo4pxl8kV+RAFmRxOkeIwkxHW/jgEElzH0VIjuojvso4o0ATKdf6tCTyS0h4uMhC9KT+Az7u98AcKaR3Tv56svAoP7pbend9kCDZnGiIw9s98lXA5PMKKHRW/xmU/AlU2QTBkLYclbOFU/CeLVCiJLo3tzEIwmhaXoysG3a3uv3Kejm//A0jRFyPBh00nEYvp3ev0EGpEpy9IelqHqR7hKjC1yMylYJpGwqQHA3nMbxI8Kaa4cIAwxIKzwE3kELm+GU6gbmpBWYb/XbtBYtInOnPXvOo+aiBavgGG3voePzVQ0BoBCAF/RTaEy5LbXxxIdFCvnVWLGLiZbhUbBR+vSYJmGzEiaDTkQgfGLKce1u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/15/25 08:28, Jan Kara wrote: > On Wed 15-01-25 17:07:36, Jan Kara wrote: >> On Tue 14-01-25 07:01:08, Guenter Roeck wrote: >>> On 1/14/25 05:19, Jan Kara wrote: >>>> On Mon 13-01-25 15:05:25, Guenter Roeck wrote: >>>>> On Thu, Nov 21, 2024 at 06:05:39PM +0800, Jim Zhao wrote: >>>>>> Address the feedback from "mm/page-writeback: raise wb_thresh to prevent >>>>>> write blocking with strictlimit"(39ac99852fca98ca44d52716d792dfaf24981f53). >>>>>> The wb_thresh bumping logic is scattered across wb_position_ratio, >>>>>> __wb_calc_thresh, and wb_update_dirty_ratelimit. For consistency, >>>>>> consolidate all wb_thresh bumping logic into __wb_calc_thresh. >>>>>> >>>>>> Reviewed-by: Jan Kara >>>>>> Signed-off-by: Jim Zhao >>>>> >>>>> This patch triggers a boot failure with one of my 'sheb' boot tests. >>>>> It is seen when trying to boot from flash (mtd). The log says >>>>> >>>>> ... >>>>> Starting network: 8139cp 0000:00:02.0 eth0: link down >>>>> udhcpc: started, v1.33.0 >>>>> EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 >>>>> udhcpc: sending discover >>>>> udhcpc: sending discover >>>>> udhcpc: sending discover >>>>> EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 >>>> >>>> Thanks for report! Uh, I have to say I'm very confused by this. It is clear >>>> than when ext2 detects the directory corruption (we fail checking directory >>>> inode 363 which is likely /etc/init.d/), the boot fails in interesting >>>> ways. What is unclear is how the commit can possibly cause ext2 directory >>>> corruption. If you didn't verify reverting the commit fixes the issue, I'd >>>> be suspecting bad bisection but that obviously isn't the case :-) >>>> >>>> Ext2 is storing directory data in the page cache so at least it uses the >>>> subsystem which the patch impacts but how writeback throttling can cause >>>> ext2 directory corruption is beyond me. BTW, do you recreate the root >>>> filesystem before each boot? How exactly? >>> >>> I use pre-built root file systems. For sheb, they are at >>> https://github.com/groeck/linux-build-test/tree/master/rootfs/sheb >> >> Thanks. So the problematic directory is /usr/share/udhcpc/ where we >> read apparently bogus metadata at the beginning of that directory. > > Ah, the metadata isn't bogus. But the entries in the directory are > apparently byte-swapped (little vs big endian). Is the machine actually > little or big endian? > sheb is big endian. I only see the problem there, not with the little endian emulation. But that uses a different root file system. As I just mentioned in the other reply, it might well be an emulation bug, but it is odd that your patch would be required to expose that. Guenter