From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81301C433EF for ; Mon, 27 Jun 2022 04:09:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F225B8E0001; Mon, 27 Jun 2022 00:09:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED0FF6B0072; Mon, 27 Jun 2022 00:09:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBFBC8E0001; Mon, 27 Jun 2022 00:09:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CA3F46B0071 for ; Mon, 27 Jun 2022 00:09:53 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9986CEDD for ; Mon, 27 Jun 2022 04:09:53 +0000 (UTC) X-FDA: 79622687466.18.7077FF1 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf06.hostedemail.com (Postfix) with ESMTP id A19B418001A for ; Mon, 27 Jun 2022 04:09:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656302992; x=1687838992; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=+MlrCsTACgQ3fdMt0MvL5i5SW0bgC6vhQ3XkFwfrHyo=; b=RjniRGLd7DFZweaw0lFa1yVXVxZ1wzwWhwgFSYn0CeAsjS8FOINzW4cm Q4DjhhUHkgME1bDKyQILn4kE6BWcOsiaIsMHWIM1Zp1H3W7zKvDKKHOaF xjlw2JntzJL1KGHQwLW3DT8KMq1EMfHbRLFWSfWEKYJ3C+V2kVou1SXBg FXA/r9l0cmahvDUw5mcL4/rOkFbBnSEwDccrxy4DL72/hZSUgvG2UvslU 5kYqsfb5AzkXwYhGT4toA6uCY763bhkrj24RknNW76Uh85t7FCARicNKr WYHZM+WRMjYLLSZr+donN4H08WWvxpVLtCVtAKqOVfEB6e+rM0J8jsv45 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10390"; a="343034821" X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="343034821" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2022 21:09:47 -0700 X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="679401157" Received: from fzaeni-mobl1.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.212.88.6]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2022 21:09:42 -0700 Message-ID: <8853a55e32d6b5f5657e521094dbf01e371516fe.camel@intel.com> Subject: Re: [PATCH v5 00/22] TDX host kernel support From: Kai Huang To: Dave Hansen , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, linux-acpi@vger.kernel.org, seanjc@google.com, pbonzini@redhat.com, len.brown@intel.com, tony.luck@intel.com, rafael.j.wysocki@intel.com, reinette.chatre@intel.com, dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com, kirill.shutemov@linux.intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, isaku.yamahata@intel.com, akpm@linux-foundation.org, thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com, rdunlap@infradead.org, Jason@zx2c4.com, juri.lelli@redhat.com, mark.rutland@arm.com, frederic@kernel.org, yuehaibing@huawei.com, dongli.zhang@oracle.com Date: Mon, 27 Jun 2022 16:09:40 +1200 In-Reply-To: <14e3d8cb-5e36-dc90-bfc8-b34a105749a3@intel.com> References: <14e3d8cb-5e36-dc90-bfc8-b34a105749a3@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656302993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0kohazZtvEg0rkujCIEiix3D9g7GFWbnlZJ/hnEb0yo=; b=F0Tk0uULnUvcp3R4npqgqiu8jcXJaJhFiXj2zv/LtkfHliGJ6zmhOqdLvimrKsbNBXD+Mg y8HvAqARIXWWrcC7wO/jDwfrhrkw4aSTBhBqG7wjZBvI3GtyBg/lUm1C5q5nH6/okBCisC LtbbrTLINDEzVhvtVjqDC1YUDfxNpZk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RjniRGLd; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf06.hostedemail.com: domain of kai.huang@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=kai.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656302993; a=rsa-sha256; cv=none; b=Fej4gwLRlb2kjGSr1/2JDjHEPsYhurY9MOF0dNobioZ1PhyKisb9yiD9fsUJxMZIUdrcLR 53/yqdQgp+1/CtlYkxyHd9E7VeCdihGhIwqgvWMs6PilBoP4IO0lpnIwvQM1BDNTEfnZvS aIcRC8efQAONDj72hucpBWVlMWtTEfQ= X-Rspamd-Queue-Id: A19B418001A Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RjniRGLd; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf06.hostedemail.com: domain of kai.huang@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=kai.huang@intel.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: dot3s1pu544oohh4dpd9j5gmyz9uw9bn X-HE-Tag: 1656302992-901497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2022-06-24 at 12:47 -0700, Dave Hansen wrote: > On 6/22/22 04:15, Kai Huang wrote: > > Please kindly help to review, and I would appreciate reviewed-by or > > acked-by tags if the patches look good to you. >=20 > Serious question: Is *ANYONE* looking at these patches other than you > and the maintainers? I first saw this code (inside Intel) in early > 2020. In that time, not a single review tag has been acquired? >=20 > $ egrep -ic 'acked-by:|reviewed-by:' kais-patches.mbox > 0 Hi Dave, There were big design changes in the history of this series (i.e. we origin= ally supported loading both the NP-SEAMLDR ACM and the TDX module during boot, a= nd we changed from initializing the module from during kernel boot to at runtime)= , but yes some other Linux/KVM TDX developers in our team have been reviewing thi= s series during the all time, at least at some extent. They just didn't give Reviewed-by or Acked-by. Especially, after we had agreed that this series in general should enable T= DX with minimal code change, Kevin helped to review this series intensively an= d helped to simplify the code to the current shape (i.e. TDMR part). He didn= 't give any of tags either (only said this series is ready for you to review), perhaps because he was _helping_ to get this series to the shape that is re= ady for you and other Intel reviewers to review. --=20 Thanks, -Kai