From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44440CE7B14 for ; Fri, 6 Sep 2024 13:45:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA7106B008A; Fri, 6 Sep 2024 09:45:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C56236B008C; Fri, 6 Sep 2024 09:45:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B202B6B0092; Fri, 6 Sep 2024 09:45:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 99E2E6B008A for ; Fri, 6 Sep 2024 09:45:49 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 24E93121808 for ; Fri, 6 Sep 2024 13:45:49 +0000 (UTC) X-FDA: 82534436418.16.E035674 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf30.hostedemail.com (Postfix) with ESMTP id 2B42780016 for ; Fri, 6 Sep 2024 13:45:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MXvM6DbV; spf=pass (imf30.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725630250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e5rkDQXOut8d6XYh86QFrj0XIhHkFOTu4z3B+AX019U=; b=KnucQCYcjWM75zMY3ilMJaucU5xFHimAqPUc6ZnxjVpf/pR9lPeiymnhNJD1PstNMTYZvT 9GnDZPA0AW8n2mVyxlkiBNuu1WIq2OsQwQQltolBk5kD42NHdWVnAXfOQbSjlu0r05G+5d By7hKPB7pefECzVVzYSnjrh4QoYOQOs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725630250; a=rsa-sha256; cv=none; b=GQx36tgFtrRxY6105kmzoddKwa0Evkz7PAMQT97vMJzANlktoc+eOidCnWaZARMNHdh5Bn bGZjVvwngNLlbTZdRtesr99Y15pkggDfdKTIA+5Wy/qSE5Bd7aHpxsRmIdRBnBYpQD3yLY oUFAP3fJUJkqUfqJ24xznlf2BtQIl4I= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MXvM6DbV; spf=pass (imf30.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-37747c1d928so1161536f8f.1 for ; Fri, 06 Sep 2024 06:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725630345; x=1726235145; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e5rkDQXOut8d6XYh86QFrj0XIhHkFOTu4z3B+AX019U=; b=MXvM6DbV9z370kgrS9XFdDiHvnnaU4pCC/MYKtM5mrV0Thr20zCd5EOzQmMIvvTnBX 8u8opmROTnEYLCafefNGWR1PL4KomOin96N3eXMKojaRX1/vakut7PhJOx1vxMvL7ge6 rwozLCFAnxRHEHJoO9giLLvKU7jvAjGALzf5SVPwT4HcxL8q23xyBVDUe7WEKvWF18Wt Yu85xMYEEpXAK3gpd5CwfWJ82tKJA633jsGnnsL5d5RSkycsodvsczZqVgfjYrnTx0FM wyRr1jVX0ip185T0vdFm9TVgX/7/Z9eC6tRsb/9I43/yDKn3hqnwR3rzoqGTX++sqSvt 1HsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725630345; x=1726235145; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e5rkDQXOut8d6XYh86QFrj0XIhHkFOTu4z3B+AX019U=; b=Mtny8fUHZ2TmM2J+KakDbl3fNbUFFXz2d7pe7HU5qr1fHoWq5NKHWUTkWj+ImINs6c MPvvReNf76slBCbgf++KF9IrJInQj2cFufIHBJtkBtEe8i37i7aoLvnhbLzOZraM5gj0 OViXoh/4MZFdvEX/H3TYupugYd5GgRTnlOhBIddqa1iQG0r6pAymUfpa7p8IM3imJ3KT jls6wONcSCIfy8FFY/peaflyCSDjbxBZxiil+BAjC7jpjk7rZzUk7uNoho0l9HZ9P+94 ng8f2qAhOM5zsppu7exB1w++3ToZ+K2ZerUS2xCeEXK2gdpRUnm4LnX5w8K5KNKd+GtD Lzkg== X-Forwarded-Encrypted: i=1; AJvYcCUJ8NQmQhg+5KJwRRHXUATb+aJjId5olc/MpWaoYsLqlaHIPtp0XbW4qSQLNLkxpKgC5KoAc8SnTw==@kvack.org X-Gm-Message-State: AOJu0YyxYBkMnFPsfKzw5g0/hWB830pzvRTfogOkBLg4YZ5eurP/+s2v 9KwMyihh6SIh2GK5aZYFeZKYP2aiu4NiUuvU+a3VWhuBqM0H4b8i X-Google-Smtp-Source: AGHT+IG/XCVL4z/7Ye9O29fA20ZSqIscT4l23i6TAu3O+kwgWrn2f2H42cvgytF57iuKqhVL+wGmkg== X-Received: by 2002:a5d:5e12:0:b0:378:89d8:8242 with SMTP id ffacd0b85a97d-37889d88432mr1349658f8f.26.1725630344889; Fri, 06 Sep 2024 06:45:44 -0700 (PDT) Received: from [192.168.42.120] ([163.114.131.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a623e3401sm277350366b.197.2024.09.06.06.45.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Sep 2024 06:45:44 -0700 (PDT) Message-ID: <8837b91c-55d8-45e6-8a98-3389464cac97@gmail.com> Date: Fri, 6 Sep 2024 14:46:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/8] block: add nowait flag for __blkdev_issue_zero_pages To: Jens Axboe , io-uring@vger.kernel.org Cc: Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig References: <292fa1c611adb064efe16ab741aad65c2128ada8.1725459175.git.asml.silence@gmail.com> <862f125c-9710-4abc-a229-5f7eb9931ed5@kernel.dk> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <862f125c-9710-4abc-a229-5f7eb9931ed5@kernel.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2B42780016 X-Stat-Signature: fy4jz13zt6mzzacymetxy9pgouzw6mac X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725630346-538628 X-HE-Meta: U2FsdGVkX1/HLHay25CPWMVV5JunnDBTm0/mV53wOBKSU8XrD33OZd1eKEVOc1+0FvmVlKurWjLIlaVQC2E0kKlOasyvTnNSX/JrjFoS2HatHBbreTv0DGsVPOXxg6XM8/ECJezpkMm2Nw+/vC/Owv8P7j+k9/BGftjT6xOHceWDVuCa7KiNNJ256zS2UcCc78s3VO9QbkrHQEUm62XfSqSk2Zt8JC+K2qflvfudyJP4gfMHUlkfjboKsOMq0IhQuaM12ZjIg7fGx3nq3kinRdhyNJVBq3sJS7IlQP6dxa0uWyjadYJFA7yWkg1Psv/cR1/3lZfWbVTM/cUfLRkQRU9E5Z90RF4Vyi8VQM7C2DgA3IWhjH94n7XI2UEQB2S70izkH14x2fBB644UeGqjxEjutvcRX9U2b9/azT7BUMYals6mu/YXdlGfjujPaQ5LPpKHy15jX2nhK5T1AAISEfseopvEsE+Sz6074rP8xWsByKZetGBqLpLCnWxtzf7VtmtFjeNAeQy9vZnidPMRScZGIEY7TSIRxOwE2cO8zk8Zc6M/rjnR0d4PKguSFHM5kjjXtE0lSCvFsPs9TSesyYy0L6FOIN8Ib6SSfo+M7hg2HQw+sg+VzYhqTr5X7GYsHPiLq8DvmL0XY6Q4KkAv61F+ka02TA5s7MQrkUCQptL4HYKYogXqnIumPDsaeH6n09XcrlVUYJxshBFzJsN37NSVUNYXQX5a51ATKH5pKH4NxDC8Ry2yfBZ/7+thzMn5wLpegsOBoMPrw/DA0UWuevS18JaoIv/s85Z3Rh/WamH50iA4jD5aoTrEwALMhZUYbWRUPt/pKdL252rsGQFxyJ12V9sa4onw7D7DgxLZbAAR9EasrvdNE+7i44qV03eJKp45aaEJFJ9LdEu2i9sq+G7TzGXFtjVp9f6f1k5rySl8DwF1WSipBUD369ul3AblQsRvp90ZKbypWLRyrDz 2IAR+I6U TmNxJKirFlQI6Tc1TzhYFY0pq2i/y1rXLXh0yS+y1i1qGaS1SAc+gf6bcYgkGab7cPCQhudm+wV6TjQJFa6AaI0UKU9sEfWvO3dyoesnapN4y8ZvNg94sU6e5Wnc8etrpNoy+dam8DikM88j80n6HNUfO+w83xIQqeRIsuTKYs/vyXG+nG7JHb3ahwhdRAhXJbZwNHYKZ8AcGK1MY3ij92fa1ux6NZ2zEs4eGBSCjtPRZdMirh2pcKbLEa3a9mWs/ha3KwEzNWiTrCOIrHmX89Zcfjbb6Qxw+PxyMa/NbpA2KExzOXPwAKE+IBKykrL0JoNwJy6brVZt9FGbOM+rjHwiYzk1P1hf6lzFIY28KADHUnBqLtXwkYm4IELi5hKrmn4jLzOQ5L/s5q/JlX/WvdbYvD3swYznJGbbS66mFyhmFiT/kLiO1x98SwXEN0zJoiAzT8x4vFkGShF8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/6/24 14:41, Jens Axboe wrote: > On 9/4/24 8:18 AM, Pavel Begunkov wrote: >> diff --git a/block/blk-lib.c b/block/blk-lib.c >> index c94c67a75f7e..a16b7c7965e8 100644 >> --- a/block/blk-lib.c >> +++ b/block/blk-lib.c >> @@ -193,20 +193,32 @@ static unsigned int __blkdev_sectors_to_bio_pages(sector_t nr_sects) >> return min(pages, (sector_t)BIO_MAX_VECS); >> } >> >> -static void __blkdev_issue_zero_pages(struct block_device *bdev, >> +int blkdev_issue_zero_pages_bio(struct block_device *bdev, >> sector_t sector, sector_t nr_sects, gfp_t gfp_mask, >> struct bio **biop, unsigned int flags) >> { >> + blk_opf_t opf = REQ_OP_WRITE; >> + >> + if (flags & BLKDEV_ZERO_PAGES_NOWAIT) { >> + sector_t max_bio_sectors = BIO_MAX_VECS << PAGE_SECTORS_SHIFT; >> + >> + if (nr_sects > max_bio_sectors) >> + return -EAGAIN; >> + opf |= REQ_NOWAIT; >> + } >> + >> while (nr_sects) { >> unsigned int nr_vecs = __blkdev_sectors_to_bio_pages(nr_sects); >> struct bio *bio; >> >> bio = bio_alloc(bdev, nr_vecs, REQ_OP_WRITE, gfp_mask); > > as per the kernel test bot, I guess this one should be using opf rather > than REQ_OP_WRITE. Right, I overlooked it. I'm going to resend the series later today. -- Pavel Begunkov