From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A2EC67861 for ; Wed, 10 Apr 2024 02:13:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18AE36B0085; Tue, 9 Apr 2024 22:13:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13AF56B0088; Tue, 9 Apr 2024 22:13:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 001F76B0089; Tue, 9 Apr 2024 22:13:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5E256B0085 for ; Tue, 9 Apr 2024 22:13:04 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8E8DC401E8 for ; Wed, 10 Apr 2024 02:13:04 +0000 (UTC) X-FDA: 81991999488.29.16C5782 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf10.hostedemail.com (Postfix) with ESMTP id 9D01BC0006 for ; Wed, 10 Apr 2024 02:13:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EdwjbqA4; spf=pass (imf10.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712715181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tfrQs+4JrCPHQuxPOBXPCCTtuoY+nVtkPvrmH/Y0bqU=; b=cfGwRvdgP4dI99HCvRBNfdq4dxfQdPvAZ6C5Bq8/9D/0E51b7VCeZ9WGZdIRzdP75hmr+f dSvt3W4T3iFqZVKeECxEKSkaLyLwCQ+mh/Ji8JTcayng0HsEAHW1wl6BqiW/PShOZcGJlg HZdbXUpvjrpaNi9IQY5Bya2uYejbEWc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712715181; a=rsa-sha256; cv=none; b=bdlbGbRVGjiSNrPAAOth7ire5/s43Aa8LN0i1jdoFxjw9mDsItZQCVoQ3+v1QeD/VS0Wfq 36lbQ+2bdyArIHCalZ8dY6nWENiOivgngxwk6jaJ4XZo/cGaBtyTDqT9sv/ZHSUQGAAkac 8ME3hX/9ryxzgZGq6jfDLEK9/KKskyw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EdwjbqA4; spf=pass (imf10.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6edc61d0ff6so104349b3a.2 for ; Tue, 09 Apr 2024 19:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712715180; x=1713319980; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tfrQs+4JrCPHQuxPOBXPCCTtuoY+nVtkPvrmH/Y0bqU=; b=EdwjbqA45dN83fwI1aXXvIxQZ+IwfRIzxefG89yRMehgAdkPQt5wG/E3UwbXVJ3GK2 oHeSMwy3a80B2ehZ2wMHiPl9030cVTW1XST/WYEk3qbCnDAHXR3FVfp6gsP+QCSZXwRW NiTB1TC9cqd6AgTlmwfUM5wn/jxekJ2kU+P+hGsTAcnPGCkRca+WG7m2NdKt9R/CJOZE m71x6/6Rl8BfzqgNcJ2He/MEVh+cwi4HEkJA48RVaivtUhl4K1e2ko+DAXCrOpxPratP pwKzZ+R8Kpxl8o+U697rbb3P5QEPoNGggGCZKBWDeoxIvfgsgbcJ1Ltble8cbxiru43w XXLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712715180; x=1713319980; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tfrQs+4JrCPHQuxPOBXPCCTtuoY+nVtkPvrmH/Y0bqU=; b=jWIJeHfPwz2g7pm19wrsd2PTYK+3yW7yIcbc2TP/LLQUUu5xsshtiUiZNE3MOTfVus LZwnGChg2XH8ySikIhDaVzzx2RGsJUqM0K+N4zn7rAr5x8fl4lV5b1Q7vhI4bW4tSL5M yOhMzUXU2PRXvUc5eUPyI2a5xZsiuMhKpglfZEFcFzJ5AxUyJs+eS48HLcWmFu0uoVF3 VwmB8Xzn2Db0cwLDioRuaaOE3OLO49VGH29LUsR5kSLis2kKcS3rWsUvFfSQvjSMkyA1 F0jH9uvuOCQZ024LaCB5UHYbz0C4YR0+Fq2/6bmvA0u2uXmcmrKBXf8vtUHTKlUsLjll M9Nw== X-Forwarded-Encrypted: i=1; AJvYcCXevCN5WfkV3s6V2u2Hgr9fXtm0qOwEKlRxdmSn/ExUSPxgvv8f6BEX2gnx906mhNxkE5zir3ykhk7ZlGq5mifj0b4= X-Gm-Message-State: AOJu0YxFFeUFABXDJeUqvYDv+MmwINNSxjJorSUUmB3k1kScxvTNLOR+ SYZRIyNS6BaqRKYTvaI3jw+6/y6qjqdOgQQ80hVuJwxV06oby6t+ X-Google-Smtp-Source: AGHT+IFouD389XE/szQrJCFNEso8tE9jSmplHrRziy+SDkM2J+XStefDaKGhx/vrhu5RS4Nw4yM38w== X-Received: by 2002:a05:6a00:1ad2:b0:6ea:dfbf:13d4 with SMTP id f18-20020a056a001ad200b006eadfbf13d4mr1545511pfv.18.1712715180364; Tue, 09 Apr 2024 19:13:00 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id le8-20020a056a004fc800b006ed2709ada6sm5199846pfb.65.2024.04.09.19.12.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 19:12:59 -0700 (PDT) Message-ID: <8836b1e2-f231-486e-9caf-757250e7a005@gmail.com> Date: Wed, 10 Apr 2024 10:12:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] mm/ksm: add ksm_get_folio To: David Hildenbrand , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Izik Eidus , Matthew Wilcox , Andrea Arcangeli , Hugh Dickins , Chris Wright References: <20240409092826.1733637-1-alexs@kernel.org> <20240409092826.1733637-2-alexs@kernel.org> <5b90db38-75fe-44fc-b4ca-55dd1b15724d@redhat.com> Content-Language: en-US From: Alex Shi In-Reply-To: <5b90db38-75fe-44fc-b4ca-55dd1b15724d@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ni36f15qycnzk5dg7hukxyhj8fb83u5d X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9D01BC0006 X-Rspam-User: X-HE-Tag: 1712715181-46264 X-HE-Meta: U2FsdGVkX18QsJIfCwOCLgXv62RTaIAcyM+FmNKj2oaRoo2xGRoACf8ar5Dbm5axYTHevsc5ugqWGBIBswpTtZGuertBX4qdk8RTINfLF4MlwyHQQ+LoR6CIlUqEqNG0TC3Rpczw9gwtEJndtOyBI7cA2P5+Hi0gDbMirnvSTmS0SBgw9AM9/biRq6Y74JvHleD0RIcG2BjAnXSlwYIzOeigy2NR692MfegD/JN/JGCYCobsixELwAdSnyZXkSVkM/gdpPv5wDMykaCkAyGGWqvhGAGN4OvSttoScCjsiFCXDHp1o/5d60viqbLGfJJlD8F7WSgNfoZ8TylwAqvm+OzPjTVdKQjpmfKdA2NMGaUjQCO4I0McPcTGziYPK4M5RJjq9ic6WgSx2sDtQhSM0IUWabcH/PH1A+cqv+kQnwaUavk4Wo6qdyDBQ7T8kIiHTcriKq9ihjpiXv4Q/33jEDJX8ER5bVSq/lrmpGa4JXjYUeAM1WUgSbFYZGz1hnI4xPLI7j2gxHMAbEtY5MTIilwx1EAoiRmnkSXJMHC/ZHYMxSgjzgcBZMIwC53UCU9tUo9F/kV4yzRLxsyPPfFzbMjmKIYwdVKG+b/YHg4+2Sjmg8Gd6Hgzwho/Icp6cEjriDNhdtqdKY1A8ngpQSJHyvcRLIe8eRD5+AiW9iYrulK3HBMzg/cx9gtI20LzNP5CLOwJnRXkusK9E7eb8zcX2q9COov4EC2t9rMIrpx8j8OGmZIWai+0ePzrzRdSkwYYpe4SmY6NIi4tsZ856TxgF9ZgfD2RBpKZ7T64rXWz2KYFYZaMZRa6W5lJvGObUPmoD3a3Vi1jDdV03R8+rhI8RODxrcC7vUsn7CmH7dlvikgmcvXouXvExoyJrn6iep1RNmZBXUuD8usprNvwjVy2GFAB/e2vcbNJmrgWoZACLruGI3zLdwtQo5aJzWZbPkssjwNQoXGs3uJjJQbTqoV XQ93aLle OGKy7V8/GJwNmfKjYdaTVIKO0ycLkqBW5PhlI8rUuczOOfskKnSyb7dN3KiMlM7Zh6Wrz1B+HOWWjpMC7dTszoRRPZvWKSYKoBCaWTvH44FkVmMn2keoFdwMQQf1xgSn3B4ZSx9/k5HmbcumwHa6QTZqTXnzPb9sjYdSytASfDtixucl4QuRV47QqmlrJ4hv0TdH8igmBBvlIyL3VFQjRpB9TKKCchjZmJZJE711Tmrr0AC2iTMaoprKQVWtrd+TjuUK2u7u0BbBLRDr0SZaI1X7ZMCozz4Rdap2NbMCmiLRkKFifiGPvs+ta3F21TjhqKhmyelgpOO+G2AdivHOlZbSc6F6IVevgAiqGulpWiJpDeTrP1b3qsbmVZ2ZzYBi25Uu7qpv2ILwDRp7A7i4Dzn4wMPl6V4L1sM3dZ4ECoF9ZZLWWvGy/GjuB5s0STb6wosf1S6BL/B3iULlCtCPHZbSPxlsL7vUj+qd5YfZCQRnpSnepJIa4QfRyC8oxwZIPJ4EQvBiJa2nisin9R9oimIY/3kU2wBNQ2zECBpzrVU98JkpXEpTVdh3BJYEhQX3Dv+MyHEl27395wJq8e1Prilnrt4U9sdRwtK3BXdQZnllMYgnFMeBd46BlAAh3puUTdrbGjDdeq4mJDmP9Y1yUv9unMPdhX/TVyvtkYqVqZLwWLNx5/BZF8UYZljnb48myg/O9axu0Ki/vYN/CQ7BHxjzvqTPYIVr8jq4QKHHsSBQtMtI43minp4YQwD5W0okQ29nm58d1zGGO4Ozgw1nrk93ghJrmBq6tZ2v9f+2ASoyE0N4xjgzq1wnUOIgKH4BlvifihCtgiv+jSI2Fn/xgRUK9c58ujY/n8GF5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/9/24 6:50 PM, David Hildenbrand wrote: > On 09.04.24 11:28, alexs@kernel.org wrote: >> From: "Alex Shi (tencent)" >> >> The ksm only contains single pages, so we could add a new func >> ksm_get_folio for get_ksm_page to use folio instead of pages to save a >> couple of compound_head calls. >> >> After all caller replaced, get_ksm_page will be removed. >> >> Signed-off-by: Alex Shi (tencent) >> To: Andrew Morton >> Cc: Izik Eidus >> Cc: Matthew Wilcox >> Cc: Andrea Arcangeli >> Cc: Hugh Dickins >> Cc: Chris Wright >> Reviewed-by: David Hildenbrand > > Note that the more common way is to have RBs ets fist. Further, I haven't really seen "To:" that often :) Hi David, Thanks a lot for notice, will change it in next version. >