From: Dinh Nguyen <dinguyen@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: hch@infradead.org, christophe.leroy@csgroup.eu,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
x86@kernel.org, openrisc@lists.librecores.org,
linux-xtensa@linux-xtensa.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-alpha@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-um@lists.infradead.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7 15/26] nios2/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT
Date: Mon, 11 Jul 2022 15:43:45 -0500 [thread overview]
Message-ID: <88328a82-7275-608e-46f2-4203df9d9fe6@kernel.org> (raw)
In-Reply-To: <20220711070600.2378316-16-anshuman.khandual@arm.com>
On 7/11/22 02:05, Anshuman Khandual wrote:
> This enables ARCH_HAS_VM_GET_PAGE_PROT on the platform and exports standard
> vm_get_page_prot() implementation via DECLARE_VM_GET_PAGE_PROT, which looks
> up a private and static protection_map[] array. Subsequently all __SXXX and
> __PXXX macros can be dropped which are no longer needed.
>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> arch/nios2/Kconfig | 1 +
> arch/nios2/include/asm/pgtable.h | 16 ----------------
> arch/nios2/mm/init.c | 20 ++++++++++++++++++++
> 3 files changed, 21 insertions(+), 16 deletions(-)
>
> diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
> index 4167f1eb4cd8..e0459dffd218 100644
> --- a/arch/nios2/Kconfig
> +++ b/arch/nios2/Kconfig
> @@ -6,6 +6,7 @@ config NIOS2
> select ARCH_HAS_SYNC_DMA_FOR_CPU
> select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_HAS_DMA_SET_UNCACHED
> + select ARCH_HAS_VM_GET_PAGE_PROT
> select ARCH_NO_SWAP
> select COMMON_CLK
> select TIMER_OF
> diff --git a/arch/nios2/include/asm/pgtable.h b/arch/nios2/include/asm/pgtable.h
> index 262d0609268c..470516d4555e 100644
> --- a/arch/nios2/include/asm/pgtable.h
> +++ b/arch/nios2/include/asm/pgtable.h
> @@ -40,24 +40,8 @@ struct mm_struct;
> */
>
> /* Remove W bit on private pages for COW support */
> -#define __P000 MKP(0, 0, 0)
> -#define __P001 MKP(0, 0, 1)
> -#define __P010 MKP(0, 0, 0) /* COW */
> -#define __P011 MKP(0, 0, 1) /* COW */
> -#define __P100 MKP(1, 0, 0)
> -#define __P101 MKP(1, 0, 1)
> -#define __P110 MKP(1, 0, 0) /* COW */
> -#define __P111 MKP(1, 0, 1) /* COW */
>
> /* Shared pages can have exact HW mapping */
> -#define __S000 MKP(0, 0, 0)
> -#define __S001 MKP(0, 0, 1)
> -#define __S010 MKP(0, 1, 0)
> -#define __S011 MKP(0, 1, 1)
> -#define __S100 MKP(1, 0, 0)
> -#define __S101 MKP(1, 0, 1)
> -#define __S110 MKP(1, 1, 0)
> -#define __S111 MKP(1, 1, 1)
>
> /* Used all over the kernel */
> #define PAGE_KERNEL __pgprot(_PAGE_PRESENT | _PAGE_CACHED | _PAGE_READ | \
> diff --git a/arch/nios2/mm/init.c b/arch/nios2/mm/init.c
> index 613fcaa5988a..ae24687d12ad 100644
> --- a/arch/nios2/mm/init.c
> +++ b/arch/nios2/mm/init.c
> @@ -124,3 +124,23 @@ const char *arch_vma_name(struct vm_area_struct *vma)
> {
> return (vma->vm_start == KUSER_BASE) ? "[kuser]" : NULL;
> }
> +
> +static const pgprot_t protection_map[16] = {
> + [VM_NONE] = MKP(0, 0, 0),
> + [VM_READ] = MKP(0, 0, 1),
> + [VM_WRITE] = MKP(0, 0, 0),
> + [VM_WRITE | VM_READ] = MKP(0, 0, 1),
> + [VM_EXEC] = MKP(1, 0, 0),
> + [VM_EXEC | VM_READ] = MKP(1, 0, 1),
> + [VM_EXEC | VM_WRITE] = MKP(1, 0, 0),
> + [VM_EXEC | VM_WRITE | VM_READ] = MKP(1, 0, 1),
> + [VM_SHARED] = MKP(0, 0, 0),
> + [VM_SHARED | VM_READ] = MKP(0, 0, 1),
> + [VM_SHARED | VM_WRITE] = MKP(0, 1, 0),
> + [VM_SHARED | VM_WRITE | VM_READ] = MKP(0, 1, 1),
> + [VM_SHARED | VM_EXEC] = MKP(1, 0, 0),
> + [VM_SHARED | VM_EXEC | VM_READ] = MKP(1, 0, 1),
> + [VM_SHARED | VM_EXEC | VM_WRITE] = MKP(1, 1, 0),
> + [VM_SHARED | VM_EXEC | VM_WRITE | VM_READ] = MKP(1, 1, 1)
> +};
> +DECLARE_VM_GET_PAGE_PROT
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
next prev parent reply other threads:[~2022-07-11 20:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 7:05 [PATCH V7 00/26] mm/mmap: Drop __SXXX/__PXXX macros from across platforms Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 01/26] mm/mmap: Build protect protection_map[] with __P000 Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 02/26] mm/mmap: Define DECLARE_VM_GET_PAGE_PROT Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 03/26] powerpc/mm: Move protection_map[] inside the platform Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 04/26] sparc/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 05/26] arm64/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 06/26] x86/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 07/26] mm/mmap: Build protect protection_map[] with ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 08/26] microblaze/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 09/26] loongarch/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 10/26] openrisc/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 11/26] xtensa/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 12/26] hexagon/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 13/26] parisc/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 14/26] alpha/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 15/26] nios2/mm: " Anshuman Khandual
2022-07-11 20:43 ` Dinh Nguyen [this message]
2022-07-11 7:05 ` [PATCH V7 16/26] riscv/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 17/26] csky/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 18/26] s390/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 19/26] ia64/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 20/26] mips/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 21/26] m68k/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 22/26] arc/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 23/26] arm/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 24/26] um/mm: " Anshuman Khandual
2022-07-11 7:05 ` [PATCH V7 25/26] sh/mm: " Anshuman Khandual
2022-07-11 7:06 ` [PATCH V7 26/26] mm/mmap: Drop ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-07-11 20:14 ` [PATCH V7 00/26] mm/mmap: Drop __SXXX/__PXXX macros from across platforms Andrew Morton
2022-07-12 2:39 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88328a82-7275-608e-46f2-4203df9d9fe6@kernel.org \
--to=dinguyen@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=hch@infradead.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=openrisc@lists.librecores.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox