From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5BCC169C4 for ; Tue, 29 Jan 2019 10:01:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A550520870 for ; Tue, 29 Jan 2019 10:01:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A550520870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 204518E0003; Tue, 29 Jan 2019 05:01:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18D7D8E0001; Tue, 29 Jan 2019 05:01:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02FBF8E0003; Tue, 29 Jan 2019 05:01:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by kanga.kvack.org (Postfix) with ESMTP id C87148E0001 for ; Tue, 29 Jan 2019 05:01:41 -0500 (EST) Received: by mail-qk1-f200.google.com with SMTP id z11so21321900qkf.19 for ; Tue, 29 Jan 2019 02:01:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5i5ehniMTPZGh/ehoxiSSdAez0EbjzZbt6w+xmG76Dk=; b=Bhj6dRlWije4igj8N1+ozaIFEajPFXfnkdcOE1WUe5LVQJP2K2BTbMKUf5Nyfr5JH1 Vxkv9qDMaGMHeM3TQZktx5nnSrUUpoCTdL/6RKeGF5CepLrB+myuaTyl4b12b3iOCDKH Sv4aI9hKoGD0elwNK+tgRz6otRyKp/5BjVUDvIWqegAuQJGSCnEAdCcMhjaBxclsCGda h0Lx1MA94IDizzK/c413qHEFbMjW+TihYDTb/UHRhx7tEYvp8k4AYvmWEJozoKIVDj1/ xtxv8QAq7EdJCqDKW09wBr/0eQCnUayz0baX/h8EIMRAqXHJzO4Yjo64NBVT07E1nI+v hzqQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: AJcUukf4uiMyo/mvJsA5zJ4te212QYYFD71mUnXk+Q52dMmmv3dPrUho CPZhOEHKcnXmrGfrftjjTH6Klk5ItWdzjeF/r946JK8ufSdNOXuVqS/V5l0MfgfQ1Ont5yYZF+V ueapKUL1JYHx79sAOm+xiW+Lxyolk/Te0Nz91RW04rSYyWy0Z72w0yo3gdzGroZ5bDQ== X-Received: by 2002:a37:7707:: with SMTP id s7mr22986351qkc.252.1548756101561; Tue, 29 Jan 2019 02:01:41 -0800 (PST) X-Google-Smtp-Source: ALg8bN7H4/ZvC0ZLyQO26AyCJetC1yswbk0MvsNh+f8wvbXvlZVkbjvT9ehqYpr4jW9F9YvD4AJ7 X-Received: by 2002:a37:7707:: with SMTP id s7mr22986328qkc.252.1548756101080; Tue, 29 Jan 2019 02:01:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548756101; cv=none; d=google.com; s=arc-20160816; b=kDmfOZ0Tzq08/y8vbQaw2j6ORjV/ARf3AFk+ipP072D1zjA0IVc7xOWbI+CNbDeY0B UnP4sJRNj57N/uNLXoCChG2zOHS6xkX50AISNcKY35/y/GteDpyHINb4s8lWVg56/kfi FbDyLwK8lauH52L2KMGOINhBV0JkvgRA5gxR929rTDRPWTcBPKCMIYOKmqPaeQUi6n9r 2McFPXsU9k5pvBUPS9mEoeiKpAlX60YQGCwVAa2VdUJBL7pqCekzKoR9vXLCBsGTdyvQ qab/Yh6ibE6bite5gYXNGCajaI+b0mYHaUSVayDVNDfkCyLLRJwhcHRM2xiSbVc9dwVb agow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=5i5ehniMTPZGh/ehoxiSSdAez0EbjzZbt6w+xmG76Dk=; b=wLvUfewlwwGagr49VZvbQ25JJZoV831TAjz5/VOBWJMxLK8BR6Sx2+2ipbnWBP3bHx GYujf0g8xJNqdSrxmzh/4GiitoGo6yaq9jZiSbWWdBnAzOIfp6Ey7aiIPcB92CMu3Gam CXCKlNVjn4KswpjWMSoynwyhyfbnYhGHDBtCqhKCKBaZn08Gtcw4eMYrzT9+/j6rUljz DTVl8zTqRHGyBjdyQ3u9qB8A7ojUsqmlw3ZSQcHa5Q3m7zPqXdtWxNyVBUDoCYciFWvP ASjCtQHb2iQkc+sf1nkxF+onMsa1Y/Ip34bbFMs98cn1Nx8zYbIhRiPTzQU+/bvONNjZ sIWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id a22si3251831qtc.162.2019.01.29.02.01.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 02:01:41 -0800 (PST) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD6CE88E57; Tue, 29 Jan 2019 10:01:39 +0000 (UTC) Received: from [10.36.118.12] (unknown [10.36.118.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 564F73780; Tue, 29 Jan 2019 10:01:36 +0000 (UTC) Subject: Re: [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it To: Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman , "Kirill A. Shutemov" , Naoya Horiguchi , Jan Kara , Andrea Arcangeli , Dominik Brodowski , Matthew Wilcox , Vratislav Bendel , Rafael Aquini , Konstantin Khlebnikov , Minchan Kim , stable@vger.kernel.org References: <20190128160403.16657-1-david@redhat.com> <20190128201902.GW18811@dhcp22.suse.cz> <725cd2b9-984f-d69b-1967-660d32858ce4@redhat.com> <20190129071837.GZ18811@dhcp22.suse.cz> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: <8830012a-1fc6-f937-d72c-b61af03d5913@redhat.com> Date: Tue, 29 Jan 2019 11:01:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190129071837.GZ18811@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 29 Jan 2019 10:01:40 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.01.19 08:18, Michal Hocko wrote: > On Mon 28-01-19 22:09:14, David Hildenbrand wrote: >> On 28.01.19 21:19, Michal Hocko wrote: > [...] >>> David, could you reformulate the changelog accordingly please? My ack >>> still holds. >> >> You mean reformulating + resending for stable kernels only? > > I would merge your patch even if it doesn't fix any real problem _now_. > If for not other reasons it makes the code less subtle because we no > longer depend on this crazy __PageMovable is special. If the movable > flag is supposed to be synchronized with the page lock then do not do > tricks and make code more robust because the next time somebody would > like to fix up the current semantic he might reintroduce the bug easily. > Sounds good to me, I'll rephrase and resend. I'll also have a look if I can easily refactor the whole PageMovable logic or if this is more involved. Thanks! -- Thanks, David / dhildenb