[PATCH] filemap: Remove unused folio_add_wait_queue

[PATCH] filemap: Remove unused folio_add_wait_queue

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

folio_add_wait_queue() has been unused since 2021's
commit 850cba069c26 ("cachefiles: Delete the cachefiles driver pending
rewrite")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/linux/pagemap.h |  5 -----
 mm/filemap.c            | 19 -------------------
 2 files changed, 24 deletions(-)

diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 68a5f1ff3301..4650416cbf6c 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -1267,11 +1267,6 @@ void folio_end_private_2(struct folio *folio);
 void folio_wait_private_2(struct folio *folio);
 int folio_wait_private_2_killable(struct folio *folio);
 
-/*
- * Add an arbitrary waiter to a page's wait queue
- */
-void folio_add_wait_queue(struct folio *folio, wait_queue_entry_t *waiter);
-
 /*
  * Fault in userspace address range.
  */
diff --git a/mm/filemap.c b/mm/filemap.c
index 56fa431c52af..b1bdd8ce7f49 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1473,25 +1473,6 @@ static int folio_put_wait_locked(struct folio *folio, int state)
 	return folio_wait_bit_common(folio, PG_locked, state, DROP);
 }
 
-/**
- * folio_add_wait_queue - Add an arbitrary waiter to a folio's wait queue
- * @folio: Folio defining the wait queue of interest
- * @waiter: Waiter to add to the queue
- *
- * Add an arbitrary @waiter to the wait queue for the nominated @folio.
- */
-void folio_add_wait_queue(struct folio *folio, wait_queue_entry_t *waiter)
-{
-	wait_queue_head_t *q = folio_waitqueue(folio);
-	unsigned long flags;
-
-	spin_lock_irqsave(&q->lock, flags);
-	__add_wait_queue_entry_tail(q, waiter);
-	folio_set_waiters(folio);
-	spin_unlock_irqrestore(&q->lock, flags);
-}
-EXPORT_SYMBOL_GPL(folio_add_wait_queue);
-
 /**
  * folio_unlock - Unlock a locked folio.
  * @folio: The folio.
-- 
2.47.0

Re: [PATCH] filemap: Remove unused folio_add_wait_queue

[David Hildenbrand]

On 16.11.24 16:14, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> folio_add_wait_queue() has been unused since 2021's
> commit 850cba069c26 ("cachefiles: Delete the cachefiles driver pending
> rewrite")
> 
> Remove it.

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH] filemap: Remove unused folio_add_wait_queue

[Vishal Moola]

On Sat, Nov 16, 2024 at 03:14:46PM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> folio_add_wait_queue() has been unused since 2021's
> commit 850cba069c26 ("cachefiles: Delete the cachefiles driver pending
> rewrite")
> 
> Remove it.

Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>