From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D482BC3ABC9 for ; Fri, 16 May 2025 18:55:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14CE6B00C1; Fri, 16 May 2025 14:55:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C4B56B00C2; Fri, 16 May 2025 14:55:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83D7C6B00C3; Fri, 16 May 2025 14:55:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 644FB6B00C1 for ; Fri, 16 May 2025 14:55:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 80CFDBA329 for ; Fri, 16 May 2025 18:55:35 +0000 (UTC) X-FDA: 83449674630.06.1E25101 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id E4A794000A for ; Fri, 16 May 2025 18:55:32 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YzsoAMCv; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747421733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ncy0IOMN62OZsySnUUO+DO+ffjUqHUwVWIhcHttPrHk=; b=UK7dnjhdr9SiCkha2MWh3rDdxNmge6C012jUMjllBQEHQ46BG107dMIwp4dYUHTLzlV/Ma n+QOJPbDRXkCFkpcJCiOEcciEMErdqIJN5BlhoU4dR/8PnNV51Q7uhWCnvGq2K3HL1IPFu JoJ2EB+Pff0YVZpIHxthCvKLrXN/HV4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YzsoAMCv; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747421733; a=rsa-sha256; cv=none; b=rgtaHBFrjstpdmN+aRrbJPOl3x9Tc06yYNhiCTEatln8eg/dkuSbnByTEsTkgb47P/9m4X HBRt22+iL8VHtngd3zieMkIUVFCSlEWULsUFCHim5hTtUtS6CXir3/UUwm64ITtC/JTpLE L+/XdJpx72LZp0+1LgjSG9C3b6MNLsw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747421732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ncy0IOMN62OZsySnUUO+DO+ffjUqHUwVWIhcHttPrHk=; b=YzsoAMCvKGDZtp00ZQ4KcdKqaiRh3Cfe4m9Wflxss5+DA1ymB/bIZohTFu89K8OFWXSxLh UA9ChMbrAh58cgJwI+/eLwvF7tkLT+rZuq9BOl9T4fBXgEmfOKWOVhqst/zhzk5F6w3d43 G3wNF3idzMl4fEcHYFu3laITxwM35CQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-_VJwwSWxN2-m0YlBkwIEZg-1; Fri, 16 May 2025 14:55:31 -0400 X-MC-Unique: _VJwwSWxN2-m0YlBkwIEZg-1 X-Mimecast-MFC-AGG-ID: _VJwwSWxN2-m0YlBkwIEZg_1747421730 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d734da1a3so13368895e9.0 for ; Fri, 16 May 2025 11:55:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747421730; x=1748026530; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ncy0IOMN62OZsySnUUO+DO+ffjUqHUwVWIhcHttPrHk=; b=vHhrJ3KgV1WhLKqdxXL2+Eh77ltkuzh8Y0Egla3fGdbDxk/VPLfc3wZ8awtmywyotr fnLZ/8dQs7lyIRq8wdSmeulS19P9DW0W5Ll6ZcWDoibyzqNK38WS7RsXjupE80fHlwJf vNhaEbE/cQJpusRrfcH5ti1ml3HxwBy+ecR5aHxOm+OWInoQa7Go4L4Cs5QOxSRMl6G0 YXxoWcPV6pxizCdHlpvguVtuvAirvI9cbnqWoa2QWdmJGSXqDVRauzAQdeYbkggjXT2t xB8NgRbbza4geqDzqhkDer4cum+toJwvpeIALfi4ug6efZpTKE4ez8tK0n3uQJYjj8L5 mP8Q== X-Forwarded-Encrypted: i=1; AJvYcCXfNJMnR6/vy/s+3n1Zp35EF8qEG7gd30vS4LoJ2qLopvbXz12vwiwlKGaQyIK3UQeHYlGwvq3Zlg==@kvack.org X-Gm-Message-State: AOJu0Yyzcclp0T3mqEc5l70iS4aXjFRjZkwYQcXGDRDo4cA6PSxZolX2 ULufUveS2RzLz9kt1coUdyxf6wXF0jnei2akQ3hGGWaI31dzUOmaK0qagVl0vqtliOLhaMqYd/X MDY0yKaf71VweotX2d5q4fCwWoSGrBR8dC4lAv3k+vtyTxe73LIba X-Gm-Gg: ASbGnctNs6KDng6L3eL+AmXyibOUygT0nimZzxt5bDtAUxt7nCKS7kM85Dla7PfbRDT UQrsVCTCEra7sbZvAGccBrz6XGkoZVP9JmG1fEptQejQ6pomWr06h62WuowlRl2uzQzdY0sqhDT HyyrQos5XsqaHq00j3XidDfa3ddRNn3WD+/38WfUk14RuZeaUXaddLjU+rJZzPRT3otoQgYpP4I zMuLPfngvi7i/GFD5R1PsuQe+BO81U7gP6VGYviqzyULcDjDeUYCJzAlm7UVwFDawKJ7oWudbQ3 /k/hJDYL/iMfvfxgnNkhs7QejrJjnZXeMgPnC2aDuw== X-Received: by 2002:a05:6000:1acf:b0:3a2:25d3:3912 with SMTP id ffacd0b85a97d-3a3601d0869mr3566037f8f.57.1747421729868; Fri, 16 May 2025 11:55:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnvFvNMoXbCy664/fMYQNUZNHGmO5/8svXPk9nFJJT/F2j7rlj0r91U2NP66XBmlT+dm2IQA== X-Received: by 2002:a05:6000:1acf:b0:3a2:25d3:3912 with SMTP id ffacd0b85a97d-3a3601d0869mr3566005f8f.57.1747421729439; Fri, 16 May 2025 11:55:29 -0700 (PDT) Received: from [192.168.3.141] (p57a1ac29.dip0.t-ipconnect.de. [87.161.172.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a363d1fba6sm1606167f8f.95.2025.05.16.11.55.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 11:55:29 -0700 (PDT) Message-ID: <8811fc8a-5f1a-4a1b-883b-f006da844e55@redhat.com> Date: Fri, 16 May 2025 20:55:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/3] s390/uv: handle folios that cannot be split while dirty To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Huth , Matthew Wilcox , Zi Yan , Sebastian Mitterle References: <20250516123946.1648026-1-david@redhat.com> <20250516190755.32917d48@p-imbrenda> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250516190755.32917d48@p-imbrenda> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QcLsbFQGSFtDZT10-f78dYKsMo06anQz5ZCC-yArORA_1747421730 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: d189m5b78q696untbt1djef75685sbq6 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E4A794000A X-HE-Tag: 1747421732-302636 X-HE-Meta: U2FsdGVkX1/AXeWl/z8l26yLCOmxTnDCw5PHsv3g1WqBh2VOESfpm7GKF+cKbQ6ZpUu1WEdqH/Fd3BfHRTgRu/Op1biAVaCfyYs1RHP+nhZjdOrtLMvJW2Sfp1EcO1bodiTNLUYr9eIHm0fgh4gPoTTFM1cGhinKdVSL7hMNO6fNtnb2aYRsUftcMjjbMJodw3gHUORti1PW7thXA1XzP3d7GQN+7LVc+uJ7K0bsWdneDBLcbsWkBg8uLhuM6SQM6aLFObuxYaBen0WOkEsoL+cjrhCFB0lrM/6/5vBZwtGKt5vG4vOf+RBTax0AlLMo3VoQMiZ8HMAKUyCnz/bwsppBYO+Lm/rMN274qfdNT3PytGtXKLWGg2OLGuzSaVHiLIwhDUSa72OdtwDO6glKSF93VZp2oCcMEGeoAWr+8ZHwY3knLMCxHoEU0NlvfT0msvSVJJnOHt+XsqmaOCGVYNUvDIKY5wxEX86BmlTzHCjz1Y8j4Zmc4ArXMCla8QzW/by5he3YbCP43o/sfa3ka78dMn6oBiBvEInD8uMSxcwWIdGv+ds0nenBnAz/JD1ZJsRaPZIW88XWOF+8WHCUzgeKwHVgGhxoRHm6rySyo0XL4yXpKt7WzPMuPL8hWh4lD0libRzwhmSTLuveyfIkcQDkImcneQWSWrs3cymRAzeUznyXgQBYdEoQrttFRDpFl0IxudEpUlHRv4HiqVE37bfY+BWZkCV7P2PmQYh1FUGbU65DhDDi1TAIaFmAqk48jKC9rT8XbY8X7rZYsmmIYevS3tVwYyGmUsx76m9aI4hSNCI7lcSoOyM2C/dHCRewdmI/SXaG7Vu93t1BcqFcfLEi4BGnyNbV+3bqgQ/4W6XEAYxbS211SEKwAP7SgKFYv1zdFf0Dz/yKPPp2zq1kibuIlVwyGKgd8yqeVltFjMjCU2WzWBLFxUk2NpoaXBjsnriY8WfpayEM1w6BVi4 ubFJ1ld7 BF1LnG5ho90Bb2RMyUf8gjm/abLK/n/vX687pj3pXnC1KhWWDD2wqjd8izuPMWfn3dbvNBAmSlnB0v/iJxOIHW8VQfV3DXxeB9sf5XwuFUCm8FhuPzdlve5AH8d36Z880VaNztq1bpJheunLQs3DU+x1Fc1gQb0E6Ap3E6FbVgRCxLPd5dYaJ1mGuiIZgvmrwMG6hqNaaQeAmkszQEGF8PqFGAAkxLv5+M3++BOwYKFYMtKdFNTz/wD1b4aSi1OHmr+KynJ+7TDs703Q4X3AAsY8vqzX5FLjAAQdcSnDZD010ildd2D8IKORe15/wMOp140MaeXz2gnTRGao+/eufjtDlQsblb4SdyAdJrJYIQUBwusfnkj2lFGiufcO0GyXgQ9sd4y/NoT4AO4temQ39CiJoRuiWmqBUr43CPWtOA5ppFo/mfVJj8cZZjWWBxp2r6i7UZkJEdfDWg9tm8xPOhwg7BQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.05.25 19:07, Claudio Imbrenda wrote: > On Fri, 16 May 2025 14:39:43 +0200 > David Hildenbrand wrote: > >> From patch #3: >> >> " >> Currently, starting a PV VM on an iomap-based filesystem with large >> folio support, such as XFS, will not work. We'll be stuck in >> unpack_one()->gmap_make_secure(), because we can't seem to make progress >> splitting the large folio. >> >> The problem is that we require a writable PTE but a writable PTE under such >> filesystems will imply a dirty folio. >> >> So whenever we have a writable PTE, we'll have a dirty folio, and dirty >> iomap folios cannot currently get split, because >> split_folio()->split_huge_page_to_list_to_order()->filemap_release_folio() >> will fail in iomap_release_folio(). >> >> So we will not make any progress splitting such large folios. >> " >> >> Let's fix one related problem during unpack first, to then handle such >> folios by triggering writeback before immediately trying to split them >> again. >> >> This makes it work on XFS with large folios again. >> >> Long-term, we should cleanly supporting splitting such folios even >> without writeback, but that's a bit harder to implement and not a quick >> fix. > > yet another layer of duck tape > > I really dislike the current interaction between secure execution and > I/O, I hope I can get a cleaner solution as soon as possible I'll be more than happy to review such a series -- hoping we can just support large folios naturally :) > > Reviewed-by: Claudio Imbrenda > > Thanks! > David: thanks for fixing this mess! NP; I had a prototype of patch #3 for a long time. But after rebasing on top of your work I saw these weird validation errors and just couldn't find the issue. And I only saw them with patch #3 on ordinary pagecache folios, not with shmem, which severely confused. ... gave it another try today after ~1month and almost immediately spotted the issue. Some things just need time :) -- Cheers, David / dhildenb