From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 048DCC282EC for ; Sat, 8 Mar 2025 05:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F59B6B0082; Sat, 8 Mar 2025 00:32:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A0336B0083; Sat, 8 Mar 2025 00:32:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843586B0085; Sat, 8 Mar 2025 00:32:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 652656B0082 for ; Sat, 8 Mar 2025 00:32:02 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1F33E8150F for ; Sat, 8 Mar 2025 05:32:02 +0000 (UTC) X-FDA: 83197262484.17.497911C Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 66BDD1C0003 for ; Sat, 8 Mar 2025 05:31:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=hCejTeG8; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741411920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QwGokHK8MWELbszfeUznitYDMBt/G0N6Dzae0aons/k=; b=LVN7VKrjnAyTxbWyiUAX8OFRUP/wkpMcy4c+96r41sD+NrUJCdIxeb/kvq5ONWObk2JZAK oI1r9ALJU+jHsDt8ML2Y7he7s7ttmAJ6Z7JGnEphttYe/otlIgKCI2xiX9YLjiPnxbMfeR QYgToFotnE6CDsUrqw4y1oMYMfl3w/Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741411920; a=rsa-sha256; cv=none; b=jdcQrt8Dt7bGmrgYT8YGjCe+cHJ4N3PW3Robq7c5r5/5fc9761Lat8Q6Kl4soKxdgpvDyd achbZP3MFTHAFKAYBYZTtdAA5qvc62Xgc/Cv7IBz1IJsaTAb7eUXd9QO/5FVRp1rR6R2fo 5I4e85320RH4PlVSzr9YeNFrRUCnf7Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=hCejTeG8; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741411916; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=QwGokHK8MWELbszfeUznitYDMBt/G0N6Dzae0aons/k=; b=hCejTeG860P5IHzNZQiN7b/Ek0vHmZy0oDwvcBnx5yqgnzzLBg3gxpOfVSSROEzD4uZKYMEM23IWIVRw+S7imEb6KrMWOSbdPlb+Y4VQLb3wkLvtQFBofghWNJLyOTDJZUPFUBaONh+aJ6aB9N2+6q/ocLm5hgEjvuZuLMd1wx0= Received: from 30.221.80.100(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WQu7mhO_1741411914 cluster:ay36) by smtp.aliyun-inc.com; Sat, 08 Mar 2025 13:31:55 +0800 Message-ID: <88098e5c-1514-4d8d-a220-531a9b473ae3@linux.alibaba.com> Date: Sat, 8 Mar 2025 13:31:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/11] shmem: Add shmem_writeout() To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-mm@kvack.org, intel-gfx@lists.freedesktop.org References: <20250307135414.2987755-1-willy@infradead.org> <20250307135414.2987755-9-willy@infradead.org> From: Baolin Wang In-Reply-To: <20250307135414.2987755-9-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: x87jjh1reryxkuwjuosfg7rbjjnrh18i X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: 66BDD1C0003 X-HE-Tag: 1741411919-794115 X-HE-Meta: U2FsdGVkX1/Tskrv5srC4BoQBRwr0EmIGqK3UEQvFUh3Mg5cteGZhV4tIGCGDOaNBvJv0RDpbu5gD4QozHYUyqEfSFNVb6J5wTfkkaCl2QlK5DupI4H1ajgdsT2NjRUwnHLKDibd1rbZ7lG+qlbXGNHuoaMlbVe/hbT4jnbp2bMGJ0D0sI4O7EtWJqwdoxJgWZ5lhHBLi/+5eq4SvkDASNzMRSTJAvbJSIybHbfsdKC72lOu1wX9lZ5bI34/elG1AjOL5ECJlsYIIj9VaK7xUy+97nlC7U9ICqsE++Oex2ayjctfLdEaVQS0SorKnuMgjvggIrSKB8m+ssZonzL+O4kqwGXF5vYhvMsWgaqHSoxaPpZI26ZxXx0JRl7oCpeKJ7do0UAqkKbZNoBaLsWYkNblzHAQMw+vZWfFbEsyipUs+ZCxlUCw71wZNnAuwTpr9XYBOIHaOVwn6RRhrkqx2q75eX/poTIhEpmY0ZykWo60fmTEgcSHl7ixfFDWisbdIbkGAooygPzTE2id2rE7EzxJyJfP/PwuvMdsIB3EdBFRg+/MKXv63wekxItOXnI+tUAatYi5nWVTcatTky4QaS4boX8KT7tAUopcGjyIX0qVxmZlDk3t5Kj5umi2NK+2aZeqlgnL6F+TP3trBnCNKXkQGtsgwZaOQ4i4V/Knu4ZMt1E7sJxGRaW9SmBhrtqaF7QZHBA/TayvM6ifVNMkqziB0TDJkIoU2SMQRO6lp5oVJwV1XtEBJzJARNyhzCjh+AOfYCWZF4+Bi/z+citoQqqjoOd2htYlgdEUw2wCco/ZM6Fudy3nZmUcUJl7U90oQyZygElx+IGn5RurMBQVFkBP0+cxOfsON8UjTRFpypanjIkfA4H+NOoEQfhfLkTrMnRDw8pryFpAyILIPnA3OYcXWRJLeTiZKk2M7xrjIe3MwC8EElAZhuP4DtjMUTmDPktInbvUwlCHkYM6MYh wmlxv1fU oeU9rVzWkUw4I3TXWadEHNFA+w39de3xb2+xAzkiuSrk/iSCqfDzpAVvXVxY8/eAGoWRrB3WCeHVuvr7+tz9NRAAvzK3QTJdlmyMHFnSn8qFj0hOhnsqKY5m0teOrRyCLGEnZrywyFzx50tlXYiiPBm8kKarF9PNO1QfFbDxtI74FB8BGZO42NQi74lyLI5dLl0JPjYg+W5Vb+q2Z2hmhLr4nM/iTp3RTCAaSFSTIwn84mJ8JDVI3girV24z1Lwiw1N2VKtL3G8ue5ipW8p5aW9Nvws+68VTCXJ9rgpYGiu2dErs/jf1crSvGcch6I/yPaUBdW+jCAdDpBHzi6LM+aKQi+7cyddfMDQ7Pvk0DKFyU3hbnqL7y1HskTljvk2ewXMKO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/3/7 21:54, Matthew Wilcox (Oracle) wrote: > This will be the replacement for shmem_writepage(). > > Signed-off-by: Matthew Wilcox (Oracle) LGTM. Reviewed-by: Baolin Wang > --- > include/linux/shmem_fs.h | 7 ++++--- > mm/shmem.c | 20 ++++++++++++++------ > 2 files changed, 18 insertions(+), 9 deletions(-) > > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index 0b273a7b9f01..5f03a39a26f7 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -104,10 +104,11 @@ static inline bool shmem_mapping(struct address_space *mapping) > return false; > } > #endif /* CONFIG_SHMEM */ > -extern void shmem_unlock_mapping(struct address_space *mapping); > -extern struct page *shmem_read_mapping_page_gfp(struct address_space *mapping, > +void shmem_unlock_mapping(struct address_space *mapping); > +struct page *shmem_read_mapping_page_gfp(struct address_space *mapping, > pgoff_t index, gfp_t gfp_mask); > -extern void shmem_truncate_range(struct inode *inode, loff_t start, loff_t end); > +int shmem_writeout(struct folio *folio, struct writeback_control *wbc); > +void shmem_truncate_range(struct inode *inode, loff_t start, loff_t end); > int shmem_unuse(unsigned int type); > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > diff --git a/mm/shmem.c b/mm/shmem.c > index ba162e991285..427b7f70fffb 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1536,12 +1536,20 @@ int shmem_unuse(unsigned int type) > return error; > } > > -/* > - * Move the page from the page cache to the swap cache. > - */ > static int shmem_writepage(struct page *page, struct writeback_control *wbc) > { > - struct folio *folio = page_folio(page); > + return shmem_writeout(page_folio(page), wbc); > +} > + > +/** > + * shmem_writeout - Write the folio to swap > + * @folio: The folio to write > + * @wbc: How writeback is to be done > + * > + * Move the folio from the page cache to the swap cache. > + */ > +int shmem_writeout(struct folio *folio, struct writeback_control *wbc) > +{ > struct address_space *mapping = folio->mapping; > struct inode *inode = mapping->host; > struct shmem_inode_info *info = SHMEM_I(inode); > @@ -1586,9 +1594,8 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > try_split: > /* Ensure the subpages are still dirty */ > folio_test_set_dirty(folio); > - if (split_huge_page_to_list_to_order(page, wbc->list, 0)) > + if (split_folio_to_list(folio, wbc->list)) > goto redirty; > - folio = page_folio(page); > folio_clear_dirty(folio); > } > > @@ -1660,6 +1667,7 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > folio_unlock(folio); > return 0; > } > +EXPORT_SYMBOL_GPL(shmem_writeout); > > #if defined(CONFIG_NUMA) && defined(CONFIG_TMPFS) > static void shmem_show_mpol(struct seq_file *seq, struct mempolicy *mpol)