From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8740C83F03 for ; Fri, 4 Jul 2025 08:41:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 480D86B032A; Fri, 4 Jul 2025 04:41:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4582E6B032B; Fri, 4 Jul 2025 04:41:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 346946B032C; Fri, 4 Jul 2025 04:41:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 188AD6B032A for ; Fri, 4 Jul 2025 04:41:50 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 93BB31A01BB for ; Fri, 4 Jul 2025 08:41:49 +0000 (UTC) X-FDA: 83625939138.02.3076316 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id EBFD940002 for ; Fri, 4 Jul 2025 08:41:46 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fopQ/fMF"; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751618507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DtiG2g8/+dbJ0SRACiMmc2C5udd730N4XdleYm8ejAE=; b=c9KdUnWGEwFuHrHT9XcD/UfszGM4LZpVOwA3FUphxJG2Jl//f+LeCrRV2Z+Sb2GruqZmBC HFOjJMbvLjAfVJJjZvw7QOZubEa2Ax+pVkRWmNFRsVvuTP+y14uDqRT0zdJiY4G9Pxa7UC vDJVknRV4+ccrmzZcPF5hyRF4dNZC6I= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fopQ/fMF"; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751618507; a=rsa-sha256; cv=none; b=E9CskOs37sRIJr5AV08lW+8JsH/2EujqwBPs+gnlQmb54Kkt1mUduaW3WoIfELhtR3nC8B aBmfiwrDc5uyDgomafvyWvMvh6lVLG45iMn4RG2qUBIkf4axYdKgsnAtoX5LzbVDW4gFQR BqoXkxGdG9jW/48vo31EjkboVvJ6JWk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751618506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DtiG2g8/+dbJ0SRACiMmc2C5udd730N4XdleYm8ejAE=; b=fopQ/fMFmA3A/fh+IniZFSdVTBuqz2RQm708gJl8xirnGCYQb4JIbS1O9+8+KfgjrH5d7M oyLhR24XOOCzfrXZ2UvmDNzWrF2uK4jQqRr1sctJzH21lIyi6hSpnmQ3tPeCrRjZQ/aeK0 S6A92mU4ak69eiV7th3a4ISgAw2PFXQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-V68pIMczMO2a87YluFSBgA-1; Fri, 04 Jul 2025 04:41:45 -0400 X-MC-Unique: V68pIMczMO2a87YluFSBgA-1 X-Mimecast-MFC-AGG-ID: V68pIMczMO2a87YluFSBgA_1751618504 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4539b44e7b1so4466605e9.1 for ; Fri, 04 Jul 2025 01:41:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751618504; x=1752223304; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DtiG2g8/+dbJ0SRACiMmc2C5udd730N4XdleYm8ejAE=; b=rEc/pzgWrayaPjSqY8M/XzAmed81eGNcMYTSoE1RgHqXZPUHnR9eUwznTJ9OkZ98cJ vWM+diV+fe5h7CNPUk1CHZsBHZNug5K6D+zam0CAfTw4//N0JYMSMxol3uwQflk6Xo+J 6OWZlZpXepE6npCv86Rlg0Hu6iPYsqc/XYVTHUfKCT5hUAINGMG6bB+dymndEjuyIGHh I5UXmC2gek/Q7eZ11/Ra3/z1qJtO9NAs8PCrMWazlT5GL43d9NMvEB3qlE43ATfGgnPs n1+LcC+1ZWPOBLQ1uR4zC8cqLG6Yrs0POIoEFKASiKp/Zvg1neybKnP7WWLd4YScirIJ ElUA== X-Forwarded-Encrypted: i=1; AJvYcCVkD3q1zTSpeXbxJTNkJX/66yVDQr/mw8lvsvcdBxdc6WdgY8w7RQ5GhA3k/dpDnFuS7F8xX35+HA==@kvack.org X-Gm-Message-State: AOJu0YyqtfNCUuUUi1JlXBO/3weheNI14g2UdYR2iu1V+IBt3Sw3rLFJ q8NtpmbIV+drDCKt1hy1kAO7joJ96WwYJKdxKq1GJe4QPzOgQnPH+fwkYDHY/SM4mL/Ls67i1ci UW1BoUyc7z4RocE3RT596JIO3KqYtQuTi0F6DpRZNhkgXBgrpyQtg X-Gm-Gg: ASbGncsdiHImICSooj32dIcwE2A+TbgUvPkcnn9vOWWtU8A8EqLMR5FM57epREglijf PbhWEmey+iZg7hZEXIoMf+xzVBt1qEgX7/77/X7+tFkRaGKs5HOoiCpknrQxAgbYfGfnkgT+Gds 2PiwWhf4XtCV+xrvWJcqDk4z90eBM7fnwvqi7SskUTEqA9ixHOkhEi9TpNX8pAsW0Z0qtVH5ubt B/ObLi7MsYLSH1x4aIO1yK+vkpR9nvhu5ysWi60JSPNY/OEy9bNqPUktzCDUUQw+IvCriIrzTuy pnncMCZpLJ5bWmf95YF64ptz/v+RpADILRzGGNSqIjl/ieok/DmkFGlzeOVaGv7NRCPjyhnOD0U 8+4kkQdDOKXY/DMNnfhWaaZot667XOZLSgj6ZOLs3nEenvvY= X-Received: by 2002:a05:600c:4ed1:b0:453:1058:f8aa with SMTP id 5b1f17b1804b1-454b4e7d051mr13519385e9.15.1751618503774; Fri, 04 Jul 2025 01:41:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHf48etFOJwEGYaWEt7WrZh4RJh7lnUUC4K0ZRVjz1wBiG8LdBhaSPsGLY+hT98h8z32cI4Ow== X-Received: by 2002:a05:600c:4ed1:b0:453:1058:f8aa with SMTP id 5b1f17b1804b1-454b4e7d051mr13519025e9.15.1751618503395; Fri, 04 Jul 2025 01:41:43 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b96731sm1899752f8f.55.2025.07.04.01.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 01:41:42 -0700 (PDT) Message-ID: <8806f687-12e4-4456-a7b6-ecdc5adc9f2e@redhat.com> Date: Fri, 4 Jul 2025 10:41:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] vfio/type1: optimize vfio_pin_pages_remote() To: lizhe.67@bytedance.com, alex.williamson@redhat.com, akpm@linux-foundation.org, peterx@redhat.com, jgg@ziepe.ca Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250704062602.33500-1-lizhe.67@bytedance.com> <20250704062602.33500-3-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250704062602.33500-3-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sWdypribgS7kmf513k3HZegRN5wDDSEuEIlEs85scAo_1751618504 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 1uox1jncw31p1ijn9zcn6pg9p9n5ea85 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EBFD940002 X-HE-Tag: 1751618506-175690 X-HE-Meta: U2FsdGVkX1/EdfJCm62NmTeuZxruROPcyQUQaBAnRKQELSEoqOcuhfAbTgn1y+mKl+E1I4r310E+/bs9lAVqRYP0O546tzMEWUL3meJT7lNwoVNFagogsaZVlnaiK3sIZEHZ24t4vwGbaHg4z1vsaECo8dHmiIkFwTvwUu9TezquW0LFGeBH/3xEIBOf+9YcFBRilViYuUJiDPlrwuQyBAIb9BgOXnAXNYu/K7DsMHKh1q/Ax6CqR4Nl1pa0BS2hYmRcHVKKI7f4mDix8cuhvDs8ew+794Iyj9hgfX1HcNh7FkfEB19TpgUAtKIAxIPAviMSYJLxTCHGo2EdbB+vDfTeKGl4qq6LkvIUSBytldJ9xg6xJMYd+jKrzfCEUPDwCPyAYVvacG9YSYY0Mh80AavyhriYpg/QGQFkDKRxCNAhd+KDjemPh1VAmz3mmGp6eWHIqFU2CXDnFs+J2v8+qtZ4kIeeA0AZnOZ5Ze+5lNw84csxWkF/2HAYANDshyglz+w0vCgvzZTwyBWHTnZvfVrIx930A1x8bjef7jjfncUpujUtzMBtDSS4FaPywRYVM6Oq0tsibpve/k9SAGozptX7rbiLjIVg9fg8E2ZUnHi4w2wSBC5aA0/yGL2lo+RUxWngsEZCvEfZClHicMYBBJ2+PObjcABs8EldqvIcm2V1Nf5Lc+q38XsTElBVyNUe1DG4SkkfcIIvoVMIW6yqyq04ydKmTmWVts9jgF/ZsJHyTwwn5SA8F9WNBOzO8Ll9MW5m10MM2ZhgJE5gGFPo9gCJg45OKoydd/Ch9IrTvo/C1r5bm/4yqFD9uV8K6aXtwoWdMBq1lD0roZTLZUiLR8a7JfqDKcw3hnQmy/iQEh5Z5PMUwEfhryrG/qOPyr48J+mU8XFMmUirReNm7etB0ukOra4QyM4OB45XXiMk3qlW3RBQOGlN+6yqVWWtdDuAlNNDPv8eqVvaJZuzb84 tGs/ug3N 1cpofwuQA0emd9NBWvsfnaOV7XvJPgawDfoc1ZhsS6cTacLyTGf42T05JQF0vCR0j3UDJNuBXisrAuuvQ2FWzjFeAjjeN85u+3HcdV41Aii3t7U+z4LCi4QwaO/FCPvhczFNB4Lum2JNrGLVVXLki6Qjrkw7Cne2Cv6AIA6E3C91qc5GshKpMT8btqnyulQHyYoeqYKbgJd10UUGWIWK64B2JQ94KZZEVCxp+5JvGIJ6rLD2jNnGfD87pSshyM1m76jCJ4DqWKXOQ1PuyIOYwpKa6WALI+WyQicvvBNvWJV+9yjM9zhy2AuXA4RFGJHfki1zfcwa306lNAHLbj0HEokDjOAghlszmMfcf+YCHGhjFqVfTiVRzKJCBLvWd+AeGOdlyvl4Q2om65HBgiJnGcIx3Ar7TfQGWbERCxXqtLdNZuejVjUHN7VgVDKjqIg0imVztoeE9Sd4P8MOKTiUnLJjUG8hRlTm1WWRtl8XgNSKxJwD77YFzaHg5DRspesEZJk/RwY56ebnGhQP91Dr4OyYzQdIRPZHjRfEjhp9LSQu11rwzh5zBliyjxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > * Attempt to pin pages. We really don't want to track all the pfns and > * the iommu can only map chunks of consecutive pfns anyway, so get the > @@ -680,32 +724,47 @@ static long vfio_pin_pages_remote(struct vfio_dma *dma, unsigned long vaddr, > * and rsvd here, and therefore continues to use the batch. > */ > while (true) { > + long nr_pages, acct_pages = 0; > + > if (pfn != *pfn_base + pinned || > rsvd != is_invalid_reserved_pfn(pfn)) > goto out; > > + /* > + * Using GUP with the FOLL_LONGTERM in > + * vaddr_get_pfns() will not return invalid > + * or reserved pages. > + */ > + nr_pages = num_pages_contiguous( > + &batch->pages[batch->offset], > + batch->size); > + if (!rsvd) { > + acct_pages = nr_pages; > + acct_pages -= vpfn_pages(dma, iova, nr_pages); I'm not familiar with the vpfn_pages() part, but the other stuff LGTM. -- Cheers, David / dhildenb