From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5815DC5478C for ; Wed, 28 Feb 2024 11:44:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA7AD6B009C; Wed, 28 Feb 2024 06:44:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C58286B009D; Wed, 28 Feb 2024 06:44:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B464F6B009E; Wed, 28 Feb 2024 06:44:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A687B6B009C for ; Wed, 28 Feb 2024 06:44:13 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 69B45140F11 for ; Wed, 28 Feb 2024 11:44:13 +0000 (UTC) X-FDA: 81841029186.28.73238EC Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) by imf08.hostedemail.com (Postfix) with ESMTP id DA449160007 for ; Wed, 28 Feb 2024 11:44:10 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b="i haywTN"; dmarc=pass (policy=none) header.from=163.com; spf=pass (imf08.hostedemail.com: domain of gehao618@163.com designates 220.197.31.3 as permitted sender) smtp.mailfrom=gehao618@163.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709120651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VjKq+Ukh+01sMWuWGiG/7cL5r/H18SiycHisweLwLc0=; b=pQ173GFoVS+Gj/WhTj4557t8f1LFnrFmDtgYX6e25x6brologG9kC47trccDR3IC5AvSpk oDaS7pQXzTckSBEaqaS3HqI53KSr2y8Y0I/pYiUSfBhrc43lprkphud5fjYtcYoyhlYMvU hHXICYfaucyTfCjVuG5ScYLXHHPhkGU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b="i haywTN"; dmarc=pass (policy=none) header.from=163.com; spf=pass (imf08.hostedemail.com: domain of gehao618@163.com designates 220.197.31.3 as permitted sender) smtp.mailfrom=gehao618@163.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709120651; a=rsa-sha256; cv=none; b=OeDq6gfXLjeQZCpNfAqHlpk1DA2anJQoUqDUqiFrMM0BBxPDKcDjWCdJ018GYGbmsJ/pkp wu2xHsQY9GhruMyGsvINpGBgPJwUteGpbvTrEse0QE5u3AV0Iis56KbvRJJQLYJI+lDqNk RzYh8DdTjFAjeOaJD4mht+u3ow4RAM8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Content-Type:From:Mime-Version:Subject:Date: Message-Id; bh=VjKq+Ukh+01sMWuWGiG/7cL5r/H18SiycHisweLwLc0=; b=i haywTNP69rn3XOAbgkkn4MpG3so8jeJ84NicGK7s6SkIOZ5avx0VU7w3ZPxBOoYK N1ucBRewjCVM8JpPVIpbuFIW67X73g4pmi8mJII9HUwjPAETy7XtszC76IwFii1l QVycJoxyyquPaUWh9votg5n83CX/c+MW0xVp6gBBV4= Received: from smtpclient.apple (unknown [223.148.13.239]) by gzga-smtp-mta-g2-0 (Coremail) with SMTP id _____wBH4FmAHN9lO6xBBA--.7297S2; Wed, 28 Feb 2024 19:44:01 +0800 (CST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Hao Ge Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm/vmstat: Add order's information for extfrag_index and unusable_index Date: Wed, 28 Feb 2024 19:43:49 +0800 Message-Id: <8805D07B-9F33-42DE-985B-83E0E5C056AC@163.com> References: <20240228113332.358801-1-gehao@kylinos.cn> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20240228113332.358801-1-gehao@kylinos.cn> To: Hao Ge X-Mailer: iPhone Mail (21D61) X-CM-TRANSID:_____wBH4FmAHN9lO6xBBA--.7297S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxAF18WFyDCr1UXw17ZryUtrb_yoW5ur13p3 yYyF48tws5JFy7C3yxJF48Zw1aq3Z3JFykXF98XayrCw15Ar40yr17K34jvF4DK3ykG3y3 tF4Ivr1DK3Wvq3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRbzVbUUUUU= X-Originating-IP: [223.148.13.239] X-CM-SenderInfo: 5jhkt0qwryqiywtou0bp/xtbBdQOSFmVOA2v+EAABse X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DA449160007 X-Stat-Signature: 93od35nmaymph1p86usfj5fimsq4i9xx X-HE-Tag: 1709120650-991934 X-HE-Meta: U2FsdGVkX18Zp4LXunpvBv8yDPkrzULsLldqiZdUM5J80+OCbXKLrrfzu8gWz2Vxe9lRnSxohyX4Et8/7CVF2VOYpf4Jq1cW0OBH3y64tL+2PtPotf7lov5YjU6xlMNSO3TireWlM6jg7YuUReGmANY5igV/iUsttVqZG9zZKJ4A82+WeqOrE59jfwPS/MEHPjux6N1e4t/kS3rijG96LCA7ZyKqLvqQdf7MKsuAGXzynnF1DycCyFJwGD/PoS0EX6ZZGAnwGzxDMuAYKdwcrJJK/P+/p3p4NGU8mJqIbsDNovo2XcBoUy068gzJn2dTMJp+LtVJmFZRdD/RWxYi1UndwMPNCe30U3yIWb6oaWBFuVfGy+JUZe8bE788wQOyafHgD/pDS6Z7QPGX7OOXWiTCugHNC9ulpI43rbudjE2gkwiVnMFgZUHi29i8frP5gcbGiLqw4V4qYfAlHkEBBt83c87YizTipGSyJeI6eWHzykGUAU4vHt5DmtHiZWQdpnGFlHpsEeNBTRV5QX/UUcJBUOQ+X66/Bl6ijJoUu/mhYB2+lFSud8/NO6pjfCoooiGjGpR7YxlZqQfAgVdzcjc5cl6nOQmiA6izLGgR4FfcnKjs9M24LX/iAl1Hq//zaaFnqjpmV/at6ezoYv8ojN4kEB7eLlvl9+B1EGvGlVlq8vQoRUvIpFIjGBMpPk821xIZviMtIr9pioKvTEpBxxIh4P/bfRv27ZYUfRUH/k+PZYyTcM8jTFkDTa1DGUtkPB6lPojd5P18dD8HIZRZUnHOoo8r6H5cUF4IS1LceTMynYbw3EE2Z05naE3qdr4asjR2M4bNBcT4FNhxyayxFm2mgr0OjjQVXr2hJtEDTQNq/WrLya/ot/xnhqaHtYtqA3NfWWcslY+hF3TvxvLtrgxLN9Z/xCCPEdKXIg3ahBHV4mLoCL/Ac1e49rkxaWB1DClT56slaKrFhr4oz+y WwbTwmfn zweo7MDeOmowyrkiu/RbiVDKbXVieJZpjN+FxMpcUj2v18YIRWjEUY9eYYzer7MrPQAMLFMVGdCL3K/V6KOQ+wRSJS9kr6bgSkOoa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Please ignore this patch because I forgot to use checkpatch.pl to check for f= ormatting issues. I will fix it and resend a new one,Sorry to bother you. > On Feb 28, 2024, at 19:33, Hao Ge wrote: >=20 > =EF=BB=BFCurrent cat /sys/kernel/debug/extfrag/extfrag_index and > /sys/kernel/debug/extfrag/unusable_index is not friendly to userspace. >=20 > We should add order's information so that users can clearly understand > the situation of each order at a glance like pagetypeinfo. >=20 > befor: > cat /sys/kernel/debug/extfrag/extfrag_index: > Node 0, zone DMA32 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... > Node 0, zone Normal -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... >=20 > cat /sys/kernel/debug/extfrag/unusable_index: > Node 0, zone DMA32 0.000 0.000 0.000 0.000 0.001 0.003 0.007 ... > Node 0, zone Normal 0.000 0.053 0.106 0.159 0.205 0.244 0.265 ... >=20 > after: > cat /sys/kernel/debug/extfrag/extfrag_index: > Extfrag index at order: 0 1 2 3 4 5 ... > Node 0, zone DMA -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... > Node 0, zone Normal -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... >=20 > cat /sys/kernel/debug/extfrag/unusable_index: > Unusable index at order: 0 1 2 3 4 5 ... > Node 0, zone DMA 0.000 0.030 0.059 0.085 0.096 0.102 ... > Node 0, zone Normal 0.000 0.225 0.427 0.569 0.776 0.827 ... >=20 > Signed-off-by: Hao Ge > --- > mm/vmstat.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) >=20 > diff --git a/mm/vmstat.c b/mm/vmstat.c > index db79935e4a54..f604d91e904c 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -2178,7 +2178,7 @@ static void unusable_show_print(struct seq_file *m, > int index; > struct contig_page_info info; >=20 > - seq_printf(m, "Node %d, zone %8s ", > + seq_printf(m, "Node %d, zone %11s ", > pgdat->node_id, > zone->name); > for (order =3D 0; order < NR_PAGE_ORDERS; ++order) { > @@ -2201,12 +2201,19 @@ static void unusable_show_print(struct seq_file *m= , > */ > static int unusable_show(struct seq_file *m, void *arg) > { > + int order; > pg_data_t *pgdat =3D (pg_data_t *)arg; >=20 > /* check memoryless node */ > if (!node_state(pgdat->node_id, N_MEMORY)) > return 0; >=20 > + /* Print header */ > + seq_printf(m, "%s ", "Unusable index at order:"); > + for (order =3D 0; order < NR_PAGE_ORDERS; ++order) > + seq_printf(m, "%5d ", order); > + seq_putc(m, '\n'); > + > walk_zones_in_node(m, pgdat, true, false, unusable_show_print); >=20 > return 0; > @@ -2230,7 +2237,7 @@ static void extfrag_show_print(struct seq_file *m, > /* Alloc on stack as interrupts are disabled for zone walk */ > struct contig_page_info info; >=20 > - seq_printf(m, "Node %d, zone %8s ", > + seq_printf(m, "Node %d, zone %10s ", > pgdat->node_id, > zone->name); > for (order =3D 0; order < NR_PAGE_ORDERS; ++order) { > @@ -2247,8 +2254,15 @@ static void extfrag_show_print(struct seq_file *m, > */ > static int extfrag_show(struct seq_file *m, void *arg) > { > + int order; > pg_data_t *pgdat =3D (pg_data_t *)arg; >=20 > + /* Print header */ > + seq_printf(m, "%s ", "Extfrag index at order:"); > + for (order =3D 0; order < NR_PAGE_ORDERS; ++order) > + seq_printf(m, "%6d ", order); > + seq_putc(m, '\n'); > + > walk_zones_in_node(m, pgdat, true, false, extfrag_show_print); >=20 > return 0; > --=20 > 2.25.1