From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH] pagewalk: don't pte_unmap(NULL) in walk_pte_range() References: <47FC95AD.1070907@tiscali.nl> Date: Wed, 09 Apr 2008 15:30:30 +0200 In-Reply-To: <47FC95AD.1070907@tiscali.nl> (Roel Kluin's message of "Wed, 09 Apr 2008 12:08:45 +0200") Message-ID: <87zls3qhop.fsf@saeurebad.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org Return-Path: To: Roel Kluin <12o3l@tiscali.nl> Cc: linux-mm@kvack.org, lkml List-ID: Hi, Roel Kluin <12o3l@tiscali.nl> writes: > This is right isn't it? > --- > Don't pte_unmap a NULL pointer, but the previous. Which NULL pointer? > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> > --- > diff --git a/mm/pagewalk.c b/mm/pagewalk.c > index 1cf1417..6615f0b 100644 > --- a/mm/pagewalk.c > +++ b/mm/pagewalk.c > @@ -15,7 +15,7 @@ static int walk_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > break; > } while (pte++, addr += PAGE_SIZE, addr != end); > > - pte_unmap(pte); > + pte_unmap(pte - 1); > return err; > } This does not make any sense to me. Hannes -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org