From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A372EC433EF for ; Tue, 12 Jul 2022 00:59:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E962A6B009D; Mon, 11 Jul 2022 20:59:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E43C7940010; Mon, 11 Jul 2022 20:59:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D329E6B009F; Mon, 11 Jul 2022 20:59:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C0F236B009D for ; Mon, 11 Jul 2022 20:59:20 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 8D81E80405 for ; Tue, 12 Jul 2022 00:59:20 +0000 (UTC) X-FDA: 79676639280.02.4A92264 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf06.hostedemail.com (Postfix) with ESMTP id E01B4180024 for ; Tue, 12 Jul 2022 00:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657587560; x=1689123560; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=fG91vXyd24Ic0YiHkKexFzSUOf3x6QD+anlpijtsSlc=; b=ge3uSRbVn4iNDaWtyWT2ks7VD+/OAsJuJTKSx7OI+Ufd53EYCTZBD1Og WOowkYanefLaaYMI16kw9LsKeM/Rz3c0WI9X6k6vKQ/SwiHB9d+De/3Gw Pjv9aDqOuRpVt16sxR+wTtutYBaQfSbWZwzrrntMKV3w17wDwB6CiNsRb pgWLa6PWtCsTgvfQaW4u86RWzpFlfNNwl/8ltlZ90EkMJBgO6LjC3uWO4 ubtSl7/2tbX22UXZ9ZLMIllIkxX1PJ2Ic8S+v8YVNoYJp9w8GQJOFntVe VLd6lv1vRWHhCQyl3O1avPwjy08N3hGLiGYZcf/nQRnBBcrqUwQt4Ed+q g==; X-IronPort-AV: E=McAfee;i="6400,9594,10405"; a="348785764" X-IronPort-AV: E=Sophos;i="5.92,264,1650956400"; d="scan'208";a="348785764" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 17:59:18 -0700 X-IronPort-AV: E=Sophos;i="5.92,264,1650956400"; d="scan'208";a="569991996" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.94]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 17:59:16 -0700 From: "Huang, Ying" To: Oscar Salvador Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zi Yan , Yang Shi Subject: Re: [PATCH -V2 1/7] migrate: fix syscall move_pages() return value for failure In-Reply-To: (Oscar Salvador's message of "Mon, 11 Jul 2022 13:52:34 +0200") References: <20220711084948.274787-1-ying.huang@intel.com> <20220711084948.274787-2-ying.huang@intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Tue, 12 Jul 2022 08:59:12 +0800 Message-ID: <87zghf5eov.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ge3uSRbV; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf06.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657587560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nNy9G1KQ7dbi+crtefrZgsKT5XCwhnNRA6QvWXAOvt4=; b=u/EX/AIOW8bHJZ38q64j/l9ckMcFJUFgVbrfbgOo8fLhIyyRfA8se1OZszUVQ6virS+zFv UNxS7qWr2DZS8rKw6XFQvXqc3dGVa8S7ZKMp4NexVB+w5YhX+GavfvSTI3lruGnX6DFJri WYHeRzQpZ4kRpqo4K59TVi5teFC7YYU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657587560; a=rsa-sha256; cv=none; b=byhFyrav4MvrtoyalC3PCgKeSpjAXn5NfMwE+tQ+iCxkWm02602monf/e4aKADKXq8fNeP PaGa/P0YXVqy46c9yYNoY7DIsxK+zWYmTCIMEFJZUJoaGtJyZZ6k2Z/s19eqwaiTZjizaU /67mH0KXeap061cAq91zbSKOJc0EQvY= X-Stat-Signature: f8wmm6g4zqr4nsh1xdngitpy1eiqzy4r X-Rspamd-Queue-Id: E01B4180024 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ge3uSRbV; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf06.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=ying.huang@intel.com X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1657587559-597909 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Oscar Salvador writes: > On Mon, Jul 11, 2022 at 04:49:42PM +0800, Huang Ying wrote: >> return store_status(status, start, node, i - start); >> @@ -1768,8 +1768,12 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> >> err = move_pages_and_store_status(mm, current_node, &pagelist, >> status, start, i, nr_pages); >> - if (err) >> + if (err) { >> + /* We have stored status of page i */ > > IMHO, "We have accounted for page i" gives a more clear statement. Sure. Will change this. > Reviewed-by: Oscar Salvador Thanks! Best Regards, Huang, Ying >> + if (err > 0) >> + err--; >> goto out; >> + } >> current_node = NUMA_NO_NODE; >> } >> out_flush: >> -- >> 2.30.2 >> >>