From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45343C6FD1C for ; Thu, 23 Mar 2023 01:54:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90C596B0075; Wed, 22 Mar 2023 21:54:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BC636B0078; Wed, 22 Mar 2023 21:54:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AB0E6B007B; Wed, 22 Mar 2023 21:54:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 676BB6B0075 for ; Wed, 22 Mar 2023 21:54:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BDD0F1C5D85 for ; Thu, 23 Mar 2023 01:54:35 +0000 (UTC) X-FDA: 80598493710.18.8441D56 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf27.hostedemail.com (Postfix) with ESMTP id 873364000A for ; Thu, 23 Mar 2023 01:54:32 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="TbMHY/Pq"; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679536472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=67ZmEesRIp68q4h1/fO7I9QkviUhR17FEi/A7TaygJY=; b=ePd6Fb9af3vBQWX7Rqo8f5HwqFBazB9wBXMdz+fzka9slBT3F6oWJfy+mXMNUkTPdT3dMP yEOAvG1Xec+l0YTqrwpIx5amsqTCPo2MJOxCvHV5JJ0Qx6ulVDJN5UgWe1+Mw0vRTNEzxo AiIPEPvJ7iQU0pTWfZzhkHdtaLWkOzk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="TbMHY/Pq"; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679536472; a=rsa-sha256; cv=none; b=z2I4/Onb1omNxYUzWTzXtjHDrmJgeaFRfuwpnMvFjFgC9X/fveTFRvewKdn3eH2q9blezr lh8hI7b5YqRSd4KbZKqypy6oXQZGFV75yWORUxXmqIt5qd0MgQnPlHWi58+7bh8gpYOS5j uF3itrzHC7m6Z+BEHONbRxwytlhbw+M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679536472; x=1711072472; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=CwS67PYYqH0PatMp8p449KP+I7kSWUyHQOcV0z+jSpk=; b=TbMHY/PqP2eRlOp3bV1RzcBtHyn1CC5CxTAyT58PoEZGlOSOJFNYHs2A 9a73i36C/ToH4ulMxfS4+eFoHUguLK4LL8baf32GknU7rGwDa8ZO5b8OE 48bDhithxyrhAxk2XPfOYKAR7SJFCstaJaH7YcRdDoQZ4QBzL0PnJblzd Y0BA2X+uemQqLsUc7cumHPCey0AGkW7FfGhNG8/0aLf9r/bYdhzG4JZ5h kNt+DcB9/NTnntE8h42iJ/0XUZzz1gLQIiREF0+dGaPUCvnc0F2k5yK3L I7kdIbKy1rDbNbcZDm4rie7cel9nM8M8+jiMx/wTlp8ijYtCIM/EEbyCv g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="339410411" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="339410411" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 18:54:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="714618278" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="714618278" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 18:54:25 -0700 From: "Huang, Ying" To: "Liu, Yujie" Cc: lkp , "bharata@amd.com" , "Yin, Fengwei" , "willy@infradead.org" , "mike.kravetz@oracle.com" , "shy828301@gmail.com" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "xhao@linux.alibaba.com" , "Tang, Feng" , "linux-mm@kvack.org" , "oe-lkp@lists.linux.dev" , "ziy@nvidia.com" , "zhengjun.xing@linux.intel.com" , "osalvador@suse.de" , "baolin.wang@linux.alibaba.com" , "minchan@kernel.org" , "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>, "apopple@nvidia.com" Subject: Re: [linus:master] [migrate_pages] 7e12beb8ca: vm-scalability.throughput -3.4% regression References: <202303192325.ecbaf968-yujie.liu@intel.com> <87o7onua4t.fsf@yhuang6-desk2.ccr.corp.intel.com> <87h6ueu0ae.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Thu, 23 Mar 2023 09:53:23 +0800 In-Reply-To: (Yujie Liu's message of "Wed, 22 Mar 2023 13:17:54 +0800") Message-ID: <87zg84s06k.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 873364000A X-Stat-Signature: 7r6zuhdycaktw3tqne9ujyf3kat4ipgm X-HE-Tag: 1679536472-307304 X-HE-Meta: U2FsdGVkX1/Is3/ays1RUG7nP0YiG3Pyv6dW9a/pAdK1qHCXESublS+hPdN4m4qJDYcsRXocDaIoMeFJy+BOuDI31KT0T3wynZ+tfwXFOH1qGpR8BhNV4qaR82MBNoJwJl/iMcM+wpCwUW9lCzbpcItetDFmcO5+77Z023/WZ7jqS2pZs8xxKTipxooAhTrGy6TyVf4aK9wmXe5aXqtHbjYL1A9QihhSO1wKTrLTSR6wQGWJZVVzCBAvqaIM47YzTesCFihB0kqpxhgF44nMTHvrtL7UCy+wp4cJazx7WuUyImLWyZedVVaYLA8ZQctago1O+resEIriNcW4SX47VU0keiVKx7Y5/z/kpOiQXA0QXiFHZtkTA41AKGZ+tc/Bb8MM11kukx172LXbvaSg0N4tu6yqu2d13gqLnI5FoBzTuSBnVEVGsRDViAkCC+zUptzz++HUbCbqeCVr5kdsIJfcf2XfXkUuyUOoKiPl+sIiSzgOzPPEIxk1SfE3PIUNDMY3M+mZ9YLgyB5qxYt4mirFYXuz3PnnBSjytFe/HSCTiblekq8nlJnUWW2Bu63mkeDkCe9wg5rsxCYS9KXuHiI16IORADbjat7j9s7U0aDfZKsB6d+9aCkTFYDYekoBI4H7Te05VF75mnn1s0i1plGddBZ0pMLSqnkdDS7UOX/BI19UWJ3UAc0PIx7t2kZ806sVwrBaxeD1ry4b0wTRqnxKIc7KkFaYJPbqwR5E/k2wgbvQZLFet6sqPXwTZzi/22UV4o5S7LJ2c5FTjlxMRCIC1PujPFbJAZVTY+itYda9d8/pI6TtXzDnBA7WLTDsuMJU3SJ1dIo9JwfryJ1m++bgVkC8os7l3lcrmp5KY1KntvYeFvvjUMdLUitfNLw2vNeTTurdmPw2mZVCEi3Fw4u4qCmKq6tCiDmZ+QdlUzkAcSIe89frQi9r79RZiqtNSkmq8pAOk+83jRllNsO kY1ydb0V rlR0KsyNJQHzBCN5J1mqpLx+I1TLDQ+UJ0zZX3DFejto35VlhaUxrtaOpZjZmycXT/9AiPqqExpGLQUmNSYZWDGkSH1AWzNwuyOdZecBVAdVRTuwpuh5JlhWwfnyACiIV4yEFeT1VWPqplK+r5U2KPE5C5iymZ4AlKOSaqykHXRHH0LaZQTKbCZeFAaZ3lVEzQ5LU9fVmHIUEvYupRN1eZTOZXPEHJHw998s7QfffDSHigKRiPsYJR4vay1bf9umtApYN+fkvVk4HOybgRrPDT+7UJJhMM7Fiq3WfhlmG7aVQivk/JD1DN75gMrvCeY/bDSjMHQbSyFW5FCf4G0rUcQb+32OmHV8hJh1WBzihB/dFeVsx2XZDPcBnwmPufLZVaz7PgkinQjpx0GSKB2RuJN5zPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Liu, Yujie" writes: > On Tue, 2023-03-21 at 13:43 +0800, Huang, Ying wrote: >> "Liu, Yujie" writes: >> >> > Hi Ying, >> > >> > On Mon, 2023-03-20 at 15:58 +0800, Huang, Ying wrote: >> > > Hi, Yujie, >> > > >> > > kernel test robot writes: >> > > >> > > > Hello, >> > > > >> > > > FYI, we noticed a -3.4% regression of vm-scalability.throughput du= e to commit: >> > > > >> > > > commit: 7e12beb8ca2ac98b2ec42e0ea4b76cdc93b58654 ("migrate_pages: = batch flushing TLB") >> > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git ma= ster >> > > > >> > > > in testcase: vm-scalability >> > > > on test machine: 96 threads 2 sockets Intel(R) Xeon(R) Platinum 82= 60L CPU @ 2.40GHz (Cascade Lake) with 128G memory >> > > > with following parameters: >> > > > >> > > > runtime: 300s >> > > > size: 512G >> > > > test: anon-cow-rand-mt >> > > > cpufreq_governor: performance >> > > > >> > > > test-description: The motivation behind this suite is to exercise = functions and regions of the mm/ of the Linux kernel which are of interest = to us. >> > > > test-url: https://git.kernel.org/cgit/linux/kernel/git/wfg/vm-scal= ability.git/ >> > > > >> > > > >> > > > If you fix the issue, kindly add following tag >> > > > > Reported-by: kernel test robot >> > > > > Link: https://lore.kernel.org/oe-lkp/202303192325.ecbaf968-yujie= .liu@intel.com >> > > > >> > > >> > > Thanks a lot for report! Can you try whether the debug patch as >> > > below can restore the regression? >> > >> > We've tested the patch and found the throughput score was partially >> > restored from -3.6% to -1.4%, still with a slight performance drop. >> > Please check the detailed data as follows: >> >> Good! Thanks for your detailed data! >> >> > 0.09 =C2=B1 17% +1.2 1.32 =C2=B1 7% +0.4 = 0.45 =C2=B1 21% perf-profile.children.cycles-pp.flush_tlb_func >> >> It appears that we can reduce the unnecessary TLB flushing effectively >> with the previous debug patch. But the batched flush (full flush) is >> still slower than the non-batched flush (flush one page). >> >> Can you try the debug patch as below to check whether it can restore the >> regression completely? The new debug patch can be applied on top of the >> previous debug patch. > > The second debug patch got a -0.7% performance change. The data have > some fluctuations from test to test, and the standard deviation is even > a bit larger than 0.7%, which make the performance score not very > convincing. Please check other metrics to see if the regression is > fully restored. Thanks. Thanks for testing! > 0.09 =C2=B1 17% +0.4 0.45 =C2=B1 21% +0.0 0= .09 =C2=B1 12% perf-profile.children.cycles-pp.flush_tlb_func >From the profiling data, the TLB flushing overhead has been restored. So I think the remaining 0.7% regression should be at noise level. I will prepare the fixing patch based on the test results. Best Regards, Huang, Ying