From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF08C0015E for ; Wed, 9 Aug 2023 22:38:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C73A6B0071; Wed, 9 Aug 2023 18:38:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 550236B0074; Wed, 9 Aug 2023 18:38:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37B918E0001; Wed, 9 Aug 2023 18:38:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 244D66B0071 for ; Wed, 9 Aug 2023 18:38:05 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC89BA01A0 for ; Wed, 9 Aug 2023 22:38:04 +0000 (UTC) X-FDA: 81106030488.10.4F0B5EE Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by imf30.hostedemail.com (Postfix) with ESMTP id 64CC88000B for ; Wed, 9 Aug 2023 22:38:02 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691620683; a=rsa-sha256; cv=none; b=AYvx6dmnwbnl4wWg6qDbN+UlUVsgalSqE20TpxeEPnNdkE9C3g0I6Kz0TXlb9YX7wubCjy NnzzOY/a8A+dsfRGUREIdsUz3YAMZOT8FM7XN8sVU1VtHMJFk10urt4YBphKUQWZ0I9vo2 Xl1MEXtuLJo0ug95TuKNcyOy51K1LyM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691620683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ovuvpedYs8CKe3qhKMxCTCGimclCaGee+vWi+r458UE=; b=AW0/8tTn8aeDzPZmYxaOjUodqvNRAOr8bEHuII3JpRv8t8H4b1+6FpUhl9ZHmHwASUTW3t Bg+c0peSb2PQFvGgWpiadMBye6uOvUWJ8T5CSFWo5XGs0JtpgD6oFHMbh+WoU9+jS1fNkq REm1tthpjZjYs4R+1CDT5TQ+c7Z57N8= Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 3CD87205DB98; Thu, 10 Aug 2023 07:38:00 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 379Mbwf6230731 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 07:38:00 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 379MbwGI248785 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 07:37:58 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.17.2/8.17.2/Submit) id 379MbqTh248778; Thu, 10 Aug 2023 07:37:52 +0900 From: OGAWA Hirofumi To: Jeff Layton Cc: Frank Sorenson , Jan Kara , Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp In-Reply-To: (Jeff Layton's message of "Wed, 09 Aug 2023 18:07:29 -0400") References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> <87msz08vc7.fsf@mail.parknet.co.jp> <52bead1d6a33fec89944b96e2ec20d1ea8747a9a.camel@kernel.org> <878rak8hia.fsf@mail.parknet.co.jp> <20230809150041.452w7gucjmvjnvbg@quack3> <87v8do6y8q.fsf@mail.parknet.co.jp> <2cb998ff14ace352a9dd553e82cfa0aa92ec09ce.camel@kernel.org> <87leek6rh1.fsf@mail.parknet.co.jp> <87h6p86p9z.fsf@mail.parknet.co.jp> <87a5v06kij.fsf@mail.parknet.co.jp> Date: Thu, 10 Aug 2023 07:37:52 +0900 Message-ID: <87zg2z3kqn.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 64CC88000B X-Stat-Signature: sr9yja9fipwf4y36gf8ncmhayceu7bxi X-Rspam-User: X-HE-Tag: 1691620682-345220 X-HE-Meta: U2FsdGVkX1+LGijgikux/0L5TflcNr8rT7pWjOsEGYfMTYo+nWxShXqYIPJ6JlgVM5Miw6DSruz+mJw/IjWCMkFgjHtejdgZIHeS8nvk/i1mIeM+Jv+5ZDqOl59ObTAMoujdsI4w0YkhnPpUt35xCGp6KdAJ+zlmVY1ZMziZ2E6qaBUphUwevzKEAm6Fe+1KRcOvF9oHgmf4WT+qT4aIK6YFEuxlFLGX25xML0PBdL6wglkkdJqjB4lm1r/Q/5fPDes/ES6k1/t2a+Xm+I4vejpmh+LFuO0K7Kk/+klZnZBsXXxRt5aAbn20+ij5ycrwjv6cVvRgmo6Jvxrle8k+yq7YcXlp1gAZVLztVaZoZZ1Q9mHP5bMbaJHXGOTWyIGb1IStwC3w3dH2A81EkiPncYjs+lpfMTFn1pgGKQ1sx7sfPIGdhU0qAPtLiD5pgF7fsoZuA+ViiIlDfQdleh+dX/Qn0jfdFtgfE0F0SvwEY4xHv+DRr7p2kmYn77c5vyDle61/Y+81YB96gAtWZJz17fs7PDy6tcEfLRO3EO0gV+J1YKZB/nKCa6+zpnyYKJolbKCsNNtNa7+Xp8x9lYhtSusfjX0JjlNKO8UvHkSKgRxChFFWZnm96WqTR9+aQILq0ZHGm+ZTbEHSRFZdJ72nKtLY4lemxDAqTVQsUwO0Q1SA8F/f21wSSLaQDJb7ngeM/BOpZ9I7zF+0wJdndITRlsyNZeSo6Qu9Yg9KQICRAxA2ubrh5Jrr6tZGWDuMdiyLs5kYYgZGM6dSuJ/Qs3x6MKLyhxP5Sy5KQtaWIDOAP8uWcnnQMfkUZv6xY/bfDMTFFpXDUTQk4dVvTe8awmMaXX5sayNYGLsN+QwSmsGJYNiSS7E9vxjn6Bkh4MlGwceCtQD3zRSvA5fVAx2bR0/wVDHhj5o2bTc2E49h+45BWFTv24zYqlL+NL7FEq3l394heogS1rGOZCcxH+6SraK vIOiNlOD wyac1TGHGv+qDeqwBtNTVDcYblYkYARqfpYnCdnGWF/PEGY8DauFXbxP8t67qAL3WB9ALlaTkgrMzcenDwatoak0IZuuQpbNr2eczC6CWq4Mu9/D6oJo6QiK+V7hf8tdn+Vgbrq+aeLERlhjp4wLUIpox55GXPqmENA0I126XKeVc+swOHGAGHgDOraGyOa07Bc6dQZAemuI/O61kokxWiYE7uVVHcUsmDGqqE8X9az7vAWykoDt/WdEIVDM0+3ORlX0hMpEwx0nkaH30dPRGdiA/7BDpE/kkf2NWMJ7gKzPt+DU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jeff Layton writes: > If you do that then the i_version counter would never be incremented. > But...I think I see what you're getting at. > > Most filesystems that support the i_version counter have an on-disk > field for it. FAT obviously has no such thing. I suspect the i_version > bits in fat_update_time were added by mistake. FAT doesn't set > SB_I_VERSION so there's no need to do anything to the i_version field at > all. > > Also, given that the mtime and ctime are always kept in sync on FAT, > we're probably fine to have it look something like this: Yes. IIRC, when I wrote, I decided to make it keep similar with generic function, instead of heavily customize for FAT (for maintenance reason). It is why. There would be other places with same reason. E.g. LAZYTIME check is same reason too. (current FAT doesn't support it) So I personally I would prefer to leave it. But if you want to remove it, it would be ok too. Thanks. > --------------------8<------------------ > int fat_update_time(struct inode *inode, int flags) > { > int dirty_flags = 0; > > if (inode->i_ino == MSDOS_ROOT_INO) > return 0; > > fat_truncate_time(inode, NULL, flags); > if (inode->i_sb->s_flags & SB_LAZYTIME) > dirty_flags |= I_DIRTY_TIME; > else > dirty_flags |= I_DIRTY_SYNC; > > __mark_inode_dirty(inode, dirty_flags); > return 0; > } > --------------------8<------------------ > > ...and we should probably do that in a separate patch in advance of the > update_time rework, since it's really a different change. > > If you're in agreement, then I'll plan to respin the series with this > fixed and resend. > > Thanks for being patient! -- OGAWA Hirofumi