From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795DBCD4939 for ; Thu, 21 Sep 2023 00:14:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9D716B01F3; Wed, 20 Sep 2023 20:14:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D26606B01F4; Wed, 20 Sep 2023 20:14:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEDBE6B01F5; Wed, 20 Sep 2023 20:14:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ABDB86B01F3 for ; Wed, 20 Sep 2023 20:14:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 79E0C140723 for ; Thu, 21 Sep 2023 00:14:07 +0000 (UTC) X-FDA: 81258682134.27.38A1B4E Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf30.hostedemail.com (Postfix) with ESMTP id D09A98001F for ; Thu, 21 Sep 2023 00:14:05 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=tHO1OaQe; dkim=pass header.d=linutronix.de header.s=2020e header.b=sDL1m0zP; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf30.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695255246; a=rsa-sha256; cv=none; b=r0gbpXoZX+cXF8ILTkgVzWdZbim7zITkZJN0ujiwN/XaJsFFKlaKdze4okkopy+YtYfRAH bY334oDWVLyw6IPRb/t6oS/j8MpFwYasRTb7klDAbW4RYWtkhSHV72EBcZQPRgUEAMUZ2c VodvIgaklmH9KoAc34v6txBQ2PVOwkk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=tHO1OaQe; dkim=pass header.d=linutronix.de header.s=2020e header.b=sDL1m0zP; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf30.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695255246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c9DSzP7neHRBccWt8aHapDvhRUFFBzrivV2rjzJSZDo=; b=YPCo0xTpp6wcgAEULsvhVC3zkjydv76QDOULc2ABjaJiD4PsTojdVmY9i9WfrS6Pw250oy tU1CqXKuohL/9l66kyzq0eZHyZ85GT6RE+rq+gH4ruEXv2+c9nR8haYPW5NZ9Szan9RuLO rkPATZu4EOiwnmT0e8q4tJlhk+ChgLU= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1695255243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c9DSzP7neHRBccWt8aHapDvhRUFFBzrivV2rjzJSZDo=; b=tHO1OaQesFIO/wMvLlRy1LAUR0gMEZ1GFuTP0XC8peC/LIDl9SiC9b7+YhdSkXpeidUIVK mESn0+fGprxWci3yvhrqCTZF25Iob21lEpEvl77YmtS7zmVpINbv2hzTa9QLGVDhXej7pl raR4byT+eIeYxEAeWv03b3SU1etVSqpRwZsPs28U/BsxvkV1yw2vbTzxUYC1KzCuLff7yk CK0eGOucR+gS5tNK4FDK77ENsUOGvsgRFMf0ZLRKD7KiJyK3rQN/05rqUqdlFB98wUfnHy Gu6frw+KqFgX1JRORX8PxOYd2d/0wNEE/CyayJ+0WdhBXxHz9FAMrXFrSzRqWw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1695255243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c9DSzP7neHRBccWt8aHapDvhRUFFBzrivV2rjzJSZDo=; b=sDL1m0zP/i3HEKhonVEuML1piUiwqH1YfgjFtCy5UjMgp8IYHLeTm0gnOQO6DHESbBkr1V HV2+Mu4eUgn+kpCQ== To: Ankur Arora Cc: Linus Torvalds , Peter Zijlstra , Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, rostedt@goodmis.org, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v2 7/9] sched: define TIF_ALLOW_RESCHED In-Reply-To: <875y44va9t.ffs@tglx> References: <20230830184958.2333078-8-ankur.a.arora@oracle.com> <20230908070258.GA19320@noisy.programming.kicks-ass.net> <87zg1v3xxh.fsf@oracle.com> <87edj64rj1.fsf@oracle.com> <87zg1u1h5t.fsf@oracle.com> <20230911150410.GC9098@noisy.programming.kicks-ass.net> <87h6o01w1a.fsf@oracle.com> <20230912082606.GB35261@noisy.programming.kicks-ass.net> <87cyyfxd4k.ffs@tglx> <87led2wdj0.ffs@tglx> <878r90lyai.fsf@oracle.com> <875y44va9t.ffs@tglx> Date: Thu, 21 Sep 2023 02:14:03 +0200 Message-ID: <87zg1gtmb8.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D09A98001F X-Stat-Signature: zh8nguyjnaatgrwoddko9hrza48f1wn3 X-HE-Tag: 1695255245-827508 X-HE-Meta: U2FsdGVkX1+2JFvXjZ7EbXIuaQpzbm9El69RznKpaRyf5861e+Ldu3X6OMgrHQUWvHCdoQ8j6nZTBAewArir2ihaoLEBChMPWZ1gin2LI5sEaEFfpHsZ0dNw2sTJNE7XJ836qTipDcAH8RtBKuhqB4FO4tRNPHWft9QT8a065ReQrsyk2Bye9SxXij0FnFKGYEy+uwgzMZQ5k1pBeiyGyNP/Ai76AY8k3145qqfFpovAzt/GA4QL9Zp3vumfnQYF/SUDk3VC7DhbUcLjQusHcjKUkYoX+TwM8rTzMSFho5OJvjMm616R91EyIbF8h4ZKN0oVx3cst8NnbgxcvLUlDuy/dkdKC0ThOr4FrWABv0vkHw47F/G7FiHpe9rCtWepbaDdyYl/koIwXOeoSTxOj2zggLcjoMEsRbMNS/TxBBEHcpHdGiMmFBQjQdPWe3dt8YdFI+1zD3I839L7AVCgr3mHWpO6VyrReapVWY3yr+QXvSjns+VxnCqApUseZp3Gty2pgI/e4WL0DT7ZFCkzCz86ppcHazPP7KpiJvBkgssZ4ZxFesLQQkmFIXXz1IsC9bwW+vyhUKxCnge+7T6zO5Pc0ExbfD3PanBSIGjcEbpp/L83dqapxz7yS+pQqpS49UyWywsd8NzdXAdHMNqsxPCxrgmd2cAenSvLlTxMfxBz1qZhW/BHaZAyKusGIWd48xoTgzpbnCyeRiYm3mkqG+i33jnVGaKrxwOqPJVmYWtO8iI+N9gjlfjmCdAthLp9mF3zG4dKVyf9dFLAy+Gk8ikSYv4cICaaA3KAA4dhFY4sIDgpHBYSEuCVuf+T0tNi5SVxgSK0+MsvB4I4U4Q4MyvIZkuumUbRc5HNNNc4N4elnd3eOJRw6dOieWDD9OKAQ8nXOySmnY+mctmEj2AvCBW7OFoDCTrUrpwCaO909cr0jnLhqc+p1xgdOLPNvbVQNSyfSkrkQrxTd736asH 7/zI3zFm I5ZPR9aLXBwSOvm7LhCfrrxqcSKapjzjLAkdVavGKZ2HyBPyl8jtiYKZXMLIBVh74g+lgxkpvjplpQ6LqBUJGDK7oxVj4CWfjn0I9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 20 2023 at 22:51, Thomas Gleixner wrote: > On Wed, Sep 20 2023 at 07:22, Ankur Arora wrote: > > The preempt count folding is an optimization which simplifies the > preempt_enable logic: > > if (--preempt_count && need_resched()) > schedule() > to > if (--preempt_count) > schedule() That should be (!(--preempt_count... in both cases of course :)