From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A76C4167B for ; Fri, 1 Dec 2023 20:12:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E2528D0074; Fri, 1 Dec 2023 15:12:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 091C78D0001; Fri, 1 Dec 2023 15:12:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9B238D0074; Fri, 1 Dec 2023 15:12:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DDB918D0001 for ; Fri, 1 Dec 2023 15:12:11 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B55B5C0321 for ; Fri, 1 Dec 2023 20:12:11 +0000 (UTC) X-FDA: 81519346062.15.06E8457 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf20.hostedemail.com (Postfix) with ESMTP id A380F1C0017 for ; Fri, 1 Dec 2023 20:12:09 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=NuYZmYrX; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=1Lo6RGkK; dmarc=none; spf=pass (imf20.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.25 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701461529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uNlaI4JCStz3sD0HE7ynUAiBzfHPAB12FHeYeu2w9c0=; b=KQzSEqt2BFwV4Ugbr5GFS5deybA5bkDAuu45ezCSg81l/Xp1e6cVaPvVPFh9Z/UROraGU0 O4N1C0roJxmpigWUQzYGoPTq3nTw+Vdq1/2/FfsoWlbBVlww1i752IVOrw149ZgNLp+dyr qttRT8JxhheAziZSm/i1k+BhtaLVmkc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=NuYZmYrX; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=1Lo6RGkK; dmarc=none; spf=pass (imf20.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.25 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701461529; a=rsa-sha256; cv=none; b=1emMDN26nry9+NjxSiS/sYO5mCrdNP27lkDD47POeNrB2OOBpgkYysVeYv6gxkFIUNn1is v//beGgV+mXxvcTcYXdic27C+MXJMti5HPL+YcNo3jAWqhfm7X4eOarz7I2KnUSeAcpSy5 H6qvQat98LOxtt8bdiRhDytjbI/NhGk= Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 478415C00A7; Fri, 1 Dec 2023 15:12:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 01 Dec 2023 15:12:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1701461527; x=1701547927; bh=uNlaI4JCStz3sD0HE7ynUAiBzfHPAB12FHe Yeu2w9c0=; b=NuYZmYrXpcacbHuvsjavqq+v9JcyFV2PVg5AUwyY3wuER7TXlp9 AWPstw4Bw0C4iGcL5sEb9ulOz4iY6bVt1/ZaNStYI0JfSwGfm6K5tDVIBZJyDl2l myWaG3u6ikGZUgyc+LzPAg+mCaDBuWmit3IXOtBRtDrR7UrbPf7N59HT8lRIJ/54 Jot4TjyCWSH7V78fm+dL3bNLjd+ul1xPXhVnJqHkoCBuaU+0kr2rmGX6kyyzm3y7 YrHxJz220Tz2Sh0YquPyeEK+p92C+CmmPdckNeEAZQnb4ouIy8exNdv8HAkBifCO 9i3nIYCXrUNOgXM+GD5s8vBWlekg6rAd3BA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701461527; x=1701547927; bh=uNlaI4JCStz3sD0HE7ynUAiBzfHPAB12FHe Yeu2w9c0=; b=1Lo6RGkKTpIYetcCyH6NSbU8YdLH2mw2LY9a0l+0XHtFVO4pfZA AB9dmGD1yJC6trfPwSYhA0MdSTHvWAzZlpi3nXD8yHoisv6TLVmE47uczvIshlag Ak7E3IB8rO1bP6dSbkgNjDKtUgHuB9YGvm5U1leQvMv3qbH9vQVJOqQkvj8Owg9l F/YD6FWC5k2otAQm/cGdkbWM1/l0dm+Ft7+nKmvVZnpq6qNodwZlw+9afMcduBOo z/vY+MKcNrej92XtQA1L820HxA/tlC/7JZchtmPye/OKp5RV0HoXmpy1/A7JHOru tupieMVWaUdT1jGiBMXRDikpQiVgbaQzc4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiledgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepufht vghfrghnucftohgvshgthhcuoehshhhrseguvghvkhgvrhhnvghlrdhioheqnecuggftrf grthhtvghrnhepfedtjefhheeileevhfehheeutdekleduueejteffvddtfedtfffhleek geekgfdunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghdpghhithhhuhgsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhhrhes uggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Dec 2023 15:12:04 -0500 (EST) References: <20231127174517.2369593-1-shr@devkernel.io> <20231128074626.GA298624@pevik> <20231128165132.GA406520@pevik> <20231129101010.GA535399@pevik> User-agent: mu4e 1.10.3; emacs 29.1 From: Stefan Roesch To: Petr Vorel Cc: Li Wang , kernel-team@fb.com, linux-mm@kvack.org, david@redhat.com, oliver.sang@intel.com, ltp@lists.linux.it Subject: Re: [LTP] [PATCH v1] mem: disable KSM smart scan for ksm tests Date: Fri, 01 Dec 2023 12:11:38 -0800 In-reply-to: <20231129101010.GA535399@pevik> Message-ID: <87zfyt4r8t.fsf@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A380F1C0017 X-Stat-Signature: y9nw1p39n6becib6ix6aegwhmgycr5gi X-HE-Tag: 1701461529-793496 X-HE-Meta: U2FsdGVkX19TH2Zj5fbiLXO2jOgd3Vsqz01H2N0YhKZhovnH0tBg0OYAM0cuM6FQg1JhE36bUCM6Y5+5CPE20pSlVjWXRjp2HtNASblEBCvd4cmjn+MkTEKMheutAu1An99gbEPYdrFBEmFXM292Ix/dbJuPhDVRhERuCd9JF8zfntd2mjWd9+rYTijDHa77vvgwNB3f2o6bmbgbn7JKFe1H4BXlNfz9vkxZ3K+s0aaX6J4/NlEHy+y0W8FuGMaTxZlK5+aW3QG1uUgNly36u3t32kfB+GNGTeBQ8F7tCoUK+nbFfuTZVJpXHF2tjH6PSrKhOST+qPglPp8smQqOGgSYENO6FeUc5TbzL9DTydnPXqUQhTontXLjgUygVXabcrPXBb+F9bqp5KopBUEbdtC+cshlBZ3zrOUfz7VDgEGQNflaF5d182t1RYfR9/OBaxGQhcU/t5fVgiHy66wF5louVyjeiuVuqWO3tCXYkgyLp1kiMNPQ4+6HU3kBpSZabdy3fwqYkABhbAWul1bGUPIrnj/1oK67m5WfRLFF/m+kUgyXROxr4Khb4XzU2rhJ70FJFORM6hJ2mQHRg7ghSdCTJ4PXM6Yv4or7RlUXIPSOMqzXjXV0/tMoKwhnHfxZn1EtFPNy7BPmz+XhY6QZc8LautrkJf5smwUN9PnHOfeJuNKb31TN+pa10rbHO5HVaxGIqikhtRBCnDW3/Xu58/v/Sz3YvKQsWtBUraNk7YwzS56m5d+YSxADMDP9XmyWarRKFuCWMpm7uCP7jEQmz3otHi0GF4ypZcCctn62x78HlRy46xLSubVsoq1nGh9ak04Uh9BTDFVexIrmVWRBOGjpQ7psBapYTCB+4hGOzXyDifC7L8E7hEUNpsyDq4hXFEhWRM7jBWq+gtfTeZWtR0G3zKLSk6ss5v7TzC15jLMydVkNao58x2quVXTMCe4D0s3j9GgMiEG8pIvDxOS Bi/buLhY zZgzALPAxwSdacEeRxNsh/l6neMR//Okzyx+rjoiuJraUWj2U+YAPzos2vOwtURKa9nYHinhoHBLdqvlz5yqiVmekScJLic068dLwp7dVDHS10TCdE9b7sG0Oxq1NCf/DsWUcEUSfZgVauu0hInm4HG1BK5bn0cJZLd697L9xyb+M23UtqRhK/ElTYdrcBmvDmkT7Bpwf0OmnTkRHzmdwbdNU4OFodZji6nyUTH3sgQsA8jimakBu1VeBxdjLU+XCl3oAld7SnpGcPkwm+8V90w29zHekr8vXtb4OI8i3CdTkp64nLdFCWD1lm9bko7lUOBtG35W0YAanM61gt7Y3BI0KkWjEoK7AZ1HvXRYUbdRCsV4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Petr Vorel writes: >> On Wed, Nov 29, 2023 at 12:51=E2=80=AFAM Petr Vorel wro= te: > >> > Hi Stefan, Li, > >> > > Hi Stefan, Petr, > >> > > On Tue, Nov 28, 2023 at 3:46=E2=80=AFPM Petr Vorel = wrote: > >> > > > Hi Stefan, > >> > > > > This disables the "smart scan" KSM feature to make sure that the >> > volatile >> > > > > count remains at 0. > >> > > > > Signed-off-by: Stefan Roesch >> > > > nit: you forgot 'shr@' >> > > > Signed-off-by: Stefan Roesch > >> > > > > Reported-by: kernel test robot >> > > > > Closes: > >> > https://lore.kernel.org/oe-lkp/202311161132.13d8ce5a-oliver.sang@intel= .com >> > > > > --- >> > > > > testcases/kernel/mem/lib/mem.c | 4 ++++ >> > > > > 1 file changed, 4 insertions(+) > >> > > > > diff --git a/testcases/kernel/mem/lib/mem.c >> > > > b/testcases/kernel/mem/lib/mem.c >> > > > > index fbfeef026..ef274a3ac 100644 >> > > > > --- a/testcases/kernel/mem/lib/mem.c >> > > > > +++ b/testcases/kernel/mem/lib/mem.c >> > > > > @@ -454,6 +454,9 @@ void create_same_memory(int size, int num, i= nt >> > unit) >> > > > > {'a', size*MB}, {'a', size*MB}, {'d', size*MB}, {'d= ', >> > > > size*MB}, >> > > > > }; > >> > > > > + /* Disable smart scan for correct volatile counts. */ >> > > > > + SAFE_FILE_PRINTF(PATH_KSM "smart_scan", "0"); >> > > > NOTE, this fails on the systems without /sys/kernel/mm/ksm/smart_s= can: > >> > > > mem.c:458: TBROK: Failed to open FILE '/sys/kernel/mm/ksm/smart_sc= an' >> > for >> > > > writing: EACCES (13) > >> > > > NOTE, we normally handle the setup like this in test setup functio= n. > >> > > > But new API has .save_restore which is more robust for tasks like >> > this. >> > > > It's already used in ksm01.c, you need just to add this line: >> > > > {"/sys/kernel/mm/ksm/smart_scan", "0", TST_SR_SKIP}, > > >> > > I guess we need to set 'TST_SR_SKIP_MISSING | TST_SR_TBROK_RO' >> > > as the last field. Because TST_SR_SKIP will continue the test without >> > > writing '0' to the smart_scan file, that's not correct if the file >> > exists. >> > > It will >> > > ignore a kernel bug (smart_scan can't be written) by that config. > >> > > Per the Doc Petr pointed below: >> > > TST_SR_SKIP_MISSING =E2=80=93 Continue without saving the file if = it does not >> > > exist >> > > TST_SR_TBROK_RO =E2=80=93 End test with TBROK if the file is read-= only >> > > TST_SR_SKIP_RO =E2=80=93 Continue without saving the file if it is= read-only >> > > TST_SR_SKIP =E2=80=93 Equivalent to 'TST_SR_SKIP_MISSING | TST_SR_= SKIP_RO' > > > >> > > > (instead of both SAFE_FILE_PRINTF) > >> > > > See: > > >> > https://github.com/linux-test-project/ltp/wiki/C-Test-API#127-saving--= restoring-procsys-values > >> > > > I wonder if ksm01.c is the only ksm test which needs to disable th= is. > > >> > > I think all of the ksm0*.c tests should disable it by the config. The >> > > smart_scan >> > > will impact all the tests with invoke key function create_same_memor= y(). > >> > ksm05.c and ksm06.c does not use create_same_memory(). Or did I overlo= ok >> > something? > > >> Good catch, I looked into these tests, seems only ksm05 is debatable >> for disabling smart_scan, as a simple regression, it suggests disabling >> ksm daemon to avoid disturb according to some workload. >> https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/m= em/ksm/ksm05.c#L30 > >> ksm06 is definitely need disable smart_scan, it tests KSM in different >> 'run' state for merge_accros_nodes. > > Thanks for having a look. > >> To be on the safe side, I would suggest applying the patch to all ksm* >> tests, >> and write a new single for smart_scan if needed. > > Agree. I vote for new single for smart_scan related test. > I'll add a new test. > Kind regards, > Petr