From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B121BC48BF6 for ; Tue, 5 Mar 2024 01:56:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D7AA6B0075; Mon, 4 Mar 2024 20:56:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 087036B007B; Mon, 4 Mar 2024 20:56:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6A676B007D; Mon, 4 Mar 2024 20:56:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D2FDB6B0075 for ; Mon, 4 Mar 2024 20:56:20 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 54AF81C0C9E for ; Tue, 5 Mar 2024 01:56:20 +0000 (UTC) X-FDA: 81861320520.21.F97A019 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf18.hostedemail.com (Postfix) with ESMTP id 56E551C0005 for ; Tue, 5 Mar 2024 01:56:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VzuINvmn; spf=pass (imf18.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709603778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=js9YdGBkfRWRjkoiee/wR8PIZMRNvar3YpOaV8Ko8xI=; b=R/IAi0AI9y4xYGfDkiYQnLIHLzqvsQhYyAnVJJXeIFZfnqLP057lfuMsfNMElC5u7gPC2u pwtia2ttwqncmPDcLef8vtLE0QicfRPvUPhoJcAvozoZ3OziKAo5grSYyrWVXvPOVNL/Wk w94haRXrwyjb6S92Nmd2Ui0P33wf2WA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709603778; a=rsa-sha256; cv=none; b=yIn268+lfilyilKmqb9K6NUBJt5M7Cd9hEk1O9SUaMYmq8TMoldiAYnc0h/dX+ES+Jc2HR hPVcsOUFyY6zNmRjuYMJi76J1f8YTzaegDf0S0WN2MkLntuuup14GLA3X+E7qdpy29idtX ztwM6Dvpm28SYzh7CGB9F1qYoGiYePU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VzuINvmn; spf=pass (imf18.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709603777; x=1741139777; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=zt0N50zHKPJXVNvVG81euXstggimzNKVFAU/zxBLFJ8=; b=VzuINvmnVH4hDg9or93u8heC97OC29WhWKyuq3SRcTAEybL3K9/+5tVB hTUZHIl8PRGcMlF8QBRlRuxnh1G+HIxryLdXp9Arl4ui9wpeqbO51+4X7 +ddlTe9m6L9XTzRSAESPu1QVUmzJ3CotstxC6T3BX6nzCfVPxHelZK1C3 l68b+6wKwq56HcVgkqlWzinZSNEWWTQa0ZUPT5WVnm6u8UKNlpVTCGXNg ihpNiK4a4rCuFbNVjgxPGKEJclAQx47MSB9111K9RzVVW/zkQgjzlFfGw mYFQ/LR5A3Q3c0NC0k5wKK4tCcQ3gh5pPAp2zp2kcFonNTPu+GsXr1zsD A==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="14773932" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="14773932" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 17:56:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="9377584" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 17:56:13 -0800 From: "Huang, Ying" To: Byungchul Park Cc: , , , , , Subject: Re: [PATCH v6] mm, vmscan: retry kswapd's priority loop with cache_trim_mode off on failure In-Reply-To: <20240304082118.20499-1-byungchul@sk.com> (Byungchul Park's message of "Mon, 4 Mar 2024 17:21:18 +0900") References: <20240304033611.GD13332@system.software.com> <20240304082118.20499-1-byungchul@sk.com> Date: Tue, 05 Mar 2024 09:54:19 +0800 Message-ID: <87zfvda1f8.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: 79htgxbqo5gzdweokt9fgknktjruc4t8 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 56E551C0005 X-Rspam-User: X-HE-Tag: 1709603777-437415 X-HE-Meta: U2FsdGVkX187rlzu7dOAMa77yPL+YjbKVQRozZi0pZtjyO+YEx6fu+h0GTdR+o16PKFh9id1Qdqf2XiEcEfv2UW3/cb2Zfy4qALFp9mDsKIU/rb4DfNjpXMPuR6scIrYfCx2n94aW4/qX/4zqJDtv29h7SXPgCxnuk2CjwPmb1y406n1oOu+3D5Gap2LXtH5dHdr+79Sk1JjHDruv4HrP67hn2HjFgTRg3xBFxHpYtg/ZNQmypGfbNgTd8vtq86HeqMc2z1DG7U1Moips1XZ6j562BjhoPDngGUeiD3hTGTUiO5RGmzPCEpR9VHgyAB6BD9SY+Ty9CMDMRJDOkNs97yAjdfPWbNxDqKtEiVqPIJWxeStca+K8oz0JGr/yTSWWEC5QUipRCevsTZm+dIGDljw7sxG40zcGWdJxuWj5RiH0/CZtyI29PyCGkkEvc8BiY7jZA69uOL049NUQEHpo5ntBWZ6e31nmTf5IX9WgbHhJeQvdy5k1xxtNsP2FvFdEybvgEkwg8t7O10rnC0RmLbiTsyrCDLWE4TnR1e9kyiBuUekp/QopzsHkqey+mZdq6SmWKJhVOHqutASKSxKhyV2hWl9EXVa5xlGAPXDecmzNiSHgTWdSL0KCORuJjXzaHffxvhcYko0Chg7tBhyzPkVNRpNNs8+2ZNuNfBGnXRERli+ButEuRItiEdh8DpXVvlnR3C+zWIxwn7a+SHAVH49/wzAepqg4rvcN3650vCIPKbo2fUQg5cb8DQgHxNXvMGFJYPw1trBoraWWwbcTF2zUOoQv7A4h8fopVnNnP9+IHJdbS1sGb8/oSpgksn1JY1J/C+0V2c0WSakKu3g+NhW2in+MPynR96EyT8dQYrCJabBz8bsn80xvHZ+kk4ewd8xsHiSzH0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Byungchul Park writes: > Changes from v5: > 1. Make it retry the kswapd's scan priority loop with > cache_trim_mode off *only if* the mode didn't work in the > previous loop. (feedbacked by Huang Ying) > 2. Take into account 'break's from the priority loop when making > the decision whether to retry. (feedbacked by Huang Ying) > 3. Update the test result in the commit message. > > Changes from v4: > 1. Make other scans start with may_cache_trim_mode = 1. > > Changes from v3: > 1. Update the test result in the commit message with v4. > 2. Retry the whole priority loop with cache_trim_mode off again, > rather than forcing the mode off at the highest priority, > when the mode doesn't work. (feedbacked by Johannes Weiner) > > Changes from v2: > 1. Change the condition to stop cache_trim_mode. > > From - Stop it if it's at high scan priorities, 0 or 1. > To - Stop it if it's at high scan priorities, 0 or 1, and > the mode didn't work in the previous turn. > > (feedbacked by Huang Ying) > > 2. Change the test result in the commit message after testing > with the new logic. > > Changes from v1: > 1. Add a comment describing why this change is necessary in code > and rewrite the commit message with how to reproduce and what > the result is using vmstat. (feedbacked by Andrew Morton and > Yu Zhao) > 2. Change the condition to avoid cache_trim_mode from > 'sc->priority != 1' to 'sc->priority > 1' to reflect cases > where the priority goes to zero all the way. (feedbacked by > Yu Zhao) > > --->8--- > From f811ee583158fd53d0e94d32ce5948fac4b17cfe Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Mon, 4 Mar 2024 15:27:37 +0900 > Subject: [PATCH v6] mm, vmscan: retry kswapd's priority loop with cache_trim_mode off on failure > > With cache_trim_mode on, reclaim logic doesn't bother reclaiming anon > pages. However, it should be more careful to use the mode because it's > going to prevent anon pages from being reclaimed even if there are a > huge number of anon pages that are cold and should be reclaimed. Even > worse, that leads kswapd_failures to reach MAX_RECLAIM_RETRIES and > stopping kswapd from functioning until direct reclaim eventually works > to resume kswapd. > > So kswapd needs to retry its scan priority loop with cache_trim_mode > off again if the mode doesn't work for reclaim. > > The problematic behavior can be reproduced by: > > CONFIG_NUMA_BALANCING enabled > sysctl_numa_balancing_mode set to NUMA_BALANCING_MEMORY_TIERING > numa node0 (8GB local memory, 16 CPUs) > numa node1 (8GB slow tier memory, no CPUs) > > Sequence: > > 1) echo 3 > /proc/sys/vm/drop_caches > 2) To emulate the system with full of cold memory in local DRAM, run > the following dummy program and never touch the region: > > mmap(0, 8 * 1024 * 1024 * 1024, PROT_READ | PROT_WRITE, > MAP_ANONYMOUS | MAP_PRIVATE | MAP_POPULATE, -1, 0); > > 3) Run any memory intensive work e.g. XSBench. > 4) Check if numa balancing is working e.i. promotion/demotion. > 5) Iterate 1) ~ 4) until numa balancing stops. > > With this, you could see that promotion/demotion are not working because > kswapd has stopped due to ->kswapd_failures >= MAX_RECLAIM_RETRIES. > > Interesting vmstat delta's differences between before and after are like: > > +-----------------------+-------------------------------+ > | interesting vmstat | before | after | > +-----------------------+-------------------------------+ > | nr_inactive_anon | 321935 | 1664772 | > | nr_active_anon | 1780700 | 437834 | > | nr_inactive_file | 30425 | 40882 | > | nr_active_file | 14961 | 3012 | > | pgpromote_success | 356 | 1293122 | > | pgpromote_candidate | 21953245 | 1824148 | > | pgactivate | 1844523 | 3311907 | > | pgdeactivate | 50634 | 1554069 | > | pgfault | 31100294 | 6518806 | > | pgdemote_kswapd | 30856 | 2230821 | > | pgscan_kswapd | 1861981 | 7667629 | > | pgscan_anon | 1822930 | 7610583 | > | pgscan_file | 39051 | 57046 | > | pgsteal_anon | 386 | 2192033 | > | pgsteal_file | 30470 | 38788 | > | pageoutrun | 30 | 412 | > | numa_hint_faults | 27418279 | 2875955 | > | numa_pages_migrated | 356 | 1293122 | > +-----------------------+-------------------------------+ > > Signed-off-by: Byungchul Park > --- > mm/vmscan.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index bba207f41b14..6fe45eca7766 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -108,6 +108,12 @@ struct scan_control { > /* Can folios be swapped as part of reclaim? */ > unsigned int may_swap:1; > > + /* Not allow cache_trim_mode to be turned on as part of reclaim? */ > + unsigned int no_cache_trim_mode:1; > + > + /* Has cache_trim_mode failed at least once? */ > + unsigned int cache_trim_mode_failed:1; > + > /* Proactive reclaim invoked by userspace through memory.reclaim */ > unsigned int proactive:1; > > @@ -2268,7 +2274,8 @@ static void prepare_scan_control(pg_data_t *pgdat, struct scan_control *sc) > * anonymous pages. > */ > file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE); > - if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE)) > + if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE) && > + !sc->no_cache_trim_mode) > sc->cache_trim_mode = 1; > else > sc->cache_trim_mode = 0; > @@ -5967,6 +5974,8 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) > */ > if (reclaimable) > pgdat->kswapd_failures = 0; > + else if (sc->cache_trim_mode) > + sc->cache_trim_mode_failed = 1; > } > > /* > @@ -6898,6 +6907,16 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx) > sc.priority--; > } while (sc.priority >= 1); > > + /* > + * Restart only if it went through the priority loop all the way, > + * but cache_trim_mode didn't work. > + */ > + if (!sc.nr_reclaimed && sc.priority < 1 && > + !sc.no_cache_trim_mode && sc.cache_trim_mode_failed) { Can we just use sc.cache_trim_mode (instead of sc.cache_trim_mode_failed) here? That is, if cache_trim_mode is enabled for priority == 1 and failed to reclaim, we will restart. If this works, we can avoid to add another flag. > + sc.no_cache_trim_mode = 1; > + goto restart; > + } > + > if (!sc.nr_reclaimed) > pgdat->kswapd_failures++; -- Best Regards, Huang, Ying