From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572AEC25B77 for ; Tue, 21 May 2024 00:48:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADB196B0082; Mon, 20 May 2024 20:48:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A64726B0085; Mon, 20 May 2024 20:48:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 904AB6B008C; Mon, 20 May 2024 20:48:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6EA1A6B0082 for ; Mon, 20 May 2024 20:48:28 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CD3B6A1F6C for ; Tue, 21 May 2024 00:48:27 +0000 (UTC) X-FDA: 82140567054.16.4278484 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf14.hostedemail.com (Postfix) with ESMTP id 84422100005 for ; Tue, 21 May 2024 00:48:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=X5NRwOCp; dmarc=none; spf=pass (imf14.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716252506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YLA3mOlhQu9l5RqU75xfAtJgMMySlJsqBiBjGwoY8Fw=; b=SkvoFN5X6iFLlk/WqMIgpIn0vTkvOPBoXw3xFnNCXqsCrTeuQlr66AFcg7hfGIGpQmK5zn VmNPczGnD8AMSc4N79VJxDxAFtJB7o2eZfEliqcMjJtnPYCEYOTFufViXpsMMlcryo4Ym9 PAFb8mcYGEQk0W4vJFbTx/HtHGvyObo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=X5NRwOCp; dmarc=none; spf=pass (imf14.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716252506; a=rsa-sha256; cv=none; b=SNcFdXyroxNpylUdD9ot4Ol+8YM/83VNKFRfbZEodRuFhIultFU+dGyaj0Y6peW3vH5AAf ev1mIisPyDCuAR4C56wT3SHS/pAjyq9IYvpFFGjoQM59lfy2yOnHmVSCpx0d9t7o7+zXtI Qxn24u/62BjQq/S+KRsLDAQcCXM/n5M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1716252502; bh=YLA3mOlhQu9l5RqU75xfAtJgMMySlJsqBiBjGwoY8Fw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X5NRwOCpFcBotgjRna13dxvT/o7xnf+Qgsg7NLp8c5A5cJz4rwMGdkHkS5s2nEst7 zZS3eFvoplEpepU32h45RjftKksRrdyYsQPgjDhaXdvsS71vnBI/seSpC0RP8Iw32f udgFlZzlIi4FsxYS7hlqq9vKbhVbrLCzvAMIM8s9aYXk162otscAuQcVwFj1uT98WF QUpdduIflhhd+BYm+bfn61BmCMxbgWxFaozRgF5a3NlcAfFJ1GQmPDwmfXMboL94Qg ukh2cf8tz/B4A+ccwPbAIuoNWFg2J2g+ZUwW9SBlGkSh++THJRNvQ2mVP8AZxgLO4J H8Xzu0Nu12FkQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Vjwln66Mgz4wjF; Tue, 21 May 2024 10:48:21 +1000 (AEST) From: Michael Ellerman To: Christophe Leroy , Oscar Salvador Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Nicholas Piggin , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [RFC PATCH v2 06/20] powerpc/8xx: Fix size given to set_huge_pte_at() In-Reply-To: References: <04f4e737608ea0b177b88057db138fbf0d6ab138.1715971869.git.christophe.leroy@csgroup.eu> Date: Tue, 21 May 2024 10:48:21 +1000 Message-ID: <87zfsk2dnu.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 84422100005 X-Stat-Signature: jbkd1sg3t74i7w16uuwm1oxmjt3181ax X-HE-Tag: 1716252505-554655 X-HE-Meta: U2FsdGVkX19oHKx6SukSyHJ5ZsaojBCEx6IO1ctosFDDSBZra8BiCjz390fQmH+l21/0tL/NikaB57q9nSzqB/lK7gONe42ZdqK6dRjqhDFb/MskLikOFz+83W/m4PCQynpLREt6yr7X2URQvdJoVeRkw/PtRhJyrZaeg81oySAJ2bOn4SInbuIcyWPG5FnadS0MJHbsapos6ZvobkSQide5+ZM0KwlJcZJU0I6wTfUhxQgkXWNK2C+fpves3kXmV0AjR0gtAM2Q253yRz+Ic8tlkjRqD7mdgcgbIf4jVt2oRgxUqCQXkqYZcXZXGug9EMMB0Ol+vtKhsdkDT9LeTsts088TcqIFtMLgCb3vsT/jWjYmtPViZeC9ngdocL0h7t2GKz/0uSHKdPNj/dKFU3ZuTOVvYIgJ53o+T9/jT+oxaTKl/SR0/5duq2CAcuGkWpl6KEAuoG7PWvbbWz5L5ZYoWvlEgrN61SYSQQMQM290NAFcGAr4jp5Yy7VFmfB96Dhts/HVZdtKMBUucTgZa5zdubsqzDhHv1LMgkkhd3AI/4GNdICeq4YpX4CqCuBgXE3PdNSfzr7cF8/GqWy60tfmck5QRe4pBXc31n67cna6dyFp0DJKOzGYFgfFtrZxwQNrDwM3EccsAMTAIZZW/xIjR8ELiLLPaHc8gCj+29ZBrWbX1UIctAh5fuL0h6wusyCq/XXEZb0YRIjmVnud+DmIa1HwFqK09ucPrqH2pCe7scBjr3ctNqbK+npvBKUq5mSPOqvx7I99msENGPchc1NCv2o0YYq4uljAKsa47Aho5FGEXeV1F4g9+q0A2q+jXvlhUNWJjIucLnYW3As8dCP26W82zf1UVXvJfSTsxAqS9nuCvVo05IKqMHrL/YZpfG0lihqZAZpjaz/Of6idUsy6isnmZplnVAjwGTW+vfAjGdoBERy0yzvmDaru4AzUsPohANNyYG2ItuX/5WM OmYiiuCI KkTliRdOcGOmhe7S8ZX74GfEvDQQSkxBdfb99/9qlnGFROYesXafIU0Hrivho9J2uqP5002ptr7kmKfKowoaoaZlYr1D3+6nHn3SXiRTsxRsj32jGhxI+rikTmKEoE6oR+pjBwR/3STjcwxsrrHi5TL7KFUGms5UnK+02vg57wU+9D9pd0kdoseKmJUZgRxSFeFukZ0MPz6dwS2XjlAJc0LTGkKsV51RNb+v8YKe94fY6vDq9VeJiZvYCiyt79+ZclSHid5ShRU/DYAXpf66ivLW2qA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Christophe Leroy writes: > Hi Oscar, hi Michael, > > Le 20/05/2024 =C3=A0 11:14, Oscar Salvador a =C3=A9crit=C2=A0: >> On Fri, May 17, 2024 at 09:00:00PM +0200, Christophe Leroy wrote: >>> set_huge_pte_at() expects the real page size, not the psize which is >>=20 >> "expects the size of the huge page" sounds bettter? > > Parameter 'pzize' already provides the size of the hugepage, but not in=20 > the way set_huge_pte_at() expects it. > > psize has one of the values defined by MMU_PAGE_XXX macros defined in=20 > arch/powerpc/include/asm/mmu.h while set_huge_pte_at() expects the size=20 > as a value. > >>=20 >>> the index of the page definition in table mmu_psize_defs[] >>> >>> Fixes: 935d4f0c6dc8 ("mm: hugetlb: add huge page size param to set_huge= _pte_at()") >>> Signed-off-by: Christophe Leroy >>=20 >> Reviewed-by: Oscar Salvador >>=20 >> AFAICS, this fixup is not related to the series, right? (yes, you will >> the parameter later) >> I would have it at the very beginning of the series. > > You are right, I should have submitted it separately. > > Michael can you take it as a fix for 6.10 ? Yeah I can. Does it actually cause a bug at runtime (I assume so)? cheers