From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CF4CFD31D for ; Fri, 11 Oct 2024 10:18:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE86D6B00AB; Fri, 11 Oct 2024 06:18:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A98786B00AD; Fri, 11 Oct 2024 06:18:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9601A6B00B0; Fri, 11 Oct 2024 06:18:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6CA7C6B00AB for ; Fri, 11 Oct 2024 06:18:06 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6B6A1AC8EE for ; Fri, 11 Oct 2024 10:17:57 +0000 (UTC) X-FDA: 82660920888.22.8E6B744 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf02.hostedemail.com (Postfix) with ESMTP id 78FAF80004 for ; Fri, 11 Oct 2024 10:17:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=FN6XZub1; dmarc=none; spf=pass (imf02.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728641840; a=rsa-sha256; cv=none; b=3146wojcf0AE4ydOgxxxmaAvvC9WvXKLKItj5tQtps8/myNRyDlyTepkOcF0jWD9t72+v4 YzmGevtS7TbyWIipofuC31wzcD3f97+bJVY8A+lkVYyRFF+U0zlC7ujAsAscfOJZA12f+d ojMJMM9zOZEym7hh25hJnGmzKgRgXE4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=FN6XZub1; dmarc=none; spf=pass (imf02.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728641839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Aow3TJ3nQrfV5JgcQs4n2GrgOqvsaJyLKOJ0CQrSIuo=; b=VYIn84dSoQfmOB0Td3NiAGrNIppOvswO3ixvztrXFDRdvihSeqVdxJYeSguWm9eylNFNma SPdlQwCQhs51pFttsXYoe7ivk8tmlAFBBIcK4MaOdKAZu5to3ehsbKWMRb6gkuTHTuF/yR cqIwbLRks8bdSx2pQk94wHVHM5hSJ/Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1728641879; bh=Aow3TJ3nQrfV5JgcQs4n2GrgOqvsaJyLKOJ0CQrSIuo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FN6XZub1+7a2gjiGz5Hf+T9MJ4IoX4p03XA5woNlICEXJ0lIeT2ixVvGPGFPX4sTs Afe83MGI5VycnY9lLOLtoaiHTN3V7LG2mNWR5xP/sjqi52g5Cd5NwLTuf0Dze5iAyE Qycm8kM71TNb8POMqtJQ4Qns8nKYmhGKGnBOmhzRhL7FzhbQU/7zNAUT+ENGK4rUkU SVeBZW49JVuJhq4259LD1JuyLUMbr1IKsw/mmP3JjpLn6pKMSUoxzVj22cZgWvWAee qe+u21ow9ReqFx/UQkCDPkmzEOJcicQwbEjhOZh/DK11BXHTLpHrjCH6aHgnCgI8+Z aaPsRBeZOLu2g== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4XQ2d30BPSz4x89; Fri, 11 Oct 2024 21:17:58 +1100 (AEDT) From: Michael Ellerman To: "Ritesh Harjani (IBM)" , linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Sourabh Jain , Hari Bathini , Zi Yan , David Hildenbrand , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Madhavan Srinivasan , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige , "Ritesh Harjani (IBM)" Subject: Re: [RFC v2 0/4] cma: powerpc fadump fixes In-Reply-To: References: Date: Fri, 11 Oct 2024 21:17:57 +1100 Message-ID: <87zfnb54fe.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Queue-Id: 78FAF80004 X-Rspamd-Server: rspam01 X-Stat-Signature: d1nnandauqu7hnbrjggy1ky1zecnyjaq X-HE-Tag: 1728641879-791260 X-HE-Meta: U2FsdGVkX1+Z5MQTk/VQL9pNOEjX1+8gwK7oWO4bMPt0inEEV5lNQUuky67bGcxj5v5l5c6zPNWn2SHWepuSbPLlBlu+R6UoTC4EtMrFMZP9gnYwYr+ZewR7FyHu+LRkx9UFuhBAufH9P9xB98XStdfif4MDXQFcxEVHhr2SyUxnGhyDDvc60EfvckSahv1Nwx5lgspLFw6RPu5VyZKemTLnWnVOri2HRGiQBpAHt1gTW6sT/pdoIWvFpBfXZCebj2CLGXHDDtUBNJ90Rz/l2byNEhSqczNDJ/Fw2X3WXWF/NJlMz6gwEw9BxKnglc3axFHuCrj7tp2JNzZayU8BDgKIsi2jdMmgMk5tl4hPUaxILYIfMCbWC2pJe7+BUreK72vO/grUo4ffKFboQRIx8XcQWtNBB2jVVxyqF2IHWGdOyosK/G5ytqQYlENqb/kU7Q0GA+weVasxSWAbZzM38b44ItM3VrANmAZYjvB4oOPAYt1efNveYEgiJwGKxpQc/PmZh9i/1Je2729onyUdkpKE/GPr2l7f4uJLKtJF5kbRyUninFba0ozXLpPuB0GRFZtBdniljSEXIkqf/z8gm1x8d/pi53GP6xQq6Bb7/xZe5pBmFrFjfx6KnFXz+8wI69T2s/qB8D05bKw5Gwhj/lYcBdSK8R6PTuuMQx+1FiYmSw4+v1KtyHKZadcX7eG1S8HvULVjMdcHnr9QtTWCbn6O+vu4ddrTF3tj6mcOt4oO//mGQalVJZpETaY39mY0pWwpd0OvSVEkWeUIxLjvid6hPH5SlPOw1WnVyrK6CBdX4Ivvwoei/83F0CbwVz5rCSlvxOK+x8dgqXOY5AAV4SGYkoxfBNYp6cjpq4HtF802bSXMBafK4y1qhsYSwjytAGThtrpxI7UtxPLzSm3/LArkLAhFii6cW7ejqmTlGzm0mWmicx7goCxZwMUzndavTSy0GuzRqPamvhQpbHN iwEKwUQP DzWK4MWmA/01KqHA1mSxoCCsYkRNrw5AagDjtM6lkzJswjyx+1SZO6BHj/9BJcWrRJtt7KdxTaatLbPO5hOOZpEFwnD0CdK5NibA9AkZV1bewu7FDioI8l+x8vgsou75Qw6fM77H/zq6FncYTyLL856tPnyDwIxHMgix8816IwKU/9QknvvhVArTlJ9SVR3evBrsxoJe8YT9mXYRxtAk9NFqID2FUde/XlZdrorQZMrMvpeqiPDqZbqzXV6rr/VW1PPT/GmPQO70zKU9Fhw8dQ9XUKakWzgFbrfKitW28xt5aE94= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Ritesh Harjani (IBM)" writes: > Please find the v2 of cma related powerpc fadump fixes. > > Patch-1 is a change in mm/cma.c to make sure we return an error if someone uses > cma_init_reserved_mem() before the pageblock_order is initalized. > > I guess, it's best if Patch-1 goes via mm tree and since rest of the changes > are powerpc fadump fixes hence those should go via powerpc tree. Right? Yes I think that will work. Because there's no actual dependency on patch 1, correct? Let's see if the mm folks are happy with the approach, and if so you should send patch 1 on its own, and patches 2-4 as a separate series. Then I can take the series (2-4) as fixes, and patch 1 can go via the mm tree (probably in next, not as a fix). cheers > v1 -> v2: > ========= > 1. Review comments from David to call fadump_cma_init() after the > pageblock_order is initialized. Also to catch usages if someone tries > to call cma_init_reserved_mem() before pageblock_order is initialized. > > [v1]: https://lore.kernel.org/linuxppc-dev/c1e66d3e69c8d90988c02b84c79db5d9dd93f053.1728386179.git.ritesh.list@gmail.com/ > > Ritesh Harjani (IBM) (4): > cma: Enforce non-zero pageblock_order during cma_init_reserved_mem() > fadump: Refactor and prepare fadump_cma_init for late init > fadump: Reserve page-aligned boot_memory_size during fadump_reserve_mem > fadump: Move fadump_cma_init to setup_arch() after initmem_init() > > arch/powerpc/include/asm/fadump.h | 7 ++++ > arch/powerpc/kernel/fadump.c | 55 +++++++++++++++--------------- > arch/powerpc/kernel/setup-common.c | 6 ++-- > mm/cma.c | 9 +++++ > 4 files changed, 48 insertions(+), 29 deletions(-) > > -- > 2.46.0