From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4B5E6895B for ; Thu, 31 Oct 2024 08:29:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C6956B0092; Thu, 31 Oct 2024 04:29:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 276F86B0093; Thu, 31 Oct 2024 04:29:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13DB26B0095; Thu, 31 Oct 2024 04:29:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E8D2F6B0092 for ; Thu, 31 Oct 2024 04:29:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 95ED04141A for ; Thu, 31 Oct 2024 08:29:11 +0000 (UTC) X-FDA: 82733221746.22.09B11B0 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf19.hostedemail.com (Postfix) with ESMTP id 03C511A0004 for ; Thu, 31 Oct 2024 08:28:34 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nWUaa0nx; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730363305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t6KIOvm84SIgR3hQSfAoHtWOLzNAjtHTpCa17/WlUIY=; b=EC5JjUGvjxciuAVFPKHnnZMCPCl9MvMa061OtR5562eVOsEmEb9yzrOlLTcztEx13B3iRL gLVMi/++ip5uVAmZf6xHkdMt6rKDveZEVtWDcKAcO2ihvhrEk/Sm566HVV0hRxDb2ZJwM0 midw1adPMWKU5gHe3VuaaCOtQ9prR2s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730363305; a=rsa-sha256; cv=none; b=Ex5t/sJEbx1PNjVW5OnZdTpbSDYX+JtbGSSRKJCCUNytT2xaWg05kn1r8wSGav2LXAJ9yx s6gCfZOQlfyBqFJ9KOoyfegVww3VWbZpqbcfTLGGttOU+plwi6Bj0VRwdpqCRGiJa+PHsH GkMR1lKr2+yt/2751Ej+agrcD3xaG6s= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nWUaa0nx; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730363349; x=1761899349; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=PMU0uMcMcWAKRKv+7T1kQKvTf9dp6QsnhlSRXNzeDls=; b=nWUaa0nxIrmTEJhosCPMbMJmzvguXRpxXc+Z+lKGkz4+HXmLZPJP4o9h QdDx4ctcmbiw5tNU552OChpdfPPpjLbnnfliGj9qoDAcMLF+WMJQ0/Aky LlSNIHMdDP/4j684ujuBmM1zEmFzusnPvcKlG0mEp/1pfugDbz3yCYrdZ h9GQDYnJ6TkZEbqv4pG1+5P83Gs2dQ4kq9idtrzbHTubOtiWm9gjMP01H dsZMmAD/yFwjxbGuZUOIrq/5KWty0m0nXS730VSoWBIKXSHURnZSNsc4Y 5A37yhQywZOMoF+pkDCGprQSSLNkblWwrapvahlic0hvdfnTBdnWx+cvr Q==; X-CSE-ConnectionGUID: W0Z0AcrVRWmED+qAZ0NJQQ== X-CSE-MsgGUID: ptluezApTmOpd6vq4JW8dw== X-IronPort-AV: E=McAfee;i="6700,10204,11241"; a="33878358" X-IronPort-AV: E=Sophos;i="6.11,247,1725346800"; d="scan'208";a="33878358" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 01:29:07 -0700 X-CSE-ConnectionGUID: N/dIxb3sTHmvY/EFOAgiIg== X-CSE-MsgGUID: koFOiFCLQAO4jPWqYR72Yw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,247,1725346800"; d="scan'208";a="82721743" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 01:29:04 -0700 From: "Huang, Ying" To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Baolin Wang , David Hildenbrand , Chris Li , Yosry Ahmed , Kairui Song , Ryan Roberts , Kanchana P Sridhar , Usama Arif Subject: Re: [PATCH v3] mm: add per-order mTHP swpin counters In-Reply-To: (Barry Song's message of "Thu, 31 Oct 2024 21:21:24 +1300") References: <20241031075325.1037-1-21cnbao@gmail.com> <874j4sae8y.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Thu, 31 Oct 2024 16:25:31 +0800 Message-ID: <87zfmk8yro.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: cpwnc4e6ksz5no9aebsbsy387r4rcid5 X-Rspam-User: X-Rspamd-Queue-Id: 03C511A0004 X-Rspamd-Server: rspam02 X-HE-Tag: 1730363314-935510 X-HE-Meta: U2FsdGVkX18t/01W3LfnCRg1GkRRvsvIj24KC9Rf+TsfOZFH3RQ2rkGcPaC+4Xhp2/JDJpKd4wsEKB7gGExFLAX+7HKzPTqg8LHVmXjwbqRvucittNP9Xe+ns8vioXW5O68J3Q8H6budLSkPdhCKkYVwVQUuzZxMmFCPnKXn7ZXY6Ery5ZBnZr0BoE77n2gvPqc3t5cSKVlghxvAIh/BnzWSH9YeNd41xMfjcKxgmlQwfeRWfKryafxL7EhDBSCE9ynnJGOxFSmZ770XsOcJ5tVGMR+6MHSddY9tnfgUNu48PYArpsGEM+5fAuiHbHZSIIriWx6Sme9aG3dkErloxlUiUqLSK8cQDhjYt0G3sT73eN+AIVMIBHK6InZpAJe4fUl23rD1BSENA0AiVWykO4kjAvgmfwepxWo2Iv5QJ5ceLXUVQin2uYfAgHFGpsrWPQZoKb9yVQtwxqTud6FP5L3cIpNEmRX2N9/HlWLQmMVVC9Rak9mRZFFnvoZSS8ZbHpMcjN9neid/KwDawWH7QjOuyXG5LFmhFKezRE+sXcCGs97kKe5mBzmtBWVUy9oG0GtbJzMZ/LXBUUBsF5HFLymEzJTwj7d/lo5UOZLMsx7ItfMXXoUD7SaVBs32hw06TEN/+05+VZXHvCifrg+Ins1xcvgcelpnam2v2EE1WTeyD0tVxZHBgawbLg/xRdTjYkIsWqXxE/cfXBdQWrMDtZ+Mb1H2eC4E95XW35I07IFb5FQap8+GyZgxAOIOhw0wpKJ1d3izfP+qXJqo5eqCo/1FfUHlJjyasMfzPZLIaaAVTgOp/X01XSnR/z/AsPNEp7lToKrY7fsrAUYFt6HpDXWbQwa7yra6Efcp3XIqh+S0tY7p5qtoVZCjYLAzVsmNuNZltl+Pyh9Rk4AtTSy8yacTW6aKPL6bV7Dck78bIyE+ukZj9aPrGf19AdRkqkih+0Nf6YfZ27cHZvggbfd iAsM82dY o7BZNwp/5PsCRV0UWJ3LW1RWqwKxgAVqxByBDhVRB/n7oZgF+Pk3h/8AEPTMD0NAmkrgNO7mFdwD+yrPMDSApBp4UQU8Euzq7sk1lDpDhit4O5rN2ebJuGVwOnLsAPLxgZvepi8EucRlPQ9U8+SRT00490U4PCp8BtEV687kP0UOuuhsWg0J7c27nx45cjylcYQJBQ0KnrdqX0AxvheVcTHfmYSTNKlRr27ljWKNVZpQOcfn6tK48AR/Xazt6i/PYIzUYW9JdWueHX+3KIe8Ql03qTku0tWhB+kbGA5CYTK3bZQP8emmGMzwk9uWlZ3FOCKmTe/FAc+WG55xql2bFxrRrItzkjC+oEVl+4ZNGUeWzN0jYlZPxxPbMBmnPpZWmXQ4dN7Hjg5IZtq6GFPgdR53r3EVee9wwgeVH4v3vrafYZM6q+XCEMZUe6V1+w2TjWJirFWuNqoYn5zoLK0NzjVBIrA2cnse02YEr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Barry Song <21cnbao@gmail.com> writes: > On Thu, Oct 31, 2024 at 9:09=E2=80=AFPM Huang, Ying wrote: >> >> Barry Song <21cnbao@gmail.com> writes: >> >> > From: Barry Song >> > >> > This helps profile the sizes of folios being swapped in. Currently, >> > only mTHP swap-out is being counted. >> > The new interface can be found at: >> > /sys/kernel/mm/transparent_hugepage/hugepages-/stats/swpin >> > For example, >> > $ cat /sys/kernel/mm/transparent_hugepage/hugepages-64kB/stats/swpin >> > 12809 >> > $ cat /sys/kernel/mm/transparent_hugepage/hugepages-32kB/stats/swpin >> > 4763 >> > >> > Signed-off-by: Barry Song >> > Reviewed-by: Baolin Wang >> > Acked-by: David Hildenbrand >> > Cc: Chris Li >> > Cc: Yosry Ahmed >> > Cc: "Huang, Ying" >> > Cc: Kairui Song >> > Cc: Ryan Roberts >> > Cc: Kanchana P Sridhar >> > Cc: Usama Arif >> > --- >> > -v3: minor refine changelog per Huang, Ying. thanks! >> > >> > Documentation/admin-guide/mm/transhuge.rst | 4 ++++ >> > include/linux/huge_mm.h | 1 + >> > mm/huge_memory.c | 3 +++ >> > mm/page_io.c | 3 +++ >> > 4 files changed, 11 insertions(+) >> > >> > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentatio= n/admin-guide/mm/transhuge.rst >> > index 2a171ed5206e..5caa3fb2feb1 100644 >> > --- a/Documentation/admin-guide/mm/transhuge.rst >> > +++ b/Documentation/admin-guide/mm/transhuge.rst >> > @@ -534,6 +534,10 @@ zswpout >> > is incremented every time a huge page is swapped out to zswap in= one >> > piece without splitting. >> > >> > +swpin >> > + is incremented every time a huge page is swapped in from a non-z= swap >> > + swap device in one piece. >> > + >> > swpout >> > is incremented every time a huge page is swapped out to a non-zs= wap >> > swap device in one piece without splitting. >> >> In Documentation/ABI/testing/sysfs-kernel-mm-transparent-hugepage, I >> found >> >> " >> What: /sys/kernel/mm/transparent_hugepage/ >> Date: April 2024 >> Contact: Linux memory management mailing list >> Description: >> /sys/kernel/mm/transparent_hugepage/ contains a number o= f files and >> subdirectories, >> >> - defrag >> - enabled >> - hpage_pmd_size >> - khugepaged >> - shmem_enabled >> - use_zero_page >> - subdirectories of the form hugepages-kB,= where >> is the page size of the hugepages supported by= the kernel/CPU >> combination. >> >> See Documentation/admin-guide/mm/transhuge.rst for detai= ls. >> " >> >> So, Documentation/admin-guide/mm/transhuge.rst will be used as ABI >> document? > > Yes. this follows: > > sysfs-kernel-mm-hugepages: See > Documentation/admin-guide/mm/hugetlbpage.rst for details. > sysfs-kernel-mm-ksm: See Documentation/mm/ksm.rst for more > information. > sysfs-kernel-mm-transparent-hugepage: See > Documentation/admin-guide/mm/transhuge.rst for details. > Got it! Thanks! Feel free to add Acked-by: "Huang, Ying" in the future versions. -- Best Regards, Huang, Ying