From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D3FC02181 for ; Mon, 20 Jan 2025 13:58:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2163280003; Mon, 20 Jan 2025 08:58:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD23B280002; Mon, 20 Jan 2025 08:58:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9901280003; Mon, 20 Jan 2025 08:58:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9C38C280002 for ; Mon, 20 Jan 2025 08:58:53 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 50C181A013E for ; Mon, 20 Jan 2025 13:58:53 +0000 (UTC) X-FDA: 83027986146.18.553343F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf16.hostedemail.com (Postfix) with ESMTP id B45F3180007 for ; Mon, 20 Jan 2025 13:58:51 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U86szpEy; spf=pass (imf16.hostedemail.com: domain of a.hindborg@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737381531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rq/Zh4HrSYiOy2a9qe9YB2c5G+mEXAXTXQbwokMpDGA=; b=Nrlt5EHCyZDForAXEkSyxNwnSoAfiECNZMEG0ZPob2YT9sOvL1W3bDDXZbhisdmSTwb+// xHM70UgOdVr5blWFA1g0kGlpHnVD4GYXwML3vvqJYBlgn4gU2qi2HlSZd/Gk0OhFPSSIb6 lSdoaeFp6M4SAgahKn8mU4brIPmQoHc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U86szpEy; spf=pass (imf16.hostedemail.com: domain of a.hindborg@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737381531; a=rsa-sha256; cv=none; b=VZg6LaC2iFb5fT4O6wD58XLdlFSEGyA02sgqpGcXRfj+b6PpDor0gkfo65UhllX89X07wD wboJ18s7YMpy6n66onl8j2rPKhcRuY1rj1g8XqzNzCylERtiqSFqQkO6mpftTOlZtAFYVe +GfXLW7fv5hSEfPteVsLgMWQ4SZ6dnA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 42E63A40C9B; Mon, 20 Jan 2025 13:57:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2A1EC4CEDD; Mon, 20 Jan 2025 13:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737381530; bh=Rq/Zh4HrSYiOy2a9qe9YB2c5G+mEXAXTXQbwokMpDGA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=U86szpEycl+brF3mrXmF6DDQcK6dx4pedsJxYXuehpc39LUqgqaQogyXbsj6FAfXl kJLQE5ncmreMdaHOFnnRCWe2zLtxcSuI7J7r2GGke6iF89551g3lopd6+v4xDL2HZQ k4MIqLOKw4/KYzGDMGuLQ8nMLXIOdKo/6DVB722VJiMAAhl9S2AKd728u3He6faktZ 84LAANm79QeQblha43cZl0fMVZYZNFs6RIBOl0Lch9jVJlJbghe/qhDkXHWDNsoBc4 Z6xyJw00NtNO475V3cyv06ffqyh1yTM7x2aH7cSdhXRmStSoDYzPO2ZSHe9dBHzQc5 rRB+5+VvT9oUg== From: Andreas Hindborg To: "Alice Ryhl" Cc: "Miguel Ojeda" , "Matthew Wilcox" , "Lorenzo Stoakes" , "Vlastimil Babka" , "John Hubbard" , "Liam R. Howlett" , "Andrew Morton" , "Greg Kroah-Hartman" , "Arnd Bergmann" , "Jann Horn" , "Suren Baghdasaryan" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj?= =?utf-8?Q?=C3=B6rn?= Roy Baron , "Benno Lossin" , "Trevor Gross" , , , Subject: Re: [PATCH v12 3/8] mm: rust: add vm_insert_page In-Reply-To: <20250115-vma-v12-3-375099ae017a@google.com> (Alice Ryhl's message of "Wed, 15 Jan 2025 13:35:06 +0000") References: <20250115-vma-v12-0-375099ae017a@google.com> <20250115-vma-v12-3-375099ae017a@google.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 20 Jan 2025 13:47:01 +0100 Message-ID: <87zfjld54q.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B45F3180007 X-Stat-Signature: m4i1z79r3f1butzmdxjau1ii4fh4g5ge X-Rspam-User: X-HE-Tag: 1737381531-987697 X-HE-Meta: U2FsdGVkX1+Lh0UsAm1L9I5dpY/E8a9vkD89GYEiI2i1Y6wkPACcdx/ji5Ni22T/yCtT9btOLvrhDvKk7PchnFIHnIbLoy89j0DQw4u4yzJjCKdz0zlXBCt+/B0rQSIirqVyDHcxOxX0j1JmGwiRMyA0OCMEHgf/hCo+RFuzS7LuxxegbX3gLOsbjifxz6EkTPuZTyxvX3MeFUyA2zmOAf2B7aTxLyVPIgC8bxBfqYRKi5E0S8ribDPzTkbgrpbpWZ8B1WSLiahKmW/q2gtJIYvVL0I9C5ErG37LjGBN0gaQYURsgwYr3uGOF0pDbKOS+tcN70ZwbqVazw2/ANxeZLbgoq0XXyViXCepDBUybhduI97LAYBltTYD00XvFKdzHEnOh3OomnltK7HPCTn5R1DY6Dc5dZQOlOySZYixPbsEB2mHx/vcgsM87VpXZqBojB+K8Xlt6eL20tSWKbEFlG5q8jRnLKQpguP3vjDMShAlgxS2Pf6obKBrNsYa9zDaQu408JYqq05wPPI+/igII0ibi3+f7wRaLfOdhefzzVH/rSPJzBi4WYJQY5JxrsIAQ5OyxvB7S6BeylfAhSeJwS+TADyas9jfQ1S4+psTI72W1BmCTUyXfkE1CxtKro7HGq5UtQYVmfyAvh89lLRbyXjLSGK8cWCz112rBzBeqx7t4PhBZHf9vqNA1aruNZw0JX78gXQgBuV3c/d4oGy6P3BeGs+r09s5+aQMCwHkIYyUFRk7QxxelFTtzVoopyiyMSURwSz6XdJFKmSG6cgTBBFhRdwM2f6dchzItU3iQVeROxGkgckwi+upYqP4gIQESYFIzG00hvFrytkEekCl/1Peq0mK1Y80HirNSWlhxCNusDabyid+AFcKxxlVXFNlUbt2kfSO/HTYWswUqsix9A6v3cRw7Fq3DAGmeHXcmgDyrb9iRvIUjpAMwBfSTxxq78px3yLVsHYSKbzPLRx m7jpu6aV YNHX9Aqlk5hjhal6enlr6W4v0VMcVMhHpzIzKl9XMakW7A3w67MX+qrQb3R7fgIZuEdB2hc1VgELpU+tFh97nYid1BelEoPWXqlVfmw4GMzNGbiGUrU583y2PemXigTZiJaeYKjLqHarOpEthOROHUMK3z3Wietpw5PNCEJ7fDTSOFyWmPIfEg4RScOSxj9O7jrZCNBgICQnYnBOaVJ4dmTa6nPr8g4d8Vc/MTpryF/xAP4C7+bkj/n05A1+KMNZAVhcXVO3nmAMgc5xS6x6Ui53TBohq5VOhTiIkGjdIQcWs6niTfU/F/V4dUdq//46CAXtcRXjdZZb4szxNpA4YA13AfzrVEQytpZ6XHv5e8Rh92v8= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.488758, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Alice Ryhl" writes: > The vm_insert_page method is only usable on vmas with the VM_MIXEDMAP > flag, so we introduce a new type to keep track of such vmas. > > The approach used in this patch assumes that we will not need to encode > many flag combinations in the type. I don't think we need to encode more > than VM_MIXEDMAP and VM_PFNMAP as things are now. However, if that > becomes necessary, using generic parameters in a single type would scale > better as the number of flags increases. > > Acked-by: Lorenzo Stoakes (for mm bits) > Signed-off-by: Alice Ryhl Reviewed-by: Andreas Hindborg Best regards, Andreas Hindborg