From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E65C3ABCB for ; Mon, 12 May 2025 01:35:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60F326B0099; Sun, 11 May 2025 21:35:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BE126B009A; Sun, 11 May 2025 21:35:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AD7A6B009B; Sun, 11 May 2025 21:35:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2CE356B0099 for ; Sun, 11 May 2025 21:35:24 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 40B7FBEFB0 for ; Mon, 12 May 2025 01:35:24 +0000 (UTC) X-FDA: 83432538168.11.96445B1 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 46B301C0004 for ; Mon, 12 May 2025 01:35:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=xkYO0xLi; spf=pass (imf20.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747013722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EuVnERNVneAr3tpEi62beA//L5n3y/h3iWpY0SrJdDg=; b=ziKFzHvD3r1EUZJ0MbxG6Rp3J7D4TwWR2ZiftXMWSKConb6ddyFM6qweJigANfCdYZWjLv PBQUUmpeWhSfcJswjcgPVctT12oWzWMKRAQwTyH2Ksg3fBMDxKoTWYYCs3qBgeSbLlm90R /gmHtRWrXsDr/hEQTbE/lAtzakO3vR4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747013722; a=rsa-sha256; cv=none; b=izvdjxUy+uHxUkEPimfxXUl4H+Cvk88pjJ6PM/hUhih7LmAYk8rXqmcofnSryW72HE4v15 KmpOINx1GnSP6MF+w2DyydmcyL9nj9XB2wtcZU67WY2vX5hCturD/lYwk9mtI2goE3zrM/ olMEHMZ9EzFadZIlO5xKHAHow0IhhTI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=xkYO0xLi; spf=pass (imf20.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1747013717; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=EuVnERNVneAr3tpEi62beA//L5n3y/h3iWpY0SrJdDg=; b=xkYO0xLi90+ZZ/HVoZCyIbP/e36lMX3Ni9lKO22P6mrf+XM+Y62Zbmjy9ebmkKqI+FpopLyuiieIxjH5CYT/mFQPNDgF03bIdGEzwqPEjPntwXuupucG6Kjl6lAo2QWZWndyb35RT5fo8BjHrNSlX8drDPq5l1683V0T+PyYuo0= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WaCLFf4_1747013715 cluster:ay36) by smtp.aliyun-inc.com; Mon, 12 May 2025 09:35:16 +0800 From: "Huang, Ying" To: Joshua Hahn Cc: Andrew Morton , gourry@gourry.net, honggyu.kim@sk.com, yunjeong.mun@sk.com, gregkh@linuxfoundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v8] mm/mempolicy: Weighted Interleave Auto-tuning In-Reply-To: <20250511025840.2410154-1-joshua.hahnjy@gmail.com> (Joshua Hahn's message of "Sat, 10 May 2025 19:58:39 -0700") References: <20250511025840.2410154-1-joshua.hahnjy@gmail.com> Date: Mon, 12 May 2025 09:35:16 +0800 Message-ID: <87zffizk4r.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: if8ti4fzrodazw86e8cefhxgfxciixic X-Rspamd-Queue-Id: 46B301C0004 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747013720-983034 X-HE-Meta: U2FsdGVkX1/e6gSJn+tLDeM9Z9IpTLuASmkjnK3JpF2gB4nYBV7juWbVMyHQzqJsHv5T5aECGe/UZQzMWZfLXQh3lavdGGgvQ2d8merRXQwIDsG2X7ASPZOxogA0Abg8YWtUzGMAlxXnfYu4CNoQmYoG1/uuRy/U5dECfqE+W0Eryc+WoXStxM4lf2KKFQ1Rxw4dRnqF291f3kmMO1HUWrkqIkb1s2iR61QDzfiVKD5OYU1umyXsqv0rjZLg75zboYIzsCtvBHBFiMXIEpPLYnFJmIAcN9AUnpEbYxIFmVLxPXQTivTZRGsmvEA7FqP8IIZVCvSUgqQhE/S66WopDui4cwBI0IV9Yqoy5RqbhOAXJmKiLmFi0LzqUqZ5c8FEH2GWRAdC//aBdRKhpZNj7fQRoOpuNvaKslcOV18P/8Z+7LMjBxsumJHHECpBAUoB4l182kGhBxW6l2pTPzMo3CBaeR0IVpdOlXSYcEX2V1vgXh1Ya0718pnGrpZ8r+zZidne470m83KmOT76tIs2Kb6gnQSjJAZaTtrAwJ3L40XtZ9NCpz3UBeQk1NVAb9oe2OL+GsFQZz4VUo8ExAltijhZpcKBLEtnh3YxQXmqTx0sC7XMarzgBWE58mwhVsUXwlmfnMLCIOIpZUFlsbMHlajzt53ctOorB89F2wrlWe/yrQH3k6vSlnbJVaEXLYx8PFj1fVBlPPuMfYmkwhhFGHxrkNl3OlBn5n3LQvbST3BFcYwRqZ/9lbh0Oh9dd7iDazzhJ/FzFtHxSZQOYolCDUgc08b9ntaEbchNPmeIiXwstS9eVRFp2gi3kdGGNnrgZ+FDtqo8fxc+W1I+CGr67KwrAlHTnzvLgrvI7uo3ONIwzcGbSeanJ8yczWX9AlfcNxki/wvqyG72VFD+0l8Uezn2ekx5MSmw+Fc6CVYJEmtyAmp8LgJCgfyuLoRbu+2A3Y0qwkv20DrPxzc0IYi zAQ5UUD4 SSRh7WKvEfu4rwmIvNA0nWWpF7KN+FMz6zM86dVF8cQS+J/TTl66cXw7p4c1wOmiOIweTLXh/kByFDcCuasFHsjVAvJgtk69JwB2y1nx4IZcDL0mJ/c/Gxf0Fs/UJbKjf5ZsOf6pAi6vfEgu0kiYqPoJFR6tbK3BqkR3gKB9EsEIgidkQLIFZx6Hp6YI4FF9oVTBn82UQvdaUta42rgVxvHyR8kbkF3MC6taA/DwQLAjQ1kEfZ2RzLjAYI7E0uTKpXxW/rcg0R1m0oDSA/y22y8C7WRwWU+FKdIyQQxWcyCElPFJVVh1+6FmDig4KWWU73LnX+T9mIDIf2MuQ1LdgcC3Gtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Joshua, Joshua Hahn writes: [snip] > @@ -3707,8 +3720,12 @@ static void wi_state_free(void) > kfree(&wi_group->wi_kobj); > } > > +static struct kobj_attribute wi_auto_attr = > + __ATTR(auto, 0664, weighted_interleave_auto_show, > + weighted_interleave_auto_store); > + > static void wi_cleanup(void) { > - sysfs_remove_file(&wi_group->wi_kobj, &wi_group->auto_kobj_attr.attr); > + sysfs_remove_file(&wi_group->wi_kobj, &wi_auto_attr.attr); If we use wi_auto_attr directly here, we can remove auto_kobj_attr field from struct sysfs_wi_group? > sysfs_wi_node_delete_all(); > wi_state_free(); > } [snip] --- Best Regards, Huang, Ying