From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3804FC5517A for ; Fri, 23 Oct 2020 21:56:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6AD39208E4 for ; Fri, 23 Oct 2020 21:56:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="EetW5+h2"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="+wyfQHna" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AD39208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 962706B005D; Fri, 23 Oct 2020 17:56:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 913C26B0062; Fri, 23 Oct 2020 17:56:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8021B6B0068; Fri, 23 Oct 2020 17:56:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 53AE66B005D for ; Fri, 23 Oct 2020 17:56:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DB153181AC9CB for ; Fri, 23 Oct 2020 21:56:36 +0000 (UTC) X-FDA: 77404549992.26.cream88_3b10a2a2725d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id B3CCC1804B655 for ; Fri, 23 Oct 2020 21:56:36 +0000 (UTC) X-HE-Tag: cream88_3b10a2a2725d X-Filterd-Recvd-Size: 3132 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 21:56:36 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1603490194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=79rTg2SKZLoa/evVojUPAbe7jLqXBquN2CeaB2ok8dM=; b=EetW5+h2WAFfLhHoLTCZ9y+9G7Ei5unrNieHG1oDovYqkcijqZVi/zV19BnVNHeDAYAq1y 5BPQvOBeenBqLGZsMVj0lxrhTePplE91mlRbpz6CwZlY5ngqViOYE+dIpuSbgEqXN/hk+p jZgnfrBD4hxFmjvZv0feO4rHUiJ10r7PGhwlaj55UBGIzybRn6FLG3VxHgQfGbyY8XfR5y ZWdJnyBKnvxoeq281PMRil6StYpFCqPQgpfBqwHXqkT9CU72euIqVkVtoVbuIqm2lzXkVL 8SmRG2kKrV0hOeL1M2wDVZUriXPi0GcVcw6UJ+cQfZoek59YI4kGMXrtfSvuHw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1603490194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=79rTg2SKZLoa/evVojUPAbe7jLqXBquN2CeaB2ok8dM=; b=+wyfQHnakkKyqSE/2uGjxNcZTwxnMUoslSbSCXRrWkS+13bWcBa+tI0OQQwYJbaGoQJY9w kc67vWEIFcKYyjAw== To: ira.weiny@intel.com, Ingo Molnar , Borislav Petkov , Andy Lutomirski , Peter Zijlstra Cc: Ira Weiny , x86@kernel.org, Dave Hansen , Dan Williams , Andrew Morton , Fenghua Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 07/10] x86/entry: Pass irqentry_state_t by reference In-Reply-To: <20201022222701.887660-8-ira.weiny@intel.com> References: <20201022222701.887660-1-ira.weiny@intel.com> <20201022222701.887660-8-ira.weiny@intel.com> Date: Fri, 23 Oct 2020 23:56:33 +0200 Message-ID: <87y2jw4ne6.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22 2020 at 15:26, ira weiny wrote: > From: Ira Weiny > > In preparation for adding PKS information to struct irqentry_state_t > change all call sites and usages to pass the struct by reference > instead of by value. This still does not explain WHY you need to do that. 'Preparation' is a pretty useless information. What is the actual reason for this? Just because PKS information feels better that way? Also what is PKS information? Changelogs have to make sense on their own and not only in the context of a larger series of changes. > While we are editing the call sites it is a good time to standardize on > the name 'irq_state'. While at it change all usage sites to consistently use the variable name 'irq_state'. Or something like that. See Documentation/process/... Thanks, tglx