From: "Huang\, Ying" <ying.huang@intel.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>, Hugh Dickins <hughd@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>, Ilya Dryomov <idryomov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>
Subject: Do we still need skip swapcache logic in do_swap_page() for SWP_SYNCHRONOUS_IO?
Date: Thu, 17 Dec 2020 09:57:28 +0800 [thread overview]
Message-ID: <87y2hxgpo7.fsf@yhuang-dev.intel.com> (raw)
Hi, Minchan,
In commit 0bcac06f27d7 ("mm, swap: skip swapcache for swapin of
synchronous device"), swap cache management is skipped for super fast
device with synchronous IO. That did help performance for these devices
much at that time. But in commit aae466b0052e ("mm/swap: implement
workingset detection for anonymous LRU"), swap cache is used to record
workingset shadow value. So it needs to be operated anyway in swapin in
common cases. Although lockless operation get_shadow_from_swap_cache()
is used now, in swap_free() path, swap cache will be locked. So now, is
it still necessary to skip swap cache logic in do_swap_page() for
SWP_SYNCHRONOUS_IO? Maybe we can just simplify the logic?
Best Regards,
Huang, Ying
next reply other threads:[~2020-12-17 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 1:57 Huang, Ying [this message]
2020-12-17 21:02 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2hxgpo7.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=idryomov@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox