From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A231C433F5 for ; Fri, 1 Apr 2022 03:20:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897608D0001; Thu, 31 Mar 2022 23:20:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 847336B007B; Thu, 31 Mar 2022 23:20:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 736118D0001; Thu, 31 Mar 2022 23:20:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 6466D6B0078 for ; Thu, 31 Mar 2022 23:20:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 24B0380612 for ; Fri, 1 Apr 2022 03:20:37 +0000 (UTC) X-FDA: 79306857714.01.DEA9642 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf28.hostedemail.com (Postfix) with ESMTP id 3A8AAC001A for ; Fri, 1 Apr 2022 03:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648783235; x=1680319235; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=VljMUx3NAvi5ubUt1jFKfnEjFTq1/S47IQjBpwpMFsw=; b=Za8Tbmj6uv+03rFp4Fkm1gA3i9nThRffr9QSMAtvaJviqCtt0qI/9oDd sD+Y4VhK4SjYQdh8g+22TmD29rFlVgRnH8O9JqEpJfzbsieqQFRp9Jnyk 1MG4bL2jPJSuFQr3P5qffIjZxJ1oqtxVVfDGh+RVlKEA7yPnTT6kK5zvC TdDFeAxcOOzcgyVtk8Fqb2MHzLW0urcXOXYYEZumhmjvBB36upLjtfKD/ im8Xz1Zt/KAgZkOgrvVasVM5WYKxFapafi8fbDSNobPn3cv5ujHgzjWig cFn3QTTrxfzjS8Efi9oXo7BIbbZzoGUj++L56N1LxjrFiMYz6TJqposQ2 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10303"; a="346471793" X-IronPort-AV: E=Sophos;i="5.90,226,1643702400"; d="scan'208";a="346471793" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 20:20:33 -0700 X-IronPort-AV: E=Sophos;i="5.90,226,1643702400"; d="scan'208";a="567081540" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.94]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 20:20:31 -0700 From: "Huang, Ying" To: Miaohe Lin Cc: , , , Joonsoo Kim , Konstantin Khlebnikov , Wu Fengguang Subject: Re: [PATCH 5/8] mm/vmscan: use helper folio_is_file_lru() References: <20220329132619.18689-1-linmiaohe@huawei.com> <20220329132619.18689-6-linmiaohe@huawei.com> Date: Fri, 01 Apr 2022 11:20:29 +0800 In-Reply-To: <20220329132619.18689-6-linmiaohe@huawei.com> (Miaohe Lin's message of "Tue, 29 Mar 2022 21:26:16 +0800") Message-ID: <87y20pa3r6.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: 4bhzwcwtu3pkozjwzp7a69sodsxhi5dh Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Za8Tbmj6; spf=none (imf28.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3A8AAC001A X-HE-Tag: 1648783235-162961 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miaohe Lin writes: > Use helper folio_is_file_lru() to check whether folio is file lru. Minor > readability improvement. > > Signed-off-by: Miaohe Lin > --- > mm/vmscan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index ebd8ffb63673..31e95d627448 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1411,14 +1411,14 @@ static enum page_references folio_check_references(struct folio *folio, > /* > * Activate file-backed executable folios after first usage. > */ > - if ((vm_flags & VM_EXEC) && !folio_test_swapbacked(folio)) > + if ((vm_flags & VM_EXEC) && folio_is_file_lru(folio)) I think that this should be converted to if ((vm_flags & VM_EXEC))) We should activate swap-backed executable folios (e.g. tmpfs) after first usage too. Best Regards, Huang, Ying > return PAGEREF_ACTIVATE; > > return PAGEREF_KEEP; > } > > /* Reclaim if clean, defer dirty folios to writeback */ > - if (referenced_folio && !folio_test_swapbacked(folio)) > + if (referenced_folio && folio_is_file_lru(folio)) > return PAGEREF_RECLAIM_CLEAN; > > return PAGEREF_RECLAIM;