From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C23EC43334 for ; Mon, 27 Jun 2022 06:50:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A043B6B0071; Mon, 27 Jun 2022 02:50:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B2F78E0001; Mon, 27 Jun 2022 02:50:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 853AB6B0073; Mon, 27 Jun 2022 02:50:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 75C6A6B0071 for ; Mon, 27 Jun 2022 02:50:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 465C26075B for ; Mon, 27 Jun 2022 06:50:10 +0000 (UTC) X-FDA: 79623091380.22.6950909 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf17.hostedemail.com (Postfix) with ESMTP id 9D1CF4001C for ; Mon, 27 Jun 2022 06:50:09 +0000 (UTC) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25R4rOIl020272; Mon, 27 Jun 2022 06:49:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : content-transfer-encoding; s=pp1; bh=us9leZJZ7dHIolx7l8Yx4Wg4oMITjBrXn2PD0P6cOQk=; b=iq6vbtnC6J7bCZMrts1zXFjkpYl7G3sIlf7U4s7mxX6A1n7e+MnuGxMbPUXl+1sYwc8J XjAx6JV+QVqfW9nVntj2SvL9s7mLeet7lDG/yA3Z4XmQLnBOx7mvPuBo51yFzUcG+yvw skpGNNSz3c65J9JBnDdEUq8iho7x7ekfGNoKjaVl2aCsunOVVCfgt7Huunu7fjKWSA0f m0hFuzwxFFsnOLVDQtj4//SZWc6tl5uu8zA2OdmU4PC0gizM8MelJvDMyim5+2kFsxen 49sr8Io3WHid/j/77JjIGS1CUk3VSoWc8uF4+7HjrJGhogjOy7wL9SOA6KJPWzdJdgji wQ== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gy5wpb7b7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jun 2022 06:49:59 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25R6Ks6r015274; Mon, 27 Jun 2022 06:49:58 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma01dal.us.ibm.com with ESMTP id 3gwt094bn1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jun 2022 06:49:58 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25R6nvXG23003544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jun 2022 06:49:57 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A745D124054; Mon, 27 Jun 2022 06:49:57 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 28BDC124052; Mon, 27 Jun 2022 06:49:55 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.43.47.235]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 27 Jun 2022 06:49:54 +0000 (GMT) X-Mailer: emacs 29.0.50 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Christophe Leroy , "linuxppc-dev@lists.ozlabs.org" , "mpe@ellerman.id.au" Cc: "linux-mm@kvack.org" , Michal Hocko , Kefeng Wang Subject: Re: [PATCH 3/3] powerpc/mm: Use VMALLOC_START to validate addr In-Reply-To: References: <20220623122922.640980-1-aneesh.kumar@linux.ibm.com> <20220623122922.640980-3-aneesh.kumar@linux.ibm.com> Date: Mon, 27 Jun 2022 12:19:52 +0530 Message-ID: <87y1xiy50v.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Eu6wj8NoK-cIgcmkFZPIitDi0K3QPWCw X-Proofpoint-GUID: Eu6wj8NoK-cIgcmkFZPIitDi0K3QPWCw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-27_05,2022-06-24_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 phishscore=0 impostorscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=905 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206270027 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656312610; a=rsa-sha256; cv=none; b=FPXydoY+d2uAHGP8EP0SMxm9y0a5ilZK8BsakGdwQwVIUUAGpe5HMMq8IoK83WXhx9UmSg ElvsAgZqbvH/55lcKdBCX7j20qbT4hnj4sN1AV88EanrPzkHO7HZKwzsPSml4/8SqSAh4c XQv0krB/Y50av5oCG07gsiHuZE7MpgY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=iq6vbtnC; spf=pass (imf17.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656312610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=us9leZJZ7dHIolx7l8Yx4Wg4oMITjBrXn2PD0P6cOQk=; b=Ql/UNWlwIUMoP2Ev+kZytJ8n7bujt+ShKuUs2LS+JzoFbCMnX9tiBIzUYdWnGrnHK5V63W zjnHpIaFik0QtzNigqIcQVXPUpNvYGD9GpnvkGTUx2yFIoYCuQF3ojIWeZ/atFIe23SL7R 8cmTeQiqeymfXYciKubQ018TSokmW8M= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9D1CF4001C Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=iq6vbtnC; spf=pass (imf17.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspam-User: X-Stat-Signature: 9dt59naikuazwrz5jhocfb8a8qyfiqpj X-HE-Tag: 1656312609-379944 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christophe Leroy writes: > Le 23/06/2022 =C3=A0 14:29, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >> Instead of high_memory use VMALLOC_START to validate that the address is >> not in the vmalloc range. >>=20 >> Cc: Kefeng Wang >> Cc: Christophe Leroy >> Signed-off-by: Aneesh Kumar K.V >> --- >> arch/powerpc/include/asm/page.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/= page.h >> index e5f75c70eda8..256cad69e42e 100644 >> --- a/arch/powerpc/include/asm/page.h >> +++ b/arch/powerpc/include/asm/page.h >> @@ -134,7 +134,7 @@ static inline bool pfn_valid(unsigned long pfn) >>=20=20=20 >> #define virt_addr_valid(vaddr) ({ \ >> unsigned long _addr =3D (unsigned long)vaddr; \ >> - _addr >=3D PAGE_OFFSET && _addr < (unsigned long)high_memory && \ >> + _addr >=3D PAGE_OFFSET && _addr < (unsigned long)VMALLOC_START && \ >> pfn_valid(virt_to_pfn(_addr)); \ >> }) >>=20=20=20 > > What about booke/64 ? > > The test will be _addr >=3D 0xc000000000000000 && _addr <=20 > 0x8000000000000000 so the test will be always false. > Ok, I didn't realize that booke/64 have vmalloc range below direct map. I guess we should drop patch 3. -aneesh