From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD9EC77B7A for ; Tue, 13 Jun 2023 12:37:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6689E6B007B; Tue, 13 Jun 2023 08:37:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F2618E0003; Tue, 13 Jun 2023 08:37:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46C838E0002; Tue, 13 Jun 2023 08:37:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 396C76B007B for ; Tue, 13 Jun 2023 08:37:39 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 13809160491 for ; Tue, 13 Jun 2023 12:37:39 +0000 (UTC) X-FDA: 80897675838.08.BEB0C10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 3300F4001A for ; Tue, 13 Jun 2023 12:37:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BP+MRJ8F; spf=pass (imf04.hostedemail.com: domain of fweimer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=fweimer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686659857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+b1T4bP+M0GcWXoHUW/q06urYQjMJ7X0Y1cHVDwah1s=; b=LdV8QD5RC0H6yi6he6cgIQmM/77K2AWzYcxHE29vRWCzEn1dfIsXIZ8PXZ1YAiUEiYb4Nt 9HpwNbF9AXFMzzWe43Z+gQWwhH8/lmJCIjI01dkjJSdWY4NJTs3NE1BGyhoLdZm0wDLUcR 80Tag4TxSMNnuBfpBZYYeRonLyotcNc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686659857; a=rsa-sha256; cv=none; b=mY185yKYc0LJIliD0g2ayM4P/mcElwgHV2LOgnoNnTKaZ9uDBDGNBUJZq6+1H13H3u9fGF nwauvN8Lsu5LYQ/u6GlYCU6JMHrsK4BxsO47Ra8AkHJKcvfZusM8lVikGin0ChO+EnTgeI 2+t9i14wLXojCYhXbYbM+tF4hEACxzg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BP+MRJ8F; spf=pass (imf04.hostedemail.com: domain of fweimer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=fweimer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686659856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+b1T4bP+M0GcWXoHUW/q06urYQjMJ7X0Y1cHVDwah1s=; b=BP+MRJ8FkEKapXS1gt6x/qtFvAcmAKfkxW6iIF6qnKdwQmFsGix7vpx1niJWEuZSYStzub SzvKeHa2fbEwMkb0QZCp76aQmOWSKnwxl2VwP5GuxxkKPDl//OT2gNDA0a6GggjeSr7CB+ NlM3UOtAtxk3xlVDES/U6Su8UcpKfgY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-505-NQoKV6qBNHuOgzR9uwg-rw-1; Tue, 13 Jun 2023 08:37:31 -0400 X-MC-Unique: NQoKV6qBNHuOgzR9uwg-rw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A8B3185A5BA; Tue, 13 Jun 2023 12:37:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 652C41121315; Tue, 13 Jun 2023 12:37:20 +0000 (UTC) From: Florian Weimer To: Mark Brown Cc: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com, szabolcs.nagy@arm.com, torvalds@linux-foundation.org, Yu-cheng Yu , Pengfei Xu Subject: Re: [PATCH v9 23/42] Documentation/x86: Add CET shadow stack description References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-24-rick.p.edgecombe@intel.com> <0b7cae2a-ae5b-40d8-9ae7-10aea5a57fd6@sirena.org.uk> Date: Tue, 13 Jun 2023 14:37:18 +0200 In-Reply-To: <0b7cae2a-ae5b-40d8-9ae7-10aea5a57fd6@sirena.org.uk> (Mark Brown's message of "Tue, 13 Jun 2023 12:55:48 +0100") Message-ID: <87y1knh729.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Queue-Id: 3300F4001A X-Rspam-User: X-Stat-Signature: r7c84y5x95jm5716ufzny6sc3j8basyb X-Rspamd-Server: rspam03 X-HE-Tag: 1686659856-764464 X-HE-Meta: U2FsdGVkX19FW8e3Dhryf2lI83VAq8EH5QnG6gDtGHJp1SetoueCe6VsHQ5smNbfvGWihlK9X03fxVRrlE+paFGyBUAr3WaJ+3w/1S+oO05ZXD4ea8jMos083UKtp+mIKs9gHCWjkQfjbL1tnOScH7UNNhyHMzR5G1RkH31HrfWoe6ElZjZxCvqL4w462liG4utEphcq4eABpAs5WAj6Z6XMV5tY1cGRjRDsGkCcvsjgeOeXT1ciCCBcVIEyvNwuzOEI7drBq0IRB171mDUxX8UXVfqGwud9RAlLzX1O660Y3r7qSpVgCzwfZMbpi9f++Z4CLX6gNQrtQTYG/kPessvCm6nrhDvyispKdb/TLJ4TcVfcgfmuBDP8km8hCleADWdEPF4owNm6tKxAwxJnHbCPPN/VY54vYiso+CYz8/EK0dhpzJrmKrWaG7wuekJxJoSDMCa9lJBHiOUF73Z1jk1Wyt27UM/pWfWo/ILtwLkmMbkEjTBwGKlsE5kUOSzj3BT1uQ2acbb8ZbhO4V/+znj4d68JfCAoB0a1PoSg9t/IAXtbTof3dCYydfPR5b8C0OFHIO9sU39iOJNOuFqFLBegcdk5jryJhgUOUeOVptYFPvSlp/KUS7P9hDZko1xQqeUTy1plANyf3ZX1sF6mPC5gaaorwGe222rOwiBx+3VtLf8YneIA4hmQhBeng1E4YPewFO7jRZkKqoAWPWEfM3Xc3OioOu2HsgBdW2Xlw3/tUeQePMLhvVcC14JXmHSspQCPEzCA+9skQ0ZpKyR38ai5SBVJvM61kj5yPdw9/kIyDepStfwOuCBjCVHfRWFwtxJMslwjNpPwBRumvea9iSDdWNoBw4txX2FlWgNj01B3SVm+1vcsKVU3Css1MtfR9qhatw63L4F1oR19ABjlsRMM4cT0+rjt6astpVKtWKSpbIoZNAtaCDrVPtWdLZ3oGjKEvTvzitHNXhLYMSx HPfAr+/z d4VEroDydWUhdFCV10/Enh9yYWsPJXaBWszOmnVuJoITWv2p7cn8VEMu7SZwOYLT7dSWJ6eir6StpQZVeq8ScIFhgj0QRXIQCTO8EddqLcMoUl5iTLX5RE639aUXy0FwEPza5omxzMYOeVMXlt9tsuHcEA2LoS+ykuohVj6hFn191WituP0Uk+oOGrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Mark Brown: > On Mon, Jun 12, 2023 at 05:10:49PM -0700, Rick Edgecombe wrote: > >> +Enabling arch_prctl()'s >> +======================= >> + >> +Elf features should be enabled by the loader using the below arch_prctl's. They >> +are only supported in 64 bit user applications. These operate on the features >> +on a per-thread basis. The enablement status is inherited on clone, so if the >> +feature is enabled on the first thread, it will propagate to all the thread's >> +in an app. > > I appreciate it's very late in the development of this series but given > that there are very similar features on both arm64 and riscv would it > make sense to make these just regular prctl()s, arch_prctl() isn't used > on other architectures and it'd reduce the amount of arch specific work > that userspace needs to do if the interface is shared. Has the Arm feature been fully disclosed? I would expect the integration with stack switching and unwinding differs between architectures even if the core mechanism is similar. It's probably tempting to handle shadow stack placement differently, too. Thanks, Florian