From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB099EB64D8 for ; Thu, 22 Jun 2023 04:56:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30EC28D0002; Thu, 22 Jun 2023 00:56:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BEAF8D0001; Thu, 22 Jun 2023 00:56:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1865B8D0002; Thu, 22 Jun 2023 00:56:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 082C68D0001 for ; Thu, 22 Jun 2023 00:56:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C97281C8A7A for ; Thu, 22 Jun 2023 04:56:10 +0000 (UTC) X-FDA: 80929172100.18.B631A66 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 2680780005 for ; Thu, 22 Jun 2023 04:56:07 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UBpFByEM; spf=pass (imf30.hostedemail.com: domain of bjorn@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687409768; a=rsa-sha256; cv=none; b=nTMH70YBfBUy2Up6JJztWeo1MvnYAyvPACo7ZMC1OZ1nk9X4k8+OidrGJ/CE/sG16cEQ+k 4ZbDMiHuD907zaVmj0Ht7+HLv1+Tnd+Lo98m8SxA9fNoGD6vkVhmVhTGwk9zYEMUydJJmE 0sVBxNzdrx6CUWTagysJujuS8a3xNSM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UBpFByEM; spf=pass (imf30.hostedemail.com: domain of bjorn@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687409768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VPg3Sj0fi+g0bepTk1i/ktwXZ1u6q7dQfKv1wCwZuQU=; b=X334rGHgIvf06iFH0lOTYcBsMsdotb6rZkWR3t5ieCSPjF4HA/AHDO97v3pN9XPJbJRbin zcSh8oWGMIqrM92rb3kiYjKTGvblzeokSZg0jue1qInZztv7b3nc6ntSVxMPoSj4BI4w19 nTCe/+sdV8/PBx0EJzk4GWxF0sipRP8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3763E616AA; Thu, 22 Jun 2023 04:56:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51232C433C8; Thu, 22 Jun 2023 04:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687409766; bh=g7D6HBzEigVjHztCXXrF3KEb3b7m425hu9GVu3l4Q2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UBpFByEME8DHHgZfpMLxsOftIX/Geuj9XgTa40W7vsgj0Q1NItCXIdzDyyXC8LEMz Dl0TF/XxzLn0/S5CQf0ezwE87ckKMEby4x45rr/snH2Yk4dHit9lHL4p8dLn3i/Ccw /2BB8CZMUDKC/zJVxMM5M6n+67HximIqY1ufCtYxMgfoqsWVn+CbpMLsmnTS+NPogz dd7gpY6jcCi3CSAwchyzoVvMgdf206spTgGOvjqygOV5TwvEvHRBtfwySmnPbOdgYa ooJtBauPXcp5WVbqN4qT4qzKvwDgybR+WogGi4xNQtpm21WQv1aMqmzfDqn/Wuxy4d 8jdv+rbXkq+cw== From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= To: Palmer Dabbelt Cc: Paul Walmsley , aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, Bjorn Topel , linux-kernel@vger.kernel.org, linux-mm@kvack.org, david@redhat.com, osalvador@suse.de, virtualization@lists.linux-foundation.org, linux@rivosinc.com, alexghiti@rivosinc.com Subject: Re: [PATCH 3/7] riscv: mm: Refactor create_linear_mapping_range() for hot add In-Reply-To: References: Date: Thu, 22 Jun 2023 06:56:04 +0200 Message-ID: <87y1kcumcb.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2680780005 X-Stat-Signature: b81tqgb6qh9c7shy5b5porraekcd7hh7 X-Rspam-User: X-HE-Tag: 1687409767-541843 X-HE-Meta: U2FsdGVkX1+cBCJOubNGpoy6GbuYUoIFvKcpYR4AGe5nJpSC3Cd7brk+ykyb2rJ+G0L4uSDeKahc6Of1jhEbzn0fDqhMefe8w9MK6EIt2VT4AzZ0EmRNQFzbeaLilW8VwcvCmmg7XsNtf3UaBs6wPHAiyxq+ODaxXBN3NZxoPA6p6XeIbfoy8+v8rN/WIi4InO7+VSpNU0r6Yt8SdOROgixJ/WDnmVzYShEHbJu0MmXcrcMPuwHj4qEbjYsXQLy5k3sAwZZW+rdp/Lj14OeOghdoHSzujfBNUy5usTjVQlnKfTG/p/JWbBZMEpjQa91j/dICwRZnbetfHJ1kmmuBA9PxMu8geIfKlbLC48M2ZsFnjlxeMOTRzc6aJVHgDVHcGEzN/nTQy6xh+4svSrvh4/avdOlqXnDVXpt7G24rSuJ68rbyxZDXbExD24eYhlwPXjWb41IziaiIvN+TMSuj7HGiJcGq1Vhc85gbxFpyvE7Z0FTuSQD9fQCoQS2OvmTbt1ayVvPL1OUxtOnGz78L6b560IjHUbZfBNS8BrzsZOqyKnCKZMdYFBTeUylsFzzkkZHRAX4kqRZi8xFMvnNpq3ZeirAtRcrf2Whr5bDZxh88KMethMgnPhdgYDIreEC5xIkLhpZ9pYl7A5pTdhaowBvbi6j+AKcBynFa7JylGefiylnQrPOD++hmZ0ckhX4fTkoqV/ghZsjTohaElAi1+ooKjJGkC032Jf5XPeoHdJDLn0Dz71f0xRusLbOULskmXbXeGKdOXnJmygVr3CBudPZqJQRlhYLGclf6A31GGGZjFMdQNVPg6X7prUmbnwHk3jwm8FGCtXw6CiVURFj1v4IXOboWwhBfSejY3kDvJxdqk3/jiQw+zsVpI4n7KHxCJJiu/FipIFtXnPI++Mnw5c8mJWVhCNj1FUDbNHWuK0VSUA/Vm/lX1OeBzzAhZXiwsnXKSW8yVyqpvHK9NEw Yf8WwHSI GkrP7j3mmV+IOaG+kzS0m5qxsvyB6M265YFT2QImsocyXZPgdUCi8N1CIFO9jcasAhbfOo4dxso9TN5PQTQPsZSHmYX1JrdK81B51yvgU/QsVzhyAG9kVE3zP214nFf6QRNVmrX3V/ZJi9kdy8uPxG61I5mTOhZbNX6EPSABQqbSPQJApWuAb2sbq94lIUxl2yD0SkczBiHdY0rCDlflPI86WuJzzJ1VfmtTt9gwxgk4oZe69Lmw2yHmX+krjiMzEVHIF9TcP/CFhGXJkjVTpRr9NVPUmKDRWZH0Xa2v7hTNhMAzNxpVfYZPX9a3YQkjfw0qpGHUzxudOMmbrrGFktm7hJ4CPJ7++JEPBREDOVcPNd6dTefWE2rYZpk8tzJLOJBuwpIsqVetY6LwQ54n+1yCYCrzA2/oMrTqYJMAaKUIu1UpURBiQxfjnv7ozwfZl74D9o+wV1Oto8U7YiNhEN0egCjvF0Y+dERITAZ60j2Fx9Frx9bEIZpdbhAwWwKJC2Fpltm4U5uXZj4c0dNa4q7zsZDffZbWf4Q9rK3VRuklgmw2qWzeTEUY1o/wPfFxInilBAFQjB5VtSzmfDt8UqTrICQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Palmer Dabbelt writes: > On Fri, 12 May 2023 07:57:33 PDT (-0700), bjorn@kernel.org wrote: >> From: Bj=C3=B6rn T=C3=B6pel >> >> Add a parameter to the direct map setup function, so it can be used in >> arch_add_memory() later. >> >> Signed-off-by: Bj=C3=B6rn T=C3=B6pel >> --- >> arch/riscv/mm/init.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c >> index e974ff6ef036..aea8ccb3f4ae 100644 >> --- a/arch/riscv/mm/init.c >> +++ b/arch/riscv/mm/init.c >> @@ -1247,18 +1247,19 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa) >> pt_ops_set_fixmap(); >> } >> >> -static void __init create_linear_mapping_range(phys_addr_t start, >> - phys_addr_t end) >> +static void __meminit create_linear_mapping_range(phys_addr_t start, ph= ys_addr_t end, >> + struct mhp_params *params) > > Sorry if I missed a v2, but it looks like this fails to build under=20 > CONFIG_MEMORY_HOTPLUG=3Dn (as struct mhp_params isn't defined) -- unless = I=20 > screwed up some merge conflict, but doesn't look like it here. > > I'm getting > > CC arch/riscv/mm/init.o > arch/riscv/mm/init.c:1252:58: warning: =E2=80=98struct mhp_params=E2= =80=99 declared inside parameter list will not be visible outside of this d= efinition or declaration > 1252 | struct mhp_= params *params) > | ^~~~= ~~~~~~ > arch/riscv/mm/init.c: In function =E2=80=98create_linear_mapping_rang= e=E2=80=99: > arch/riscv/mm/init.c:1261:42: error: invalid use of undefined type = =E2=80=98struct mhp_params=E2=80=99 > 1261 | pgprot =3D params ? params->pgprot : pgprot_= from_va(va); > | ^~ > make[3]: *** [scripts/Makefile.build:252: arch/riscv/mm/init.o] Error= 1 > make[2]: *** [scripts/Makefile.build:494: arch/riscv/mm] Error 2 > make[1]: *** [scripts/Makefile.build:494: arch/riscv] Error 2 > make: *** [Makefile:2026: .] Error 2 > > patchwork is saying something similar > . Yup! Thanks for pointing that out. This series has a bunch of more issues, that need to be resolved in a v2. Bj=C3=B6rn