From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7931BEB64D9 for ; Mon, 3 Jul 2023 03:09:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2F498E008C; Sun, 2 Jul 2023 23:09:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDF778E007C; Sun, 2 Jul 2023 23:09:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA7048E008C; Sun, 2 Jul 2023 23:09:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B8E1B8E007C for ; Sun, 2 Jul 2023 23:09:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8120BA02AC for ; Mon, 3 Jul 2023 03:09:01 +0000 (UTC) X-FDA: 80968818882.23.4AA6BB7 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf25.hostedemail.com (Postfix) with ESMTP id 2C4B8A0004 for ; Mon, 3 Jul 2023 03:08:58 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QC30Ab5I; spf=pass (imf25.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688353739; a=rsa-sha256; cv=none; b=sF0xYOJQL+9clF304k5ZaddQjJ3XwrwV6F2G/Ig6lj7P5fJIm19bRUkkj9NVry+U+RNEwx D+7R6IzHSY3OKp514QC8zd7NFYlvO/O8wZBmumprHb+Hodw1Qcm8k0agjEG3c0F7NxnDFc KWq33wvSOWD41UM48w1/g4rsENkmo1k= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QC30Ab5I; spf=pass (imf25.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688353739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W03CU9hslMJ6bm3LcF0IRTCQsFR3n1CvGN3vmNyOzD8=; b=RHiABDAoVkBlZIbepWCCShSvSpAcvO70crCXFT/HftyBiz2D1+4taa6Tif2Tfwex7HGUZt YNyYQZcyrnVoCZdwrmQ7XiTBgw9UfpIs1ajIysqEWaXIU5vf7rQk4RfZThSoPaHRiEsRw5 q5PqhgWEKCwKaa3Yy2rC1R7jzMZa2m8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688353739; x=1719889739; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=28fVWHfTctzsX3I4FYEz3i6KXWN6TH8jJXjBb77CiwQ=; b=QC30Ab5I3nOseL6Fg/sTzq5sj/ct1lTOe4LiHLMp++oQGn8NlxuMmBtv k9GPf1dAjkJkugymKyzUotsyCXRynmqMdzAHe1PUulAoYz//dRKn/VyUZ JvFDdwsOSBLFpcFGgyhOLRTnaIMo2H/LUaqGrtfYYe4kvWdoPj9c+KswT WZxYC9mJKNFRB0O7qjwf1QNUUv/pBlTUkwhc7F/7QgxpfRY4ihM0aTwxa QPQrWl3I88ASMOGYeTliE9sXSaeT/Y9iVVYv1bSZKIrB7IMiO7Ckb5ZwU l7tGFxP5kteOUKmFwkaq2qfMTvmk7YELnrVJ6xcy1aCLAmfXiRRVV3D0o g==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="343111528" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="343111528" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 20:08:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="842505844" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="842505844" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 20:08:55 -0700 From: "Huang, Ying" To: Miaohe Lin Cc: , , , Aneesh Kumar K.V Subject: Re: [PATCH] memory tier: Use helper function destroy_memory_type() References: <20230626121053.1916447-1-linmiaohe@huawei.com> <873525k9tt.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Mon, 03 Jul 2023 11:07:18 +0800 In-Reply-To: (Miaohe Lin's message of "Mon, 3 Jul 2023 10:53:48 +0800") Message-ID: <87y1jxitg9.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2C4B8A0004 X-Stat-Signature: jwm4uaw6h6ko56imjhckz1bapx84hkdd X-Rspam-User: X-HE-Tag: 1688353738-204358 X-HE-Meta: U2FsdGVkX199jiwg8DzE+Ynsnwi5omhnz5HG5BOJ5jWywtSsfRv+JAowG2Jk/ip++YS6ByQRmsVhQBFm6aFidVc2c1wFezyKxZirejP0oXMqUooMOm3thPUUGToIjJSSWSGsVWo3P0wiZQDpOeFa1Np6hy2/2ftI8XEEJ0xl7D0RAkYLx8AkTEA4N0ReZvqVcSWV0S7iXfZaWlW3pu1/mUltkc7yiXXQVGuQVvCFX4FvIX7FE/9SDy568vGfO4knQCVZmidwkxP7RTuTfugtGp3UlMjoBbYrRhVzyYxkxPcjB53dvN8Eu3WJqayOZmtxqdgrEy1XRLKMD6WpT4TMSxrghdqF9JRXz8xDNjjeDii7z4hgiFSIcDG7YTQLPDewqblBnkRr1uHvMCzBhkVwufGmHeLtG0FQNBlOR4rwGR6ty7C7SR6vMze9A5SIn9OwW9jEpXbVCi7obIdMdj8CGAMKYuMkeWmjscRa7bgPFJZ05bg0xpnUPksmRnKzJR8bHpk+m0Y8uFjVrle+2PtjPwc2Kh4Qj7lraXxbWbihasgFpOn7fCqXb3odAs8GmxTWqvpJ7yNK/vnac11226tpGfpNSAKA/I4kvDtL0sn58626jshlBQXJpmWN2Ly3MwhhdRvFF+SbaFSQfraEmT7x7tAsllGpVobCLvAJJCwW+0cvgg5rgVnwmADfDg9ICeHSZ04HGnDiZzBcLYLiwHsVh7lYmf8bgErZGWtaMwWDoP2sO68XS5k/y053tq36xEE1N1MTBztZpv3gqKDeQ/8N/gEjrb2Ccvz9EaA4h+5K/ZpGQkIKxulHtqcx44+AT2guKQyw903FMIzArBkfVJxfQX1RuMRIFLepoWIwLErxu90sghLg6own60+bA3966/Mzgoh1H+hnZEJMJ4GOwl2P7xX7a72x4rThC4sty90ybMaxh4jwDCnK7h06F/vb0XaoDHnge6vQ8DS3N7YzS8E Ec6b2rIz T1dNuqs/y90cN8WzO+1BD150EjDlNvOjg+SqwUQ0fdA7NtCa46CjPzkJDi5tvjxcLGFIZvrdQfZpPA7sigTry5ksV4Nut9jYtLYLzaj2txdjgi4H7lBzO4pKJ+86q85GH1lbxWSMXxiVVjdM1n1rD1JO/l2v/UohFrUXDGgbwDT8e8Wg4G41VURDgUF29ZkRzB1wDJLV7b+bwVU4G4EbtJxTSnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miaohe Lin writes: > On 2023/7/3 10:28, Huang, Ying wrote: >> Miaohe Lin writes: >> >>> Use helper function destroy_memory_type() to release memtype instead >>> of open code it to help improve code readability a bit. No functional >>> change intended. >>> >>> Signed-off-by: Miaohe Lin >>> --- >>> mm/memory-tiers.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c >>> index e593e56e530b..0b8b76078c12 100644 >>> --- a/mm/memory-tiers.c >>> +++ b/mm/memory-tiers.c >>> @@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) >>> */ >>> if (!node_memory_types[node].map_count) { >>> node_memory_types[node].memtype = NULL; >>> - kref_put(&memtype->kref, release_memtype); >>> + destroy_memory_type(memtype); >> >> Not need to be changed in this patch. It appears that >> destroy_memory_type() isn't a very good name, because we usually will >> not free the memory_type here. Rename it to "put_memory_type()"? > > Do you mean rename destroy_memory_type to put_memory_type in a > separate patch? Yes. > This sounds reasonable to me. But destroy_memory_type is a > EXPORT_SYMBOL_GPL symbol, is it fine to do the rename work? I think so. This isn't a kernel ABI. And not many people use it now. Best Regards, Huang, Ying