From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B25CC001DC for ; Mon, 31 Jul 2023 11:14:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 184A0280026; Mon, 31 Jul 2023 07:14:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10FA3280023; Mon, 31 Jul 2023 07:14:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1770280026; Mon, 31 Jul 2023 07:14:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E004E280023 for ; Mon, 31 Jul 2023 07:14:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B0E95A0AE1 for ; Mon, 31 Jul 2023 11:14:13 +0000 (UTC) X-FDA: 81071647986.29.81AA578 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf10.hostedemail.com (Postfix) with ESMTP id 96036C0020 for ; Mon, 31 Jul 2023 11:14:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=metaspace-dk.20221208.gappssmtp.com header.s=20221208 header.b=eTpl40uc; dmarc=none; spf=none (imf10.hostedemail.com: domain of nmi@metaspace.dk has no SPF policy when checking 209.85.221.52) smtp.mailfrom=nmi@metaspace.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690802051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a+yXtCYwJ1vp4lh1G4+6nAEpCQWF+yOkcXs9SOROqGU=; b=hDcjP8UbAvJAgHGYfQHmocCH2zFwfxuwONwuRxeu0YditnTodN48/2ejeU9m7PydIDUllH yXmo2N0t0Qzh6IzG6EeFAS26cpN6Zen9OQ4xrqZJMLvW7jBRHW6Xi0p76GTAG6o+muUPre fN3XDxBEQSgIFVf+NQp3my0ts/369ww= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=metaspace-dk.20221208.gappssmtp.com header.s=20221208 header.b=eTpl40uc; dmarc=none; spf=none (imf10.hostedemail.com: domain of nmi@metaspace.dk has no SPF policy when checking 209.85.221.52) smtp.mailfrom=nmi@metaspace.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690802051; a=rsa-sha256; cv=none; b=R8kfuSvGWk8ki5vmrDWzZH+rzzPpvP9iIIvUQUeMn0NsPNDaInQR7N/tnD6IZPx1iuNSLQ MtvdT3I67Cu+FYsWUorxUUsls+waU2ryJ+NExV+QoU3ODOsISuvmxTDzIBUA8O4EceBceO 9rDzgD0OYCasGKMcj/6B7aAPFzNF09U= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-314172bac25so3870573f8f.3 for ; Mon, 31 Jul 2023 04:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=metaspace-dk.20221208.gappssmtp.com; s=20221208; t=1690802050; x=1691406850; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=a+yXtCYwJ1vp4lh1G4+6nAEpCQWF+yOkcXs9SOROqGU=; b=eTpl40ucewCsFMrQBu0kMJ/J9h7WUG8ZwDVthoX9ympKu1DDdzDGoSO4pfrbo1q4lT VMS2+6v5e4TcA1hj9UFwPgxEyUDPkKJEwzZkpfIo8iP9o7XCUCImbYbPBqW+q7CnRKst Lj1gL/d0bPyzvYAqpNII4QDo1S+u14uH2I56NxuYK2EgrlVefWuAwtT8+se6XUkAHXYJ tlimaNnYJp3U8U6ab+VBF2UNMFetpuFVB2TrTC8EDnljcFGNBjnMKHzgPOo/Mf1BCnDm +tC8P4rab6qd/cVIyFbr+CMqsXXpHpuHX2mC8ZCH/+uygP6vpGdG4zxh4axf/DGg1Sz0 LYJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690802050; x=1691406850; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=a+yXtCYwJ1vp4lh1G4+6nAEpCQWF+yOkcXs9SOROqGU=; b=KqlFpBWLov1XN6l599mBM474QaaJu6Mj0XfFhL7htQ0bxV0grBBHxXlPfNtARudTVR 1OwDdAIoRqixHQKPHPIJNTP4HQupEMzgVuHyBtNaAS8sQns0suLzqfVnN+Z8AdKfqHaG Jeo0hXJZNCFWK5Lf7C9jlIbYWG0GniurmrTpUfVwxtFFkE/2z0fwjBnrOqkXMh7BxX/1 3I+QNf8d3Ss/BejfT9nGyk/SxHwhYWsIbv+L2B3FEHqQMkUYgsLDRk42AVZE58rvGaIJ wArOdVE700lVimCPEVDqouHg6US7ZUCengY5h0WlQ78Tgs8rsA3ONDhRRu31dBq07SJX L7Bw== X-Gm-Message-State: ABy/qLbjDE8LFRlQ+GarBuRznd1U7ojv/IKE0DU/AjhuJPSduou2kQ+u k7yQ0OG+R1M5SBZfFDE3u02HeA== X-Google-Smtp-Source: APBJJlF6tBQNOBgzMGTKGd+XwA4tKDou2MjpSwYuH4U0eRW22f6ni/4ZHQfT3TJzV5b6WDQPTzegYA== X-Received: by 2002:a5d:452f:0:b0:317:6262:87af with SMTP id j15-20020a5d452f000000b00317626287afmr5251217wra.16.1690802049408; Mon, 31 Jul 2023 04:14:09 -0700 (PDT) Received: from localhost ([165.225.194.195]) by smtp.gmail.com with ESMTPSA id z7-20020a5d4407000000b0031766e99429sm12713940wrq.115.2023.07.31.04.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 04:14:09 -0700 (PDT) References: <20230730012905.643822-1-boqun.feng@gmail.com> <20230730012905.643822-4-boqun.feng@gmail.com> User-agent: mu4e 1.10.5; emacs 28.2.50 From: "Andreas Hindborg (Samsung)" To: Boqun Feng Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Dariusz Sosnowski , Geoffrey Thomas , Fox Chen , John Baublitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , stable@vger.kernel.org Subject: Re: [PATCH 3/3] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl Date: Mon, 31 Jul 2023 13:12:17 +0200 In-reply-to: <20230730012905.643822-4-boqun.feng@gmail.com> Message-ID: <87y1iwpc3j.fsf@metaspace.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 96036C0020 X-Stat-Signature: u7ipoagpubkntjcmpq41djnm9r151wtq X-Rspam-User: X-HE-Tag: 1690802051-782275 X-HE-Meta: U2FsdGVkX1+LLIF1N5vFjtcNUt916bHhGmsOl6pjMzzk3o7EmXYdV8PteUQWnvr3K4M8c0x1G89swjFio7JA5SZMkvNqWtb2cyH31UNZAwEVIhZU9NIXPBKAzvYTrPQqPThEH2jcftiwEvOjkokqjtLs4Ns6ovkW0UYOM2pj1IW91kJ8yYew3jhE1+Eoe+Mz4HCscRr3Nf5ky1Wl6ttszkYJihqbApFOZ7Vd/mB3P4SKmSLLvbHmbf8+ILnmFlOzDGGUJwynXAmr7xj9UyVDmN21xAUIA0uuxfas6+hViCDA+qBPFJKhvkrFsI3ew57m7ozlIscKeEccIJNdLxx758PmQQV3yXH/qVFFukADq1yB+NR/Vw9BgpkDuKIugt62FkOZA98rP5kA0SFY/ZsS7PkiBa2YuHrvD2P7tDvNw07QraURIMWZR39r4ZWGAz6MM2V93aNSec+SatR2CIpLLo5E3EEkBasTonJj3xQAxs4NtzejoV/HVVDxoVF54igG+HlSZ9/mCm0NDFprBv42dKw8zLdnhHvxzxvWto5e6J1EY+U8unCz0+N52EIl3nWM0PbrlfSrseUiKSjEIheQBvzZWj0Xn5hvMOnuoCZk21T8TIWFpjv18X0r+3+5l2NaQdqYlCbwwa9kEAx0lsAMNaovMLKRRiBWL04wBn/KmjirJTyR4NsLg5n6E1GQchzeZMH6aACJBmsp1zKUYMqnFb+jdJLgrV4RomNmOUOD2rydJSNrbtH7SwjGRaP2EplG0znv7jhPgpLpYh/0ORPU32pLEuNF+MmUl63+ydSFkvSsq2T+kSIXJn8Asq4OUeolVLDIdSHhFKdJ8Uvs9HBn/SLlminiVjHP7GLqnKNWbrySGc0tdsO5KDxtd6OeU2w1LH2OIHFa+8nDBvnazzs74PjWv74UMBXi8+3avPOuCZVfojCkJqJpnwAo7F9jEfgq0u8wzlM+0r6UbkwJ33j Dn1Am21s zh4PbfGBA/qGTmg4V0fTeYjJl6k1DfipBEo0QsgUsuD+oVhugJVajUdhaZQyV7CPCKQwjlL6rUkRO+Pt5ag4PsgrjvqpuECH/Zzgv5EJfXS60mlZaH/xWTRhdbqcmmXRwYf1tzslBRlHOCm0bdflerLALgiLJYQ0ni+m9l6M3Yt/YPCl8tbkZFwjsJdpZdmkMCSP2jY8d0gFjwgrxoDZyxds2kw91QGhcFrhR+42nrI0eOTvQNV+BwVdaQnigiPRyBq/3+cHvB07B+L2Dxo/ucTkntyJGElBxRDz5ugh8n17yN8NDrARiCEezYIRYPysY4InVDsZ0qVrHIfd3mn0yFmZS67ojp8+rzqkzIYsJafgCMg0Ul8fMQ8+aYJfofdK3Q11ikDOYFA9o4b6TEZjNgOv7ODbMH9PZN69aAIsWUlskej4NRhsp1VRTRthf1CQJm0zKDOrEYGIXVaLIR2wUcG/fzfOYgzulFeXODlywZEpVG41yJsMf8rUkgiAcl68j0jcSqsvr1kciL2T+3R46ZE9ttd2qKgg9TJEr+FqWlJM9JiA4NltkdmpaDJHbdzUI8O2FI/mOTFLaSf3joxus+5OmoRCMwJKrpoy3DMLPfDiscBVcF31S9bMjHNAl1Y+WkGN/GiqMvX/R9XKpzmK5c7GVcQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Boqun Feng writes: > From: Bj=C3=B6rn Roy Baron > > While there are default impls for these methods, using the respective C > api's is faster. Currently neither the existing nor these new > GlobalAlloc method implementations are actually called. Instead the > __rust_* function defined below the GlobalAlloc impl are used. With > rustc 1.71 these functions will be gone and all allocation calls will go > through the GlobalAlloc implementation. > > Link: https://github.com/Rust-for-Linux/linux/issues/68 > Signed-off-by: Bj=C3=B6rn Roy Baron > [boqun: add size adjustment for alignment requirement] > Signed-off-by: Boqun Feng > --- Reviewed-by: Andreas Hindborg > rust/kernel/allocator.rs | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/rust/kernel/allocator.rs b/rust/kernel/allocator.rs > index 1aec688cf0e0..6f1f50465ab3 100644 > --- a/rust/kernel/allocator.rs > +++ b/rust/kernel/allocator.rs > @@ -51,6 +51,33 @@ unsafe fn dealloc(&self, ptr: *mut u8, _layout: Layout= ) { > bindings::kfree(ptr as *const core::ffi::c_void); > } > } > + > + unsafe fn realloc(&self, ptr: *mut u8, layout: Layout, new_size: usi= ze) -> *mut u8 { > + // SAFETY: > + // - `new_size`, when rounded up to the nearest multiple of `lay= out.align()`, will not > + // overflow `isize` by the function safety requirement. > + // - `layout.align()` is a proper alignment (i.e. not zero and m= ust be a power of two). > + let layout =3D unsafe { Layout::from_size_align_unchecked(new_si= ze, layout.align()) }; > + > + // SAFETY: > + // - `ptr` is either null or a pointer allocated by this allocat= or by the function safety > + // requirement. > + // - the size of `layout` is not zero because `new_size` is not = zero by the function safety > + // requirement. > + unsafe { krealloc_aligned(ptr, layout, bindings::GFP_KERNEL) } > + } > + > + unsafe fn alloc_zeroed(&self, layout: Layout) -> *mut u8 { > + // SAFETY: `ptr::null_mut()` is null and `layout` has a non-zero= size by the function safety > + // requirement. > + unsafe { > + krealloc_aligned( > + ptr::null_mut(), > + layout, > + bindings::GFP_KERNEL | bindings::__GFP_ZERO, > + ) > + } > + } > } >=20=20 > #[global_allocator]