From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CC8C001DC for ; Mon, 31 Jul 2023 17:12:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E1C9280088; Mon, 31 Jul 2023 13:12:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76AEC28007A; Mon, 31 Jul 2023 13:12:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5485D280088; Mon, 31 Jul 2023 13:12:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3CF7A28007A for ; Mon, 31 Jul 2023 13:12:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 98CC3C0B51 for ; Mon, 31 Jul 2023 17:12:52 +0000 (UTC) X-FDA: 81072551784.02.138A66D Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf04.hostedemail.com (Postfix) with ESMTP id E630A4001F for ; Mon, 31 Jul 2023 17:12:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Eo+GdN8K; dkim=pass header.d=linutronix.de header.s=2020e header.b="hziJ/HSU"; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf04.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690823570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NVJcIMq+A16+IcB9b23/dJfzVwN2i3jSPnGuLESWXwU=; b=lKjyzINM/09Gz+F5ZLbZLhPjwxKGjg8/iA6ZYubNkejkYaD0oUo8hiIW7WUtY1vP4E1ovO /QfUvX8wW4v0c/WXcDsvLIHKAY2twWj0pG5pRDFd9u+7T6pUrJc22BhcGeJ6rZHGLurs+7 dVdkrEg8/Qr4wc/bC/aDGpLv1A1DyG4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Eo+GdN8K; dkim=pass header.d=linutronix.de header.s=2020e header.b="hziJ/HSU"; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf04.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690823570; a=rsa-sha256; cv=none; b=OdR/OKWVqcKnjkgUm2xnvjfxKvPBGxXaXgG/toS+kJC8IF6QbbYrgOSCacW2ymgKGQ4Kmj AgtVpdWiXLSuXVz2HnIVXRgksrVqoDyMxRgXXoEDveiQlyKmeQ2+/2cFMGmYTDuJcKQ6x2 3KzOJNjM7V4yQ0tGJsY5r/PusS07zyg= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690823567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NVJcIMq+A16+IcB9b23/dJfzVwN2i3jSPnGuLESWXwU=; b=Eo+GdN8K0pBmO612+PieVaC3ckEtUeUWiNBdHnP9zA+76wue7l0DTxUuNENb6j0Y62dGmB zlROcFdnMNMoN5KF50nw9Zens+gzszFOYX2KrLa9AlpP6pagTvzj+kjJreWRZCd4S+4VFt W60Z1///m5n2Xm2EisbxjSr9+SANi9NNLZ11wGkaeyB0F+Gsjr61iISJysYk2U5Znbw2M/ qZ6ogZwhkx+rXUE5tOqiWJCgdy85NQsGUljrJPkGXDzlRqhdr4RnbH1Auycs6Bm0cFm1rY P7fyMrsSvnisqr5BGpEjx4pCOFdrF2Vml2PPeMlSbmuIVI5v28Izu9vGPHV/SQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690823567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NVJcIMq+A16+IcB9b23/dJfzVwN2i3jSPnGuLESWXwU=; b=hziJ/HSUvoaES2uwBGC27GHIPrlflFgMtjtsRDlBaxjsKM4GLmXBM9mKhYBhkhOW3G1CRF 7A6QmLUgJhzZz5Cg== To: Peter Zijlstra , axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 04/14] futex: Validate futex value against futex size In-Reply-To: <20230721105743.954526690@infradead.org> References: <20230721102237.268073801@infradead.org> <20230721105743.954526690@infradead.org> Date: Mon, 31 Jul 2023 19:12:46 +0200 Message-ID: <87y1iwm2cx.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E630A4001F X-Stat-Signature: otde17n9dp4539x8jezx46ru9scah4f5 X-Rspam-User: X-HE-Tag: 1690823569-293035 X-HE-Meta: U2FsdGVkX1/rOlSqndHUJ3BstyLFUYx+BFeY4MGAOKsPyq91A5KUdiAlf6ABefi9PNxtOTrsHxgVPTS/X7X5m0L0HfZksdgTiPn54pgIEoP4lXW2VMgpj2ajLVT9ol/6wjAok8w7SWNAtalcOsxHs2EIF88IQc0ucWKr7xtNUVxtqc2YWyzxg+0s26O3WH3al4oXL12mQReCIXUD+aIhYTHLK3YlPoSytWHtIGdm6HSUi47vNDTm49Z2VIUKAxPAYuXAEAA7CnY9YO04iPvWY+GPn0eacnNy4VjtlJ/OLImL5s+DZ1Hv9fJ6G3R8eINlHK9dfzQqZ6AGbNJcFOjSm15lQZMqRyIC1IIBO04ZBFLRGjK2KgkOS500yctN0cSBnZahDkvNNO1gHa0Y8Qh3Cn35lLw2W6cypWjOalgyjfNRByXdCKvLUHtulmS+5D3Uwe3m6bvO12gWsDrHPYofwqC7/05FgC6Tis3wM+dJJOQyoW0BSys2vmrJgoxke1zaqxHafgVfse27E4Tym+TnLgYbLMSVKlbcOfZ0CPTtgb+yRDeeTRdwr8d8Bb12cwy8u1ZdYIrWmdZbqir4ZQu/y6o3vRNjSsi25ZvNGcetmWGNAYVwFQe99DzlCD1OELghyO/cy4GTgAGSKu2sLQ9OI2D9roY6MK5VOsOvZLhoHTmuM0OlHdUyEhdUxTTYhr0pMOfABDi0c1swAoL+cg2z45oxjeg58l6xYJKA5jUk4KJL2A8y79eGd77c09PN5PdnnXF3Tva7Q9hvN2H/QDKBppKGekY8mjTJqH0Z9TBOSuPMBFs8pH9i7gQxr7oohP+wUrcBUR+1MTtgkoDYyiMonHdMyJ7X7Ecmk0IJjH5TU8Mv4KMbvctUoUb9UPoHHAxUP2yUGbiHALkkZemSwk8ezdp1Wz+g0ma3tXYcMzeJzyt95pyZUrcD5pVGwWz9sad6EybO9dvOXYFrMg+G2Xf +OBgekpW CMaQQo2R/Me5+JkmR2VB6kINJalZpegK6xTdsKV13uVNpQ30= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > +static inline bool futex_validate_input(unsigned int flags, u64 val) > +{ > + int bits = 8 * futex_size(flags); > + if (bits < 64 && (val >> bits)) New line between declaration and code. > + return false; > + return true; > +} Other than that:: Reviewed-by: Thomas Gleixner