From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE8D1C001DB for ; Tue, 8 Aug 2023 09:12:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 439076B0071; Tue, 8 Aug 2023 05:12:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E91E6B0074; Tue, 8 Aug 2023 05:12:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B0AC8D0001; Tue, 8 Aug 2023 05:12:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 19A3C6B0071 for ; Tue, 8 Aug 2023 05:12:15 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C7437B2432 for ; Tue, 8 Aug 2023 09:12:14 +0000 (UTC) X-FDA: 81100370988.14.CFDCC2E Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf14.hostedemail.com (Postfix) with ESMTP id C5762100018 for ; Tue, 8 Aug 2023 09:12:12 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=NqxDxnpm; dkim=pass header.d=linutronix.de header.s=2020e header.b=AKO4JGVh; spf=pass (imf14.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691485933; a=rsa-sha256; cv=none; b=CX7xliMHluRxfRS7fPzWKos4w6yVoohlURhvvO2eYyFWykz44V5t+eXA55pLwpVgrwsi4k c0SM7Spl5uVSdQJLrxq47tM/LJ+TMefAq09xQDmci/ZHmm4tCWLa/3J+p+0x8KZlX6SHYL 5bsZYjmPZdPtQtitpk1c08xuKfMRI4A= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=NqxDxnpm; dkim=pass header.d=linutronix.de header.s=2020e header.b=AKO4JGVh; spf=pass (imf14.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691485933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DoNI5v5umT0Z8D7XCCNoP2aZrQ/gIq+jzyHgWzWgdgo=; b=bCh59RiZ/JfvdsY0NHVqe6Ut7D8O/c5VZkgMnPielg2/KlaqSmktG53uacg70rENRMkavl Yi+pD5TN71QgYKca+855F/OezNDs5603D2GabFnRJaGv7xfxjwTCpJyHLHagWuD95L9WVS m3z7DRYqf7KweoTAuX9ZLclpjhryh5I= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1691485930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DoNI5v5umT0Z8D7XCCNoP2aZrQ/gIq+jzyHgWzWgdgo=; b=NqxDxnpmcGRK6PtnO2RtI8BZQByg8ruKL7AL6OSKYguyFob+ikfLazgjxgzcUIJWkJhrIV Yd3n5dzvSzw5eVwwC0r2HOYW6OtbKaFSRM6SpqW5HBgBtS+xwvuxk7HIponmeb+5YGaRpK vmUnB89jlJlxzC0YFhTOSLlZj8RqGKax7LN8fMKvpWMl8AmHQ4jses991y5VE8KX5/bm9r Q9vK4dhdNvj/zvq32GeI8WemoTegluSjDa6sohOJpDMN/IkUd9004TZI2p/1xDXw0ONEa5 yykhTXK511yAJf2tMDinXIC4bHb2+ZzTgMR07UtYcZ4/sDGELEpKDRe1y3Rqkw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1691485930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DoNI5v5umT0Z8D7XCCNoP2aZrQ/gIq+jzyHgWzWgdgo=; b=AKO4JGVhFpvSXlHLtgexL3PAvihILrtXinYpKnJnh4vFOWYHw1/0e+Pbm0TdD8Oax1T3wG mduROucX9K/ICRAg== To: Peter Zijlstra Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v2 11/14] futex: Implement FUTEX2_NUMA In-Reply-To: <20230808085406.GU212435@hirez.programming.kicks-ass.net> References: <20230807121843.710612856@infradead.org> <20230807123323.504975124@infradead.org> <87fs4utv6f.ffs@tglx> <20230808085406.GU212435@hirez.programming.kicks-ass.net> Date: Tue, 08 Aug 2023 11:12:09 +0200 Message-ID: <87y1ilsxsm.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C5762100018 X-Stat-Signature: syoqg9941imgb8u7pgc4t5p87ao6i37a X-Rspam-User: X-HE-Tag: 1691485932-429848 X-HE-Meta: U2FsdGVkX1/ye5Gx32U0QpiP98jiemNFwGBzFiGFvkDDwxpfE8+SeY12JmyLrM2RRAyKqULoPmJ+VXvYvxFD3Ke+13GKTXw3YJDkLApdYPuk4rXFCUSsovMiPwIYFc/HiGjm2SzxRblL/BtZl1MsGS5JLQ4ypyoK7rlh8Aghg0bgmeVrWLsHut3LsFC6W0rq3GlBPhd35dIs2lI2gtXW8kKekEDUcQ/+0Zf6EtdCEzrZsywOSaO8Uigp6NQig2qHgQqA6eyrvD4kJaBgBoJFMRKSIgXQwuXoHEqpVcppWDubLKU5krmtcjLVIv3PcABYEZI6lEJEkgGnZMuj1QHidwPQBgeP/jcvuvAjWllHtkyXz+8lEXlf4B7CK69s1lQoU0idY/+r1DqrHW4iCXNQyoB5RsuUjzcqsHzQDdMBHxTJC0EEJf6VT99OOh7iSXYAUdY70t4HFUPSSU6StFNFX8plbFBJBCc1WBD2NbdLI+rmSAvfzHiXnAoOpPR8vtbard6yI8jblEVP99nlwaxAFDP41EqQ9Utj2sUyCTNE7nxcviIWUZjIIySHqzeKwarkwi2ptV9NqF/L8aH8kEhx1kA9Av0mYSO4pKMkL+i3BC+oWiKsf4HmOVhkE1agnaXA0DZWx5it4YEqn0kSalEtDLYHQYec1UznQI/nAZtme9D3NQ+bCXyGFl8RCdxOgX43PIghetygZRxYmJ+Wz48K2y6DrU7al2g7KgDFAOMtKZhrG9CR/LMjSKAmY+Z9tUazNjrKODzzVitqwmVyGp13x+leFBdy+3Al7N0MgK3KBkW3q6CFr16MfLF4MtNvMI+DAbJihG9Fg8DyJvw+7IYCuhQBYWTTjesTCBzaiIKEXOfk5EC0mkKIEsE+FZ2VZADAfTrE/3Q4Cea2emlkrBGR986U5jiclmrFMko7T7Fpheul6KCMsnSNHZrhtFakq/U2Mt3HthWxhX2minxxRWN 05lrdl5x aJFSkYA/C300ZBVie6YqRlquw2URzUZHDk8r7wuHH97JvGrpKURhZE2F+3g9Qj+G4x+fpV065fcHtvIw0KyGBQbx8e5EbDf+kUXES X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08 2023 at 10:54, Peter Zijlstra wrote: > On Mon, Aug 07, 2023 at 11:11:04PM +0200, Thomas Gleixner wrote: >> On Mon, Aug 07 2023 at 14:18, Peter Zijlstra wrote: >> > /** >> > * futex_hash - Return the hash bucket in the global hash >> > * @key: Pointer to the futex key for which the hash is calculated >> > @@ -114,10 +137,29 @@ late_initcall(fail_futex_debugfs); >> > */ >> > struct futex_hash_bucket *futex_hash(union futex_key *key) >> > { >> > - u32 hash = jhash2((u32 *)key, offsetof(typeof(*key), both.offset) / 4, >> > + u32 hash = jhash2((u32 *)key, >> > + offsetof(typeof(*key), both.offset) / sizeof(u32), >> > key->both.offset); >> > + int node = key->both.node; >> > + >> > + if (node == -1) { >> >> NUMA_NO_NODE please all over the place. > > Ah, so our (futex2) ABI states this needs to be -1, but in theory > someone could come along and change the kernel internal NUMA_NO_NODE to > something else. > > That is, I explicitly chose not to use it. I can of course, because as > of now these values do match. Fair enough, but can we at least have a proper define in the futex2 ABI please?