From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B25CD343E for ; Tue, 19 Sep 2023 06:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A74166B04A9; Tue, 19 Sep 2023 02:13:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FD8F6B04AA; Tue, 19 Sep 2023 02:13:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89DA26B04AB; Tue, 19 Sep 2023 02:13:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 752CF6B04A9 for ; Tue, 19 Sep 2023 02:13:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3F8B01CA0E1 for ; Tue, 19 Sep 2023 06:13:24 +0000 (UTC) X-FDA: 81252329928.09.566D573 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by imf03.hostedemail.com (Postfix) with ESMTP id 2EAA020004 for ; Tue, 19 Sep 2023 06:13:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BzaNZwcm; spf=pass (imf03.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695104002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ypuIssOWfiop6vzEXIfzD7iONp5EvpX2OOTXxLuWkdw=; b=RmoxhTK6Byr3VRj+wnyMD5JWQHOPtBtp9KQR2Kvk74vGYM6cA+OHDTSp77tRyPCKB1q0Vr x4evD2sF5JwhGOfRBobtL/3i92MF+jWosMZK+Lu6ADAiUrRAOtU8vWygxH5KWF48LOng+p w6frtzt6clduAkZSeiK7mPClsuo1fW8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695104002; a=rsa-sha256; cv=none; b=5RzEMptpZfdhY535O8Mn0RfzZK+lJejE9PdB+g/r4CMmamtCGXMWAYif3EAtOg3Nyc8r4W 02kp6L/0blEe6qT+9hkF12ShaZ8D/XXsDdvT64/LQK9gHmakvIzwMgW0pewvmdn0UMCtYC sugIy8AGs4pIajLfGlzOao1IYS6TgS0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BzaNZwcm; spf=pass (imf03.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695104002; x=1726640002; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=tuzhrLzSWbdbRydP4kaLVjeVbY9OnSWu+GN5+6pY18A=; b=BzaNZwcmTOFr4/F0Zgazhoj57mt054xev7MMakzsuhW8rFhlkUruZbJh NN0SuPdwANibkl7Pto5AlB/5iZuKxY8BbRxvccdRfQX7LPPZVZgldvZHD rhNgenB241vorQOGcxvbiKRGz7ZS9/2ZDAV5FZ0wx+FolKkW+dXGKUjRE TkbIHwS8vnxvc9cXJj/UVdnYhGi8nVgzAG6ndvR/uLxaP6yj926z0YqdA oC2koVrqrmHJubikvWRduGB5x2zrSRkYTrJruN2EdObUefHUCdzXe05M5 Nw5ru2m4pMJ+5+lopw4KR5VAn3uIYixzM+cP3WJfMwAxy9fBfb22lYo2R w==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="370176611" X-IronPort-AV: E=Sophos;i="6.02,158,1688454000"; d="scan'208";a="370176611" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 23:13:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="811607597" X-IronPort-AV: E=Sophos;i="6.02,158,1688454000"; d="scan'208";a="811607597" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 23:13:15 -0700 From: "Huang, Ying" To: Alistair Popple Cc: Andrew Morton , , , Bharata B Rao , "Aneesh Kumar K . V" , Wei Xu , "Dan Williams" , Dave Hansen , Davidlohr Bueso , Johannes Weiner , Jonathan Cameron , Michal Hocko , Yang Shi , Dave Jiang , Rafael J Wysocki Subject: Re: [PATCH -V3 3/4] acpi, hmat: calculate abstract distance with HMAT References: <20230912082101.342002-1-ying.huang@intel.com> <20230912082101.342002-4-ying.huang@intel.com> <8734za6869.fsf@nvdebian.thelocal> Date: Tue, 19 Sep 2023 14:11:11 +0800 In-Reply-To: <8734za6869.fsf@nvdebian.thelocal> (Alistair Popple's message of "Tue, 19 Sep 2023 15:14:10 +1000") Message-ID: <87y1h2wv40.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 2EAA020004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: csfzg3dh5io3q1zd9ioxzkm8jfstddtn X-HE-Tag: 1695104001-904138 X-HE-Meta: U2FsdGVkX18K5U96yr+EfQ+GNsYO2jvwNTUbt+XtpkU1j950Fbbd4SVeziqHV95HsJZqLrh5IDG4dFU49lYVeSQP07bq4arrA9fYi2KQoeE5jGwsexiPWPJUa7YBCGTAsmbnxUdSfWyvGPt0GRnR+DiIGZfXpTAb6TcpJT/YvpoxHJp1IZoAX541IYQQL5HeL6ZO0WS66ChTozgkI/fbJB0CGCW/l/lrT5tfwxu/E5Y7baaqSAhRDrMmlEEvra2TjEMZGkx4ICP5PBkL31W26Sv7m85NlLHh6lqh1i2/nfwJkqnNresj7tNkw0xm838RZEL2WlnIKP2AtOtB4aKn5/TvYq74AwkPh0WcF48QRsYCDU7ZEdoV3kjxMVOvDc54oDVhj8H2YsSil1bdPAGp26ofS4aU8831/yXgvR8Qs755AIPyxZOk44NNX36jlrC2YMoi9RIUZpzcvAoiU4GoZV4h+jNw2vQkrLA/Wql2vw4TBKZEWjZS27wnTrKWxXh73x89zGbD/0h2CErJKPjHKO3DF9mhBlgjDQbcVdav28pOO/HJ25qi3dLm8HGKecs8ZH4Heiqn4iAUw+dsZ9ze/02LvMjmtCWVe9YUOHXifuG0SEtepSxfcigngFF8l98ImVRRqdeETXsQstHU+wbAP7EgLIZwt7FI3Ke45om9OKdXyKALopOfBodEFqWM5JI7Yav1seOdutHZkuvxFanKh6MXllKI6lLxVhkXKK4wMjbmsbgaFPQFkEWv3W9vtNVwsNY3u22qB9PX/yiRCSFOMVztWFRUuIhv9xsKeU/1USE3OyWeKqAmk8vmx9provfVTOsxGTyNhzRtGN/KwNWhSgBAIASTbZkeN83Y37MGJ8s6guJUt+5/3j+VG3g3QDDjwBlqLawopbYsVek0ilrW+OdZ13n8ZLTF6kYzoTT6OUCKDq21Z9my2yyw0oDUwmyN9D5RHV9DDNzR+wINoF3 +5gRv0DV ZLXABVJ8hHtoAohlPUXFxm+M3jnCfJyNVH+SgmaZmm4JC12yPGwgzssAnNmvhX85iPmnQRhMdg/NRDiJlR2m8mo3oWRt5nO36xAIKC2wkUISmgx8LfI7UKsrL4TW5xf3ScCmBpjXm7qPIlgyLILAHx5CmF3B3yU7UZHEmdmZmxNDMIygfURBK0TCXfMWauYiqAUlN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Alistair Popple writes: > Thanks for making changes here, looks better to me at least. > > Huang Ying writes: > >> static __init void hmat_free_structures(void) >> { >> struct memory_target *target, *tnext; >> @@ -801,6 +857,7 @@ static __init int hmat_init(void) >> struct acpi_table_header *tbl; >> enum acpi_hmat_type i; >> acpi_status status; >> + int usage; >> >> if (srat_disabled() || hmat_disable) >> return 0; >> @@ -841,7 +898,10 @@ static __init int hmat_init(void) >> hmat_register_targets(); >> >> /* Keep the table and structures if the notifier may use them */ >> - if (!hotplug_memory_notifier(hmat_callback, HMAT_CALLBACK_PRI)) >> + usage = !hotplug_memory_notifier(hmat_callback, HMAT_CALLBACK_PRI); >> + if (!hmat_set_default_dram_perf()) >> + usage += !register_mt_adistance_algorithm(&hmat_adist_nb); >> + if (usage) >> return 0; > > Can we simplify the error handling here? As I understand it > hotplug_memory_notifier() and register_mt_adistance_algorithm() aren't > expected to ever fail because hmat_init() should only be called once and > the notifier register shouldn't fail. So wouldn't the below be > effectively the same thing but clearer? > > if (hotplug_memory_notifier(hmat_callback, HMAT_CALLBACK_PRI)) > goto out_put; > > if (!hmat_set_default_dram_perf()) > register_mt_adistance_algorithm(&hmat_adist_nb); > > return 0; > >> out_put: >> hmat_free_structures(); Looks good to me! Will do that in the next version! > Also as an aside while looking at this patch I noticed a minor bug: > > status = acpi_get_table(ACPI_SIG_HMAT, 0, &tbl); > if (ACPI_FAILURE(status)) > goto out_put; > > This will call acpi_put_table(tbl) even though we failed to get the > table. Thanks for pointing this out. This should go through ACPI tree. So will not do this in a separate patch. -- Best Regards, Huang, Ying