From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: "Kees Cook" <keescook@chromium.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
"Sebastian Ott" <sebott@redhat.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v4 4/6] binfmt_elf: Use elf_load() for library
Date: Fri, 29 Sep 2023 10:32:59 -0500 [thread overview]
Message-ID: <87y1gp6llg.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <CAKbZUD1ojuNN_+x6gkxEMsmLOd5KbCs-wfJcMM==b8+k8_uD_w@mail.gmail.com> (Pedro Falcato's message of "Fri, 29 Sep 2023 13:12:13 +0100")
Pedro Falcato <pedro.falcato@gmail.com> writes:
> On Fri, Sep 29, 2023 at 4:24 AM Kees Cook <keescook@chromium.org> wrote:
>>
>> While load_elf_library() is a libc5-ism, we can still replace most of
>> its contents with elf_load() as well, further simplifying the code.
>
> While I understand you want to break as little as possible (as the ELF
> loader maintainer), I'm wondering if we could axe CONFIG_USELIB
> altogether? Since CONFIG_BINFMT_AOUT also got axed. Does this have
> users anywhere?
As I recall:
- libc4 was a.out and used uselib.
- libc5 was elf and used uselib.
- libc6 is elf and has never used uselib.
Anything using libc5 is extremely rare. It is an entire big process to
see if there are any users in existence.
In the meantime changing load_elf_library to use elf_load removes any
maintenance burden.
Eric
next prev parent reply other threads:[~2023-09-29 15:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 3:24 [PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts Kees Cook
2023-09-29 3:24 ` [PATCH v4 1/6] " Kees Cook
2023-09-29 12:06 ` Pedro Falcato
2023-09-29 15:23 ` Eric W. Biederman
2023-09-29 3:24 ` [PATCH v4 2/6] binfmt_elf: elf_bss no longer used by load_elf_binary() Kees Cook
2023-09-29 3:24 ` [PATCH v4 3/6] binfmt_elf: Use elf_load() for interpreter Kees Cook
2023-09-29 3:24 ` [PATCH v4 4/6] binfmt_elf: Use elf_load() for library Kees Cook
2023-09-29 12:12 ` Pedro Falcato
2023-09-29 15:32 ` Eric W. Biederman [this message]
2023-09-29 17:06 ` Kees Cook
2023-09-29 3:24 ` [PATCH v4 5/6] binfmt_elf: Only report padzero() errors when PROT_WRITE Kees Cook
2023-09-29 3:24 ` [PATCH v4 6/6] mm: Remove unused vm_brk() Kees Cook
2023-09-29 11:33 ` [PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts Sebastian Ott
2023-09-29 15:45 ` Eric W. Biederman
2023-09-29 17:09 ` Kees Cook
2023-09-29 11:58 ` Pedro Falcato
2023-09-29 15:39 ` Eric W. Biederman
2023-09-29 17:07 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1gp6llg.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@weissschuh.net \
--cc=pedro.falcato@gmail.com \
--cc=sebott@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox