From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FC03CDB486 for ; Thu, 19 Oct 2023 05:57:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD21780089; Thu, 19 Oct 2023 01:56:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D843580046; Thu, 19 Oct 2023 01:56:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C70A480089; Thu, 19 Oct 2023 01:56:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B85D380046 for ; Thu, 19 Oct 2023 01:56:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 782771A1186 for ; Thu, 19 Oct 2023 05:56:59 +0000 (UTC) X-FDA: 81361152558.01.7B0BAED Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 8E60F100010 for ; Thu, 19 Oct 2023 05:56:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Smj2XLAM; spf=pass (imf05.hostedemail.com: domain of bjorn@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697695016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uwIr5PLksnwLyxgqpvtx+QliRJtVX8iY9+2hAVOlS40=; b=qhQ3odlD6zoPCZVqmnXCvsbOsE/k9/31zoGpCkT50UJlvMd27DeUJiT4BWLWY//DPrmqaW Oz5vW/j47hvHpVJ0VkPZLaHQ1b3UNKpRehq4NpepTFJOowwoFCtg+MUk1oHzhzj2HlaHdG LHYOKo2Qw+ZwawHujRMnB4xKjZ3f3EQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697695016; a=rsa-sha256; cv=none; b=oDKLdo4fFU8GjZAPYnCY19txy8ukVPfjlMA9OnYbcTT0FTljRVhz6QgV3H2w8V1saQzRIg XzRycHRX7HjOdR49aomig0Zu2ODcmkShk7GpqCw8i/hQrvs6Mhnv3yxQbLOJm0oR5zITYD 9TL/yWrgCg6zj6gFqDJWnZtUmy0o1AY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Smj2XLAM; spf=pass (imf05.hostedemail.com: domain of bjorn@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CC39AB82638; Thu, 19 Oct 2023 05:56:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D97A2C433C7; Thu, 19 Oct 2023 05:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697695014; bh=uwIr5PLksnwLyxgqpvtx+QliRJtVX8iY9+2hAVOlS40=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Smj2XLAMaNBJ1/8/b0GDTW7Kox2CgBUOvlYD9PNeDgRBrWEmUCmfnRlP0oWmsR808 08jm9ZKZUsbpARNM8oqluOYrjMFym4ezH8hzYoonUL0pc5bu8JWNdiogCMVuez5p7n 0ENO7X9EDvNG7DkUGBce8+SzhBnmUiAmKALM6AGCI37CZTJJYQEWaJ0YY5y1zuXAWK HwWHZU8/x+39fDDSQy1cWs8iy5H0mM+AKle6dcGnMB6G9rHMgnPUoH34l/ymfxeFXq jzE4Vp6zgTmY4n9IsfO3MDrdoJ6HcN8idM2l6swOcRnXFT8Jlzlpp7SZMfTPtYRRYF 5eKVn0U6y5prQ== From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= To: Conor Dooley , Charlie Jenkins Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Biederman , Kees Cook , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: Re: [PATCH v4 0/2] riscv: Add remaining module relocations and tests In-Reply-To: <20231018-confidant-frostily-e8f4dbdcd478@spud> References: <20231017-module_relocations-v4-0-937f5ef316f0@rivosinc.com> <20231018-smite-bungee-f46b15b4ce6f@spud> <20231018-confidant-frostily-e8f4dbdcd478@spud> Date: Thu, 19 Oct 2023 07:56:51 +0200 Message-ID: <87y1fzxiho.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8E60F100010 X-Rspam-User: X-Stat-Signature: zg46ni1b9abrfkscp6wrj3sduty8x3h4 X-Rspamd-Server: rspam03 X-HE-Tag: 1697695016-162130 X-HE-Meta: U2FsdGVkX19CgmM0qkxIjlluvQB76SMEhDK69ibBaDl+H8o5PlN0mTIQ4/KG33GCFeIP8A71KsF5eHBDB4OTqzmbijkoht5Fu0BU+wBMIDs5XFwoNziyo+SUSDEF8QLbFZ6uQ9aAp25P4wbop+LVmvbiJzwadetIf8mp8tTaaVZOyBowDRkR36OJvmn1MgwSIOzECqV7Vz1JMUxQz7o/qaf39Sen55WzvMuQjI+huRkuD6VSEuCG1QBMGSOZyqXLOVDGkCgAos+pX3h647glpRwfLdzRuLmh3ai4rpiYugsA/EAQBvOPbf7DmJl0Ek5+LrcOayzYv2QH9udR77S3KsZx8e9810Wm1L+WFnKkM084ScZkrw9ulH2hX0LYk5hUZjm6hw/T/9vsYYpGhRi4ZdTdgbOJ0IqkBk/scqs8bJQFcuta6BY/CHEKGe9w+SVlC1/6iXleJpJgAweXCV1ncSoGbDS3NSgrh+9fbcqyElit/FcxjOo59Dvhsq60uN0tIhIGi7HELvCyWK5K3I8OfdJsk1Qy6BGUuGZxvkWRWxQcliLYfQukA/PQIuIZDUNtEoqz6HoJDGE8exfhVnxsCvHUZTQa4W3qAr8dxq0OeUSX9Z5w+Wdhr+veqUT1O5WA6CeSz5I+jADX8Je2wasWP2xjO1byEFsgimJnunITJ+8H7F+BjEx+NygVNAFrxjd7P147IvHoFx8AkXS/F/Rt835kR2xlV+q1wV3FPkCYY9CCHHE5znCpNLyDJLiMF7mDFx0ChovYg5Hksjrn9VcW+5M2Xz3EGcIWcXxMUYKtyxHJvZ8+LadjU88ULU5GTdR0vh/AHOvZwDFu84v4eJOgXM1fgnAtFcXQ6HpNUaQC3KKnbbnKJlBccF1YOXVts9pWeew8JXtDIVNtZQP+Ab0C6eA+Fv6ZsrV9CdEFC2FNz59/z5mUTtD9LZmYZiZUv0HGgLwSIHjStmtwgg+S3RD CCPuGTWm rgjMbGoOgqETaQWaR3ctlvVMx1QMHRv1+/JIM1VjiLZrhUrUKfDViGOZF6ZKsWspuX4lDRMk1PLqGnEk/7Dv62iDYvJSvhuhBudNj9prM8CsBuQ8SDm9c92okpg4ZBQPDAOMCgTv28LPFdH3I61hDN0GQVoDH4AaRUKLAcsHVQ71Bfa5Ac1CC0L39aCJjSympSXbjYboFWDvqJRlkznjEGrWMt+JzIeZKJMn1JpwV2BhCTX1e+Z440EaaouRrYvBkisumX3ce0dQqfQpgQOLkEpiyX3Lb+3b2gqp5d9SN7jnKeGnNFxWLColf8kx3F6RsQ2FFf6FCjHcMwKGGyDOmu+ZzWpWRoU8hcChG+LmDBeqPsl4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Conor Dooley writes: > On Wed, Oct 18, 2023 at 10:31:29AM -0700, Charlie Jenkins wrote: >> On Wed, Oct 18, 2023 at 12:35:55PM +0100, Conor Dooley wrote: >> > Hey Charlie, >> >=20 >> > On Tue, Oct 17, 2023 at 10:34:15PM -0700, Charlie Jenkins wrote: >> > > A handful of module relocations were missing, this patch includes the >> > > remaining ones. I also wrote some test cases to ensure that module >> > > loading works properly. Some relocations cannot be supported in the >> > > kernel, these include the ones that rely on thread local storage and >> > > dynamic linking. >> > >=20 >> > > ULEB128 handling is a bit special because SET and SUB relocations mu= st >> > > happen together, and SET must happen before SUB. A psABI proposal [1] >> > > mandates that the first SET_ULEB128 that appears before a SUB_ULEB128 >> > > is the associated SET_ULEB128. >> > >=20 >> > > This can be tested by enabling KUNIT, RUNTIME_KERNEL_TESTING_MENU, a= nd >> > > RISCV_MODULE_LINKING_KUNIT. >> > >=20 >> > > [1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/403 >> > >=20 >> > > Signed-off-by: Charlie Jenkins >> > > --- >> > > Changes in v4: >> > > - Complete removal of R_RISCV_RVC_LUI >> > > - Fix bug in R_RISCV_SUB6 linking >> > > - Only build ULEB128 tests if supported by toolchain >> > > - Link to v3: https://lore.kernel.org/r/20231016-module_relocations-= v3-0-a667fd6071e9@rivosinc.com >> >=20 >> > On patch 2/2: >> >=20 >> > ../arch/riscv/kernel/tests/module_test/test_uleb128.S:18:17: error: un= known relocation name >> > ../arch/riscv/kernel/tests/module_test/test_uleb128.S:19:17: error: un= known relocation name >> >=20 >> > Same toolchain configuration in the patchwork automation as before. >> >=20 >> > Cheers, >> > Conor. >>=20 >> Where do you see this error? On Patchwork I see a success [1]. >>=20 >> [1] https://patchwork.kernel.org/project/linux-riscv/patch/20231017-modu= le_relocations-v4-2-937f5ef316f0@rivosinc.com/ > > It was a failure this morning! > See > > > I wonder if there is something wrong with the CI code, where it > erroneously reports the state from previous patches and then runs the > tests again with the new patches and re-pushes the results. > > Bjorn, any idea? The PW syncher tries to reuse the Github PR branch for newer versions. Say that v4 has some set of results, and v5 some set of results. Then, it'll be a bit of flux until v5 is fully built. Hmm, I'll try to improve that. The PW v4 should never get results from PW v5... FWIW, the v5 of the series https://patchwork.kernel.org/project/linux-riscv/list/?series=3D794521 has a bunch of errors. Bj=C3=B6rn